From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id B53917030F; Thu, 25 Feb 2021 17:37:30 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B53917030F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1614263850; bh=VSpx8ZCF0yCHQjtCZ/gRo+s8WVjM8vk0YIgLYYp+HNI=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=CChrnf6BnM95L1ycqnlkrgQ/+xB88Wt1s7o9KIysFLh908aS6YU0xouzxoe9zS+Ft f3zOHFE7XxpaKm2AG6APtiwrRcdMy2KrZ+vnaxsrppn4tleY6Cg/sWJHyylsTxEti+ 8heslrKYHPp+aD09NWiOCvUExLQPMpGCXuMgGMe0= Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id E83E57030F for ; Thu, 25 Feb 2021 17:37:26 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E83E57030F Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1lFHld-0005HQ-P1; Thu, 25 Feb 2021 17:37:26 +0300 To: Artem Starshov , Alexander Turenko References: Message-ID: <34151f0e-4eec-3a07-d2a8-e4f18a11d606@tarantool.org> Date: Thu, 25 Feb 2021 17:37:25 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD975C3EC174F566922928A658C60196E87DF7449A63D990329182A05F5380850409C7DAB05845DD96EE3C171A32C5A721188D78AE7282AF96814D3B4EE5B2D9E2B X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE792C68BF9CD4C0E9EEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637DB576DCB83B448D28638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95CDDE882590F889B1C6364C5947924611A67EE323D38BF4C22A471835C12D1D9774AD6D5ED66289B5278DA827A17800CE71AE4D56B06699BBC9FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C3ED8438A78DFE0A9E117882F4460429728AD0CFFFB425014E868A13BD56FB6657A7F4EDE966BC389F9E8FC8737B5C22490A9A04DE7321024275ECD9A6C639B01BBD4B6F7A4D31EC0BC0CAF46E325F83A522CA9DD8327EE4930A3850AC1BE2E73564E4DC1543031AB7C4224003CC836476C0CAF46E325F83A50BF2EBBBDD9D6B0F05F538519369F3743B503F486389A921A5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A59BCA347A9DE26541C807BBD82FCBFA28CEDE7D4A80410624D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75B7BFB303F1C7DB4D8E8E86DC7131B365E7726E8460B7C23C X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D340B06C327CE4A70E8506AF03CF462C9A27C14333015F5E381FB2A469F390A5C6F4E464FEF8DE63F811D7E09C32AA3244CFEDE696266839C7E12A554296643242833C9DC155518937F927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojvz1c9SWJtj8DTz1KYNgE+A== X-Mailru-Sender: 689FA8AB762F73936BC43F508A06382207AAB7F6CBE9C0EC6BB4DF0241EA74ADDD788429FD8613638ED9BB8B05EE7B3AFB559BB5D741EB96D19CD4E7312BAA970A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCHv2 0/2] lua: fix tarantool -e always enters interactive mode X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for the patches! LGTM On 18.02.2021 22:30, Artem Starshov wrote: > Issue: https://github.com/tarantool/tarantool/issues/5040 > Branch: https://github.com/tarantool/tarantool/tree/artemreyt/gh-5040-interactive-mode-bug > CI: https://github.com/tarantool/tarantool/runs/1929677579 > > Previous patch version: https://lists.tarantool.org/pipermail/tarantool-patches/2021-January/022144.html > > Changes in v2: > * core: > - added `part of #5040` to the commit message; > - rename `errinj_scan_env()` -> `errinj_set_with_environment_vars()`; > - whitespaces refactored; > - add test for setting error injections via environment variables; > * lua: > - little code refactoring after Sergey Bronnikov review (renames and move > includes in the alphabetical order); > - fixed bug, when test failed under high concurrency. There were about 20 > fails with 100 workers. Now, it's ok, tested with 300 workers om CentOS and > macOS. > (Bug resolved with removing temporary output_file after each testcase iteration); > - moved ChangeLog to the last commit. > > Artem Starshov (2): > core: add setting error injections via env > lua: fix tarantool -e always enters interactive mode > > src/lib/core/errinj.c | 26 ++++ > src/lib/core/errinj.h | 6 + > src/lua/init.c | 20 ++- > src/main.cc | 1 + > ...40-always-enters-interactive-mode.test.lua | 131 ++++++++++++++++++ > .../errinj_set_with_enviroment_vars.test.lua | 14 ++ > ...errinj_set_with_enviroment_vars_script.lua | 13 ++ > test/box/errinj.result | 1 + > 8 files changed, 208 insertions(+), 4 deletions(-) > create mode 100755 test/app-tap/gh-5040-always-enters-interactive-mode.test.lua > create mode 100755 test/box-tap/errinj_set_with_enviroment_vars.test.lua > create mode 100644 test/box-tap/errinj_set_with_enviroment_vars_script.lua >