Tarantool development patches archive
 help / color / mirror / Atom feed
From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Ostanevich <sergos@tarantool.org>,
	Igor Munkin <imun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: [Tarantool-patches] [PATCH luajit 6/6] test: skip test for getenv in 309-os.t
Date: Fri, 12 Mar 2021 08:27:34 +0300	[thread overview]
Message-ID: <2ff2254fb4feff43746be0b6ee2d4299510ce252.1615470667.git.skaplun@tarantool.org> (raw)
In-Reply-To: <cover.1615470667.git.skaplun@tarantool.org>

Inside Tarantool's GiHub-CI there is not defined variable LOGNAME nor
USERNAME. This leads to failed test inside CI, because a string is
expected.

This test is skipped when this variable is `nil`.

Part of tarantool/tarantool#5844
Part of tarantool/tarantool#4473
---
 test/lua-Harness-tests/309-os.t | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/test/lua-Harness-tests/309-os.t b/test/lua-Harness-tests/309-os.t
index f94db00..6b3ea4d 100755
--- a/test/lua-Harness-tests/309-os.t
+++ b/test/lua-Harness-tests/309-os.t
@@ -170,7 +170,11 @@ do -- getenv
     is(os.getenv('__IMPROBABLE__'), nil, "function getenv")
 
     local user = os.getenv('LOGNAME') or os.getenv('USERNAME')
-    type_ok(user, 'string', "function getenv")
+    if not user then
+        skip("no LOGNAME and USERNAME")
+    else
+        type_ok(user, 'string', "function getenv")
+    end
 end
 
 do -- remove
-- 
2.28.0


  parent reply	other threads:[~2021-03-12  5:31 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-12  5:27 [Tarantool-patches] [PATCH luajit 0/6] Adapt lua-Harness test suite Sergey Kaplun via Tarantool-patches
2021-03-12  5:27 ` [Tarantool-patches] [PATCH luajit 1/6] test: add " Sergey Kaplun via Tarantool-patches
2021-03-15 13:05   ` Igor Munkin via Tarantool-patches
2021-03-12  5:27 ` [Tarantool-patches] [PATCH luajit 2/6] test: adjust lua-Harness test suite for Tarantool Sergey Kaplun via Tarantool-patches
2021-03-13 18:41   ` Sergey Ostanevich via Tarantool-patches
2021-03-15 13:22   ` Igor Munkin via Tarantool-patches
2021-03-12  5:27 ` [Tarantool-patches] [PATCH luajit 3/6] test: disable 305-utf8 of lua-Harness suite Sergey Kaplun via Tarantool-patches
2021-03-13 18:45   ` Sergey Ostanevich via Tarantool-patches
2021-03-15 12:45   ` Igor Munkin via Tarantool-patches
2021-03-12  5:27 ` [Tarantool-patches] [PATCH luajit 4/6] test: disable 241-standalone " Sergey Kaplun via Tarantool-patches
2021-03-13 18:45   ` Sergey Ostanevich via Tarantool-patches
2021-03-15 12:47   ` Igor Munkin via Tarantool-patches
2021-03-12  5:27 ` [Tarantool-patches] [PATCH luajit 5/6] test: disable 411-luajit " Sergey Kaplun via Tarantool-patches
2021-03-13 18:46   ` Sergey Ostanevich via Tarantool-patches
2021-03-15 12:48   ` Igor Munkin via Tarantool-patches
2021-03-12  5:27 ` Sergey Kaplun via Tarantool-patches [this message]
2021-03-13 18:50   ` [Tarantool-patches] [PATCH luajit 6/6] test: skip test for getenv in 309-os.t Sergey Ostanevich via Tarantool-patches
2021-03-15 10:22     ` Igor Munkin via Tarantool-patches
2021-03-13 18:22 ` [Tarantool-patches] [PATCH luajit 0/6] Adapt lua-Harness test suite Sergey Ostanevich via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2ff2254fb4feff43746be0b6ee2d4299510ce252.1615470667.git.skaplun@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=imun@tarantool.org \
    --cc=sergos@tarantool.org \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH luajit 6/6] test: skip test for getenv in 309-os.t' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox