From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit 6/6] test: skip test for getenv in 309-os.t
Date: Mon, 15 Mar 2021 13:22:04 +0300 [thread overview]
Message-ID: <20210315102204.GW9042@tarantool.org> (raw)
In-Reply-To: <9B7EE225-4CF0-4C2E-947E-69ECDF129A89@tarantool.org>
Sergey,
On 13.03.21, Sergey Ostanevich wrote:
> Hi!
>
> Thanks for the patch!
>
> Shall we consider an environment being set in cmake dedicated to the Tarantool’s
> testing?
Totally agree with Sergos: this patch is excess (we even lose one test
case from the suite) and the issue can be resolved within Tarantool
build system (either cmake/luajit.cmake or test/CMakeLists.txt).
>
> Regards,
> Sergos
>
>
<snipped>
>
--
Best regards,
IM
next prev parent reply other threads:[~2021-03-15 10:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-12 5:27 [Tarantool-patches] [PATCH luajit 0/6] Adapt lua-Harness test suite Sergey Kaplun via Tarantool-patches
2021-03-12 5:27 ` [Tarantool-patches] [PATCH luajit 1/6] test: add " Sergey Kaplun via Tarantool-patches
2021-03-15 13:05 ` Igor Munkin via Tarantool-patches
2021-03-12 5:27 ` [Tarantool-patches] [PATCH luajit 2/6] test: adjust lua-Harness test suite for Tarantool Sergey Kaplun via Tarantool-patches
2021-03-13 18:41 ` Sergey Ostanevich via Tarantool-patches
2021-03-15 13:22 ` Igor Munkin via Tarantool-patches
2021-03-12 5:27 ` [Tarantool-patches] [PATCH luajit 3/6] test: disable 305-utf8 of lua-Harness suite Sergey Kaplun via Tarantool-patches
2021-03-13 18:45 ` Sergey Ostanevich via Tarantool-patches
2021-03-15 12:45 ` Igor Munkin via Tarantool-patches
2021-03-12 5:27 ` [Tarantool-patches] [PATCH luajit 4/6] test: disable 241-standalone " Sergey Kaplun via Tarantool-patches
2021-03-13 18:45 ` Sergey Ostanevich via Tarantool-patches
2021-03-15 12:47 ` Igor Munkin via Tarantool-patches
2021-03-12 5:27 ` [Tarantool-patches] [PATCH luajit 5/6] test: disable 411-luajit " Sergey Kaplun via Tarantool-patches
2021-03-13 18:46 ` Sergey Ostanevich via Tarantool-patches
2021-03-15 12:48 ` Igor Munkin via Tarantool-patches
2021-03-12 5:27 ` [Tarantool-patches] [PATCH luajit 6/6] test: skip test for getenv in 309-os.t Sergey Kaplun via Tarantool-patches
2021-03-13 18:50 ` Sergey Ostanevich via Tarantool-patches
2021-03-15 10:22 ` Igor Munkin via Tarantool-patches [this message]
2021-03-13 18:22 ` [Tarantool-patches] [PATCH luajit 0/6] Adapt lua-Harness test suite Sergey Ostanevich via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210315102204.GW9042@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=imun@tarantool.org \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit 6/6] test: skip test for getenv in 309-os.t' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox