From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Sergey Kaplun <skaplun@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH luajit 1/6] test: add lua-Harness test suite Date: Mon, 15 Mar 2021 16:05:56 +0300 [thread overview] Message-ID: <20210315130555.GA9042@tarantool.org> (raw) In-Reply-To: <639a4804ee9c20ac3b8cd58540c612d0bcf693ad.1615470667.git.skaplun@tarantool.org> Sergey, This patch doesn't respect the process we were talking many times: the first commit moves the suite intact, to be sure we are testing against the right suite. Furthermore, please specify the exact path and revision checked to our source tree like it is done here[1]. On 12.03.21, Sergey Kaplun wrote: > This patch adds lua-Harness test suite: > https://fperrad.frama.io/lua-Harness/ > > For lua binary name detection the new function `get_lua_binary_name()` > is introduced. It is necessary because LUAJIT_TEST_COMMAND > always extends an amount of line argument by two and a new universal > way to detect program name is required. > > Some tests may fail after this commit. They will be disabled > or adapted in the next patches. > > Part of tarantool/tarantool#5844 > Part of tarantool/tarantool#4473 > --- > Author: Mergen Imeev <imeevma@gmail.com> > <snipped> > -- > 2.28.0 > [1]: https://github.com/tarantool/luajit/commit/d232a3f -- Best regards, IM
next prev parent reply other threads:[~2021-03-15 13:06 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-12 5:27 [Tarantool-patches] [PATCH luajit 0/6] Adapt " Sergey Kaplun via Tarantool-patches 2021-03-12 5:27 ` [Tarantool-patches] [PATCH luajit 1/6] test: add " Sergey Kaplun via Tarantool-patches 2021-03-15 13:05 ` Igor Munkin via Tarantool-patches [this message] 2021-03-12 5:27 ` [Tarantool-patches] [PATCH luajit 2/6] test: adjust lua-Harness test suite for Tarantool Sergey Kaplun via Tarantool-patches 2021-03-13 18:41 ` Sergey Ostanevich via Tarantool-patches 2021-03-15 13:22 ` Igor Munkin via Tarantool-patches 2021-03-12 5:27 ` [Tarantool-patches] [PATCH luajit 3/6] test: disable 305-utf8 of lua-Harness suite Sergey Kaplun via Tarantool-patches 2021-03-13 18:45 ` Sergey Ostanevich via Tarantool-patches 2021-03-15 12:45 ` Igor Munkin via Tarantool-patches 2021-03-12 5:27 ` [Tarantool-patches] [PATCH luajit 4/6] test: disable 241-standalone " Sergey Kaplun via Tarantool-patches 2021-03-13 18:45 ` Sergey Ostanevich via Tarantool-patches 2021-03-15 12:47 ` Igor Munkin via Tarantool-patches 2021-03-12 5:27 ` [Tarantool-patches] [PATCH luajit 5/6] test: disable 411-luajit " Sergey Kaplun via Tarantool-patches 2021-03-13 18:46 ` Sergey Ostanevich via Tarantool-patches 2021-03-15 12:48 ` Igor Munkin via Tarantool-patches 2021-03-12 5:27 ` [Tarantool-patches] [PATCH luajit 6/6] test: skip test for getenv in 309-os.t Sergey Kaplun via Tarantool-patches 2021-03-13 18:50 ` Sergey Ostanevich via Tarantool-patches 2021-03-15 10:22 ` Igor Munkin via Tarantool-patches 2021-03-13 18:22 ` [Tarantool-patches] [PATCH luajit 0/6] Adapt lua-Harness test suite Sergey Ostanevich via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210315130555.GA9042@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=imun@tarantool.org \ --cc=skaplun@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH luajit 1/6] test: add lua-Harness test suite' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox