From: Sergey Ostanevich via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit 0/6] Adapt lua-Harness test suite
Date: Sat, 13 Mar 2021 21:22:35 +0300 [thread overview]
Message-ID: <16E39C08-397B-4A38-953A-B9EB85CD9C8B@tarantool.org> (raw)
In-Reply-To: <cover.1615470667.git.skaplun@tarantool.org>
Hi!
Thanks for the patch!
I believe it’s no good to put the initial test suit commit different from the
original. Namely: the ’tap.lua’ was renamed. Test suite is not runnable as a
result. Then all tests were changed to use the renamed version in a separate
commit. I believe the rename should belong there - in rename patch - hence keep
consistency in testability.
Regards,
Sergos
> On 12 Mar 2021, at 08:27, Sergey Kaplun <skaplun@tarantool.org> wrote:
>
> In this patchset lua-Harness test suite is adapted for the LuaJIT fork
> and Tarantool.
>
> Branch: https://github.com/tarantool/luajit/tree/skaplun/gh-5844-adapt-lua-harness-test-suite
> Tarantool's branch for tests:
> https://github.com/tarantool/tarantool/tree/skaplun/gh-5844-adapt-lua-harness-test-suite
> Issues:
> * https://github.com/tarantool/tarantool/issues/5844
> * https://github.com/tarantool/tarantool/issues/5473
>
> You can check the accuracy of the first patch with the following commands:
> | $ cd ~/tmp/lua-Harness && git remote -v && echo $(git log -n1) && cd -
> | origin https://framagit.org/fperrad/lua-Harness.git (fetch)
> | origin https://framagit.org/fperrad/lua-Harness.git (push)
> | commit a74be274d299dc299228dc7a09052759da9ceac4 Author: Francois Perrad <francois.perrad@gadz.org> Date: Wed Mar 3 15:15:59 2021 +0100 Makefile for lua-5.4.3-rc1
> |
> | $ diff --color -ur ~/tmp/lua-Harness/test_lua/ test/lua-Harness-tests/
>
> Mergen Imeev (2):
> test: add lua-Harness test suite
> test: adjust lua-Harness test suite for Tarantool
>
> Sergey Kaplun (4):
> test: disable 305-utf8 of lua-Harness suite
> test: disable 241-standalone of lua-Harness suite
> test: disable 411-luajit of lua-Harness suite
> test: skip test for getenv in 309-os.t
>
> .gitignore | 1 +
> .luacheckrc | 1 +
> test/CMakeLists.txt | 4 +-
> test/lua-Harness-tests/000-sanity.t | 54 ++
> test/lua-Harness-tests/001-if.t | 88 ++
> test/lua-Harness-tests/002-table.t | 67 ++
> test/lua-Harness-tests/011-while.t | 89 ++
> test/lua-Harness-tests/012-repeat.t | 85 ++
> test/lua-Harness-tests/014-fornum.t | 151 +++
> test/lua-Harness-tests/015-forlist.t | 111 +++
> test/lua-Harness-tests/090-tap.t | 37 +
> test/lua-Harness-tests/091-profile.t | 45 +
> test/lua-Harness-tests/101-boolean.t | 127 +++
> test/lua-Harness-tests/102-function.t | 206 +++++
> test/lua-Harness-tests/103-nil.t | 127 +++
> test/lua-Harness-tests/104-number.t | 246 +++++
> test/lua-Harness-tests/105-string.t | 277 ++++++
> test/lua-Harness-tests/106-table.t | 135 +++
> test/lua-Harness-tests/107-thread.t | 135 +++
> test/lua-Harness-tests/108-userdata.t | 132 +++
> test/lua-Harness-tests/200-examples.t | 104 +++
> test/lua-Harness-tests/201-assign.t | 150 +++
> test/lua-Harness-tests/202-expr.t | 157 ++++
> test/lua-Harness-tests/203-lexico.t | 147 +++
> test/lua-Harness-tests/204-grammar.t | 233 +++++
> test/lua-Harness-tests/211-scope.t | 86 ++
> test/lua-Harness-tests/212-function.t | 288 ++++++
> test/lua-Harness-tests/213-closure.t | 98 ++
> test/lua-Harness-tests/214-coroutine.t | 244 +++++
> test/lua-Harness-tests/221-table.t | 120 +++
> test/lua-Harness-tests/222-constructor.t | 119 +++
> test/lua-Harness-tests/223-iterator.t | 203 +++++
> test/lua-Harness-tests/231-metatable.t | 602 ++++++++++++
> test/lua-Harness-tests/232-object.t | 314 +++++++
> .../241-standalone.t.disabled | 269 ++++++
> test/lua-Harness-tests/242-luac.t | 341 +++++++
> test/lua-Harness-tests/301-basic.t | 859 ++++++++++++++++++
> test/lua-Harness-tests/303-package.t | 290 ++++++
> test/lua-Harness-tests/304-string.t | 633 +++++++++++++
> test/lua-Harness-tests/305-utf8.t.disabled | 55 ++
> test/lua-Harness-tests/306-table.t | 372 ++++++++
> test/lua-Harness-tests/307-math.t | 375 ++++++++
> test/lua-Harness-tests/308-io.t | 397 ++++++++
> test/lua-Harness-tests/309-os.t | 275 ++++++
> test/lua-Harness-tests/310-debug.t | 322 +++++++
> test/lua-Harness-tests/311-bit32.t | 127 +++
> test/lua-Harness-tests/314-regex.t | 222 +++++
> test/lua-Harness-tests/320-stdin.t | 133 +++
> test/lua-Harness-tests/401-bitop.t | 106 +++
> test/lua-Harness-tests/402-ffi.t | 142 +++
> test/lua-Harness-tests/403-jit.t | 163 ++++
> test/lua-Harness-tests/404-ext.t | 171 ++++
> test/lua-Harness-tests/411-luajit.t.disabled | 211 +++++
> test/lua-Harness-tests/CMakeLists.txt | 62 ++
> test/lua-Harness-tests/lexico52/lexico.t | 45 +
> test/lua-Harness-tests/lexico53/boolean.t | 43 +
> test/lua-Harness-tests/lexico53/function.t | 66 ++
> test/lua-Harness-tests/lexico53/lexico.t | 30 +
> test/lua-Harness-tests/lexico53/nil.t | 43 +
> test/lua-Harness-tests/lexico53/number.t | 181 ++++
> test/lua-Harness-tests/lexico53/string.t | 169 ++++
> test/lua-Harness-tests/lexico53/table.t | 43 +
> test/lua-Harness-tests/lexico53/thread.t | 45 +
> test/lua-Harness-tests/lexico53/userdata.t | 45 +
> test/lua-Harness-tests/lexico53/utf8.t | 179 ++++
> test/lua-Harness-tests/lexico54/lexico.t | 19 +
> test/lua-Harness-tests/lexico54/metatable.t | 38 +
> test/lua-Harness-tests/lexico54/utf8.t | 54 ++
> test/lua-Harness-tests/lexicojit/basic.t | 27 +
> test/lua-Harness-tests/lexicojit/ext.t | 52 ++
> test/lua-Harness-tests/lexicojit/lexico.t | 32 +
> test/lua-Harness-tests/profile.lua | 53 ++
> test/lua-Harness-tests/profile_lua51.lua | 46 +
> .../profile_lua51_strict.lua | 46 +
> test/lua-Harness-tests/profile_lua52.lua | 46 +
> .../profile_lua52_strict.lua | 46 +
> test/lua-Harness-tests/profile_lua53.lua | 52 ++
> .../profile_lua53_noconv.lua | 55 ++
> .../profile_lua53_strict.lua | 52 ++
> test/lua-Harness-tests/profile_lua54.lua | 52 ++
> .../profile_lua54_noconv.lua | 55 ++
> .../profile_lua54_strict.lua | 53 ++
> test/lua-Harness-tests/profile_luajit20.lua | 53 ++
> .../profile_luajit20_compat52.lua | 53 ++
> test/lua-Harness-tests/profile_luajit21.lua | 53 ++
> .../profile_luajit21_compat52.lua | 53 ++
> test/lua-Harness-tests/profile_openresty.lua | 53 ++
> test/lua-Harness-tests/profile_ravi.lua | 58 ++
> test/lua-Harness-tests/profile_tiny_fork.lua | 60 ++
> test/lua-Harness-tests/rx_captures | 13 +
> test/lua-Harness-tests/rx_charclass | 38 +
> test/lua-Harness-tests/rx_metachars | 117 +++
> test/lua-Harness-tests/tap_harness.lua | 212 +++++
> 93 files changed, 12937 insertions(+), 1 deletion(-)
> create mode 100755 test/lua-Harness-tests/000-sanity.t
> create mode 100755 test/lua-Harness-tests/001-if.t
> create mode 100755 test/lua-Harness-tests/002-table.t
> create mode 100755 test/lua-Harness-tests/011-while.t
> create mode 100755 test/lua-Harness-tests/012-repeat.t
> create mode 100755 test/lua-Harness-tests/014-fornum.t
> create mode 100755 test/lua-Harness-tests/015-forlist.t
> create mode 100755 test/lua-Harness-tests/090-tap.t
> create mode 100755 test/lua-Harness-tests/091-profile.t
> create mode 100755 test/lua-Harness-tests/101-boolean.t
> create mode 100755 test/lua-Harness-tests/102-function.t
> create mode 100755 test/lua-Harness-tests/103-nil.t
> create mode 100755 test/lua-Harness-tests/104-number.t
> create mode 100755 test/lua-Harness-tests/105-string.t
> create mode 100755 test/lua-Harness-tests/106-table.t
> create mode 100755 test/lua-Harness-tests/107-thread.t
> create mode 100755 test/lua-Harness-tests/108-userdata.t
> create mode 100755 test/lua-Harness-tests/200-examples.t
> create mode 100755 test/lua-Harness-tests/201-assign.t
> create mode 100755 test/lua-Harness-tests/202-expr.t
> create mode 100755 test/lua-Harness-tests/203-lexico.t
> create mode 100755 test/lua-Harness-tests/204-grammar.t
> create mode 100755 test/lua-Harness-tests/211-scope.t
> create mode 100755 test/lua-Harness-tests/212-function.t
> create mode 100755 test/lua-Harness-tests/213-closure.t
> create mode 100755 test/lua-Harness-tests/214-coroutine.t
> create mode 100755 test/lua-Harness-tests/221-table.t
> create mode 100755 test/lua-Harness-tests/222-constructor.t
> create mode 100755 test/lua-Harness-tests/223-iterator.t
> create mode 100755 test/lua-Harness-tests/231-metatable.t
> create mode 100755 test/lua-Harness-tests/232-object.t
> create mode 100755 test/lua-Harness-tests/241-standalone.t.disabled
> create mode 100755 test/lua-Harness-tests/242-luac.t
> create mode 100755 test/lua-Harness-tests/301-basic.t
> create mode 100755 test/lua-Harness-tests/303-package.t
> create mode 100755 test/lua-Harness-tests/304-string.t
> create mode 100755 test/lua-Harness-tests/305-utf8.t.disabled
> create mode 100755 test/lua-Harness-tests/306-table.t
> create mode 100755 test/lua-Harness-tests/307-math.t
> create mode 100755 test/lua-Harness-tests/308-io.t
> create mode 100755 test/lua-Harness-tests/309-os.t
> create mode 100755 test/lua-Harness-tests/310-debug.t
> create mode 100755 test/lua-Harness-tests/311-bit32.t
> create mode 100755 test/lua-Harness-tests/314-regex.t
> create mode 100755 test/lua-Harness-tests/320-stdin.t
> create mode 100755 test/lua-Harness-tests/401-bitop.t
> create mode 100755 test/lua-Harness-tests/402-ffi.t
> create mode 100755 test/lua-Harness-tests/403-jit.t
> create mode 100755 test/lua-Harness-tests/404-ext.t
> create mode 100755 test/lua-Harness-tests/411-luajit.t.disabled
> create mode 100644 test/lua-Harness-tests/CMakeLists.txt
> create mode 100644 test/lua-Harness-tests/lexico52/lexico.t
> create mode 100644 test/lua-Harness-tests/lexico53/boolean.t
> create mode 100644 test/lua-Harness-tests/lexico53/function.t
> create mode 100644 test/lua-Harness-tests/lexico53/lexico.t
> create mode 100644 test/lua-Harness-tests/lexico53/nil.t
> create mode 100644 test/lua-Harness-tests/lexico53/number.t
> create mode 100644 test/lua-Harness-tests/lexico53/string.t
> create mode 100644 test/lua-Harness-tests/lexico53/table.t
> create mode 100644 test/lua-Harness-tests/lexico53/thread.t
> create mode 100644 test/lua-Harness-tests/lexico53/userdata.t
> create mode 100644 test/lua-Harness-tests/lexico53/utf8.t
> create mode 100644 test/lua-Harness-tests/lexico54/lexico.t
> create mode 100644 test/lua-Harness-tests/lexico54/metatable.t
> create mode 100644 test/lua-Harness-tests/lexico54/utf8.t
> create mode 100644 test/lua-Harness-tests/lexicojit/basic.t
> create mode 100644 test/lua-Harness-tests/lexicojit/ext.t
> create mode 100644 test/lua-Harness-tests/lexicojit/lexico.t
> create mode 100644 test/lua-Harness-tests/profile.lua
> create mode 100644 test/lua-Harness-tests/profile_lua51.lua
> create mode 100644 test/lua-Harness-tests/profile_lua51_strict.lua
> create mode 100644 test/lua-Harness-tests/profile_lua52.lua
> create mode 100644 test/lua-Harness-tests/profile_lua52_strict.lua
> create mode 100644 test/lua-Harness-tests/profile_lua53.lua
> create mode 100644 test/lua-Harness-tests/profile_lua53_noconv.lua
> create mode 100644 test/lua-Harness-tests/profile_lua53_strict.lua
> create mode 100644 test/lua-Harness-tests/profile_lua54.lua
> create mode 100644 test/lua-Harness-tests/profile_lua54_noconv.lua
> create mode 100644 test/lua-Harness-tests/profile_lua54_strict.lua
> create mode 100644 test/lua-Harness-tests/profile_luajit20.lua
> create mode 100644 test/lua-Harness-tests/profile_luajit20_compat52.lua
> create mode 100644 test/lua-Harness-tests/profile_luajit21.lua
> create mode 100644 test/lua-Harness-tests/profile_luajit21_compat52.lua
> create mode 100644 test/lua-Harness-tests/profile_openresty.lua
> create mode 100644 test/lua-Harness-tests/profile_ravi.lua
> create mode 100644 test/lua-Harness-tests/profile_tiny_fork.lua
> create mode 100644 test/lua-Harness-tests/rx_captures
> create mode 100644 test/lua-Harness-tests/rx_charclass
> create mode 100644 test/lua-Harness-tests/rx_metachars
> create mode 100644 test/lua-Harness-tests/tap_harness.lua
>
> --
> 2.28.0
>
prev parent reply other threads:[~2021-03-13 18:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-12 5:27 Sergey Kaplun via Tarantool-patches
2021-03-12 5:27 ` [Tarantool-patches] [PATCH luajit 1/6] test: add " Sergey Kaplun via Tarantool-patches
2021-03-15 13:05 ` Igor Munkin via Tarantool-patches
2021-03-12 5:27 ` [Tarantool-patches] [PATCH luajit 2/6] test: adjust lua-Harness test suite for Tarantool Sergey Kaplun via Tarantool-patches
2021-03-13 18:41 ` Sergey Ostanevich via Tarantool-patches
2021-03-15 13:22 ` Igor Munkin via Tarantool-patches
2021-03-12 5:27 ` [Tarantool-patches] [PATCH luajit 3/6] test: disable 305-utf8 of lua-Harness suite Sergey Kaplun via Tarantool-patches
2021-03-13 18:45 ` Sergey Ostanevich via Tarantool-patches
2021-03-15 12:45 ` Igor Munkin via Tarantool-patches
2021-03-12 5:27 ` [Tarantool-patches] [PATCH luajit 4/6] test: disable 241-standalone " Sergey Kaplun via Tarantool-patches
2021-03-13 18:45 ` Sergey Ostanevich via Tarantool-patches
2021-03-15 12:47 ` Igor Munkin via Tarantool-patches
2021-03-12 5:27 ` [Tarantool-patches] [PATCH luajit 5/6] test: disable 411-luajit " Sergey Kaplun via Tarantool-patches
2021-03-13 18:46 ` Sergey Ostanevich via Tarantool-patches
2021-03-15 12:48 ` Igor Munkin via Tarantool-patches
2021-03-12 5:27 ` [Tarantool-patches] [PATCH luajit 6/6] test: skip test for getenv in 309-os.t Sergey Kaplun via Tarantool-patches
2021-03-13 18:50 ` Sergey Ostanevich via Tarantool-patches
2021-03-15 10:22 ` Igor Munkin via Tarantool-patches
2021-03-13 18:22 ` Sergey Ostanevich via Tarantool-patches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16E39C08-397B-4A38-953A-B9EB85CD9C8B@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=sergos@tarantool.org \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit 0/6] Adapt lua-Harness test suite' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox