Tarantool development patches archive
 help / color / mirror / Atom feed
From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Maxim Kokryashkin <m.kokryashkin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 4/4] test: TAP module name collisions
Date: Tue, 6 Jul 2021 23:30:05 +0300
Message-ID: <20210706203005.GE11494@tarantool.org> (raw)
In-Reply-To: <acdaf5b92870c7764ad5b11d835bde19eafcca87.1625484589.git.max.kokryashkin@gmail.com>

Max,

Thanks for the patch! I left several comments regarding the commit
message, please consider them in addition to the main comments in the
cover letter.

On 05.07.21, Maxim Kokryashkin wrote:
> From: Maxim Kokryashkin <m.kokryashkin@tarantool.org>
> 
> Part of tarantool/tarantool#5970
> ---
> The patch `fperrad/lua-Harness@8041c45` renames `tap` module to 
> `test_assertion` to avoid name collisions, hence, we can just 
> apply this patch.

Unfortunately, this is very redundant patch (particularly when Tarantool
profile is finally introduced for lua-Harness), but Francois decided to
rename his module anyway. Considering all comments for the first patch,
I propose the following rewording:

| In scope of this patch[1] from lua-Harness assertion module tap.lua is
| renamed to test_assertion.lua to avoid name collision with Tarantool
| tap builtin module.
|
| [1]: https://framagit.org/fperrad/lua-Harness/-/commit/8041c45
|
| Part of tarantool/tarantool#5970
| Part of tarantool/tarantool#4473

If you are OK with the part above, feel free to paste it as is into the
commit message for the next version of the patch.

> 
>  test/lua-Harness-tests/090-tap.t                       | 2 +-
>  test/lua-Harness-tests/091-profile.t                   | 2 +-
>  test/lua-Harness-tests/101-boolean.t                   | 2 +-
>  test/lua-Harness-tests/102-function.t                  | 2 +-
>  test/lua-Harness-tests/103-nil.t                       | 2 +-
>  test/lua-Harness-tests/104-number.t                    | 2 +-
>  test/lua-Harness-tests/105-string.t                    | 2 +-
>  test/lua-Harness-tests/106-table.t                     | 2 +-
>  test/lua-Harness-tests/107-thread.t                    | 2 +-
>  test/lua-Harness-tests/108-userdata.t                  | 2 +-
>  test/lua-Harness-tests/200-examples.t                  | 2 +-
>  test/lua-Harness-tests/201-assign.t                    | 2 +-
>  test/lua-Harness-tests/202-expr.t                      | 2 +-
>  test/lua-Harness-tests/203-lexico.t                    | 2 +-
>  test/lua-Harness-tests/204-grammar.t                   | 2 +-
>  test/lua-Harness-tests/211-scope.t                     | 2 +-
>  test/lua-Harness-tests/212-function.t                  | 2 +-
>  test/lua-Harness-tests/213-closure.t                   | 2 +-
>  test/lua-Harness-tests/214-coroutine.t                 | 2 +-
>  test/lua-Harness-tests/221-table.t                     | 2 +-
>  test/lua-Harness-tests/222-constructor.t               | 2 +-
>  test/lua-Harness-tests/223-iterator.t                  | 2 +-
>  test/lua-Harness-tests/231-metatable.t                 | 2 +-
>  test/lua-Harness-tests/232-object.t                    | 2 +-
>  test/lua-Harness-tests/241-standalone.t.disabled       | 2 +-
>  test/lua-Harness-tests/242-luac.t                      | 2 +-
>  test/lua-Harness-tests/301-basic.t                     | 2 +-
>  test/lua-Harness-tests/303-package.t                   | 6 +++---
>  test/lua-Harness-tests/304-string.t                    | 2 +-
>  test/lua-Harness-tests/305-utf8.t                      | 2 +-
>  test/lua-Harness-tests/306-table.t                     | 2 +-
>  test/lua-Harness-tests/307-math.t                      | 2 +-
>  test/lua-Harness-tests/308-io.t                        | 2 +-
>  test/lua-Harness-tests/309-os.t                        | 2 +-
>  test/lua-Harness-tests/310-debug.t                     | 2 +-
>  test/lua-Harness-tests/311-bit32.t                     | 2 +-
>  test/lua-Harness-tests/314-regex.t                     | 2 +-
>  test/lua-Harness-tests/320-stdin.t                     | 2 +-
>  test/lua-Harness-tests/401-bitop.t                     | 2 +-
>  test/lua-Harness-tests/402-ffi.t                       | 2 +-
>  test/lua-Harness-tests/403-jit.t                       | 2 +-
>  test/lua-Harness-tests/404-ext.t                       | 2 +-
>  test/lua-Harness-tests/411-luajit.t.disabled           | 2 +-
>  test/lua-Harness-tests/{tap.lua => test_assertion.lua} | 0
>  44 files changed, 45 insertions(+), 45 deletions(-)
>  rename test/lua-Harness-tests/{tap.lua => test_assertion.lua} (100%)

The changes are quite trivial, so no comments regarding them.

> 

<snipped>

> -- 
> 2.31.1
> 

-- 
Best regards,
IM

  reply	other threads:[~2021-07-06 20:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-05 11:49 [Tarantool-patches] [PATCH 0/4] test: bump lua-Harness suite Maxim Kokryashkin via Tarantool-patches
2021-07-05 11:49 ` [Tarantool-patches] [PATCH 1/4] test: resolving program name Maxim Kokryashkin via Tarantool-patches
2021-07-06 20:29   ` Igor Munkin via Tarantool-patches
2021-07-05 11:49 ` [Tarantool-patches] [PATCH 2/4] test: out-of-source testing Maxim Kokryashkin via Tarantool-patches
2021-07-06 20:29   ` Igor Munkin via Tarantool-patches
2021-07-05 11:49 ` [Tarantool-patches] [PATCH 3/4] test: CI-environment Maxim Kokryashkin via Tarantool-patches
2021-07-06 20:29   ` Igor Munkin via Tarantool-patches
2021-07-05 11:49 ` [Tarantool-patches] [PATCH 4/4] test: TAP module name collisions Maxim Kokryashkin via Tarantool-patches
2021-07-06 20:30   ` Igor Munkin via Tarantool-patches [this message]
2021-07-06 20:29 ` [Tarantool-patches] [PATCH 0/4] test: bump lua-Harness suite Igor Munkin via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210706203005.GE11494@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=imun@tarantool.org \
    --cc=m.kokryashkin@tarantool.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Tarantool development patches archive

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://lists.tarantool.org/tarantool-patches/0 tarantool-patches/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 tarantool-patches tarantool-patches/ https://lists.tarantool.org/tarantool-patches \
		tarantool-patches@dev.tarantool.org.
	public-inbox-index tarantool-patches

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git