From: Maxim Kokryashkin via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: tarantool-patches@dev.tarantool.org, imun@tarantool.org, skaplun@tarantool.org Subject: [Tarantool-patches] [PATCH 3/4] test: CI-environment Date: Mon, 5 Jul 2021 14:49:44 +0300 [thread overview] Message-ID: <cb64b6d8bf8ba526c7f36968600b01d08cea5b3e.1625484589.git.max.kokryashkin@gmail.com> (raw) In-Reply-To: <cover.1625484589.git.max.kokryashkin@gmail.com> From: Maxim Kokryashkin <m.kokryashkin@tarantool.org> Part of tarantool/tarantool#5970 --- The patch `fperrad/lua-Harness@6c2aa87` makes 309-os.t check `os.getenv()` function by examining HOME environment variable instead of USER, so we don't need to set USERNAME explicitly anymore, as it stated in POSIX standard that every user must have HOME varibale set. Therefore, `tarantool/luajit@45ed138` should be replaced with `fperrad/lua-Harness@6c2aa87`. test/lua-Harness-tests/309-os.t | 4 ++-- test/lua-Harness-tests/CMakeLists.txt | 5 ----- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/test/lua-Harness-tests/309-os.t b/test/lua-Harness-tests/309-os.t index 8258e8af..a55d272a 100755 --- a/test/lua-Harness-tests/309-os.t +++ b/test/lua-Harness-tests/309-os.t @@ -169,8 +169,8 @@ end do -- getenv is(os.getenv('__IMPROBABLE__'), nil, "function getenv") - local user = os.getenv('LOGNAME') or os.getenv('USERNAME') - type_ok(user, 'string', "function getenv") + local home = os.getenv('HOME') or os.getenv('HOMEPATH') + type_ok(home, 'string', "function getenv") end do -- remove diff --git a/test/lua-Harness-tests/CMakeLists.txt b/test/lua-Harness-tests/CMakeLists.txt index 9fddd625..b9804033 100644 --- a/test/lua-Harness-tests/CMakeLists.txt +++ b/test/lua-Harness-tests/CMakeLists.txt @@ -26,11 +26,6 @@ add_custom_command(TARGET lua-Harness-tests COMMAND env LUA_PATH="${LUA_PATH}\;" - # XXX: 309-os.t checks os.getenv() function by examining - # USERNAME or LOGNAME environment variable. - # These variables might not be set in the environment, so - # set one of them explicitly. - USERNAME="fperrad" ${PROVE} ${CMAKE_CURRENT_SOURCE_DIR} --exec '${LUAJIT_TEST_COMMAND} -l profile_luajit21' ${LUA_TEST_FLAGS} -- 2.31.1
next prev parent reply other threads:[~2021-07-05 12:13 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-05 11:49 [Tarantool-patches] [PATCH 0/4] test: bump lua-Harness suite Maxim Kokryashkin via Tarantool-patches 2021-07-05 11:49 ` [Tarantool-patches] [PATCH 1/4] test: resolving program name Maxim Kokryashkin via Tarantool-patches 2021-07-06 20:29 ` Igor Munkin via Tarantool-patches 2021-07-05 11:49 ` [Tarantool-patches] [PATCH 2/4] test: out-of-source testing Maxim Kokryashkin via Tarantool-patches 2021-07-06 20:29 ` Igor Munkin via Tarantool-patches 2021-07-05 11:49 ` Maxim Kokryashkin via Tarantool-patches [this message] 2021-07-06 20:29 ` [Tarantool-patches] [PATCH 3/4] test: CI-environment Igor Munkin via Tarantool-patches 2021-07-05 11:49 ` [Tarantool-patches] [PATCH 4/4] test: TAP module name collisions Maxim Kokryashkin via Tarantool-patches 2021-07-06 20:30 ` Igor Munkin via Tarantool-patches 2021-07-06 20:29 ` [Tarantool-patches] [PATCH 0/4] test: bump lua-Harness suite Igor Munkin via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cb64b6d8bf8ba526c7f36968600b01d08cea5b3e.1625484589.git.max.kokryashkin@gmail.com \ --to=tarantool-patches@dev.tarantool.org \ --cc=imun@tarantool.org \ --cc=max.kokryashkin@gmail.com \ --cc=skaplun@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH 3/4] test: CI-environment' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox