Tarantool development patches archive
 help / color / mirror / Atom feed
From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Maxim Kokryashkin <m.kokryashkin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 3/4] test: CI-environment
Date: Tue, 6 Jul 2021 23:29:47 +0300	[thread overview]
Message-ID: <20210706202947.GD11494@tarantool.org> (raw)
In-Reply-To: <cb64b6d8bf8ba526c7f36968600b01d08cea5b3e.1625484589.git.max.kokryashkin@gmail.com>


Thanks for the patch! I left several comments regarding the commit
message, please consider them in addition to the main comments in the
cover letter.

On 05.07.21, Maxim Kokryashkin wrote:
> From: Maxim Kokryashkin <m.kokryashkin@tarantool.org>
> Part of tarantool/tarantool#5970
> ---
> The patch `fperrad/lua-Harness@6c2aa87` makes 309-os.t check 
> `os.getenv()` function by examining HOME environment variable 
> instead of USER, so we don't need to set USERNAME explicitly anymore, 
> as it stated in POSIX standard that every user must have HOME 
> varibale set. Therefore, `tarantool/luajit@45ed138` should be 
> replaced with `fperrad/lua-Harness@6c2aa87`.

Considering all comments for the first patch, I propose the following

| In scope of the commit 45ed138dcb9228d8ac5b8d82331ddd20a0bfada1
| ('test: set USERNAME env var for lua-Harness suite') the environment
| of the testing process is tweaked via CMake, since both LOGNAME and
| USERNAME environment variables might be missing.
| Actually, POSIX standard states that every user must have HOME
| environment variable set. It allows to use this in the corresponding
| assertion instead of LOGNAME and USERNAME without additional
| environment setup.
| As a result this patch[1] from lua-Harness suite supersedes the
| mentioned commit, and CMake hack can be dropped.
| [1]: https://framagit.org/fperrad/lua-Harness/-/commit/6c2aa87
| Part of tarantool/tarantool#5970
| Part of tarantool/tarantool#4473

If you are OK with the part above, feel free to paste it as is into the
commit message for the next version of the patch.

>  test/lua-Harness-tests/309-os.t       | 4 ++--
>  test/lua-Harness-tests/CMakeLists.txt | 5 -----
>  2 files changed, 2 insertions(+), 7 deletions(-)

The fix itself is fine and clear, so no comments regarding it.



> -- 
> 2.31.1

Best regards,

  reply	other threads:[~2021-07-06 20:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-05 11:49 [Tarantool-patches] [PATCH 0/4] test: bump lua-Harness suite Maxim Kokryashkin via Tarantool-patches
2021-07-05 11:49 ` [Tarantool-patches] [PATCH 1/4] test: resolving program name Maxim Kokryashkin via Tarantool-patches
2021-07-06 20:29   ` Igor Munkin via Tarantool-patches
2021-07-05 11:49 ` [Tarantool-patches] [PATCH 2/4] test: out-of-source testing Maxim Kokryashkin via Tarantool-patches
2021-07-06 20:29   ` Igor Munkin via Tarantool-patches
2021-07-05 11:49 ` [Tarantool-patches] [PATCH 3/4] test: CI-environment Maxim Kokryashkin via Tarantool-patches
2021-07-06 20:29   ` Igor Munkin via Tarantool-patches [this message]
2021-07-05 11:49 ` [Tarantool-patches] [PATCH 4/4] test: TAP module name collisions Maxim Kokryashkin via Tarantool-patches
2021-07-06 20:30   ` Igor Munkin via Tarantool-patches
2021-07-06 20:29 ` [Tarantool-patches] [PATCH 0/4] test: bump lua-Harness suite Igor Munkin via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210706202947.GD11494@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=imun@tarantool.org \
    --cc=m.kokryashkin@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH 3/4] test: CI-environment' \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox