From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 1DBE36EC42; Tue, 6 Jul 2021 23:54:11 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1DBE36EC42 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1625604851; bh=+tk3ZB1iOCBV8S3zK8aiIspfT0TPW+ouyS5lNg0CX3I=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=HnG+jiC7lfMq9j8bBqPryBq70Tm+9C7Q4b/ipHtJKvGh/J4Jrow76AqbFJXLKsjyh AlXapi1MSoaO0MIMwRiPoU7MARlCXBqybUoRgVDHjaj/mawgTcvJw1xMmnkFH4q7jP WY74/PlSjCbFrG3KZLjkeL+YoJ/UCkEA5WtC0sl4= Received: from smtpng2.i.mail.ru (smtpng2.i.mail.ru [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 4B4696EC44 for ; Tue, 6 Jul 2021 23:53:19 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 4B4696EC44 Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1m0s4E-0005IZ-DL; Tue, 06 Jul 2021 23:53:18 +0300 Date: Tue, 6 Jul 2021 23:29:47 +0300 To: Maxim Kokryashkin Message-ID: <20210706202947.GD11494@tarantool.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD954DFF1DC42D673FBE6C6848F3EB6EB89AE0756428E32ECE9182A05F5380850406BC9E4B1B65DC023D8792281880E2948CF69866910FDAC462127898F9A7376BF X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE79145AB6E9E75F07EEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006378D70459436292EC88638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8C55887C17DB95DAB0A62DA584274BBF1117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC2EE5AD8F952D28FBA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18E5D25F19253116ADD2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B682BBBAF5DF00056E089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A5FEA11F65F195761DA6F0AD536EAC21FA6363EB335DA4FB4ED59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75342909995EBBA6E4410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34181D1E89D5A0B42FFB9DF17668627197C78B2651EBDCE512366CCD66992B83C6EF1F70D20B50BDAD1D7E09C32AA3244C00E23EA9EAD9D6F947932A680B71B41D24AF4FAF06DA24FD927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojwWhFrYo6Pn2n0abCgrxURg== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5DA8F788E1D5B1AE2F2953C5AE5D192837A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 3/4] test: CI-environment X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Max, Thanks for the patch! I left several comments regarding the commit message, please consider them in addition to the main comments in the cover letter. On 05.07.21, Maxim Kokryashkin wrote: > From: Maxim Kokryashkin > > Part of tarantool/tarantool#5970 > --- > The patch `fperrad/lua-Harness@6c2aa87` makes 309-os.t check > `os.getenv()` function by examining HOME environment variable > instead of USER, so we don't need to set USERNAME explicitly anymore, > as it stated in POSIX standard that every user must have HOME > varibale set. Therefore, `tarantool/luajit@45ed138` should be > replaced with `fperrad/lua-Harness@6c2aa87`. Considering all comments for the first patch, I propose the following rewording: | In scope of the commit 45ed138dcb9228d8ac5b8d82331ddd20a0bfada1 | ('test: set USERNAME env var for lua-Harness suite') the environment | of the testing process is tweaked via CMake, since both LOGNAME and | USERNAME environment variables might be missing. | | Actually, POSIX standard states that every user must have HOME | environment variable set. It allows to use this in the corresponding | assertion instead of LOGNAME and USERNAME without additional | environment setup. | | As a result this patch[1] from lua-Harness suite supersedes the | mentioned commit, and CMake hack can be dropped. | | [1]: https://framagit.org/fperrad/lua-Harness/-/commit/6c2aa87 | | Part of tarantool/tarantool#5970 | Part of tarantool/tarantool#4473 If you are OK with the part above, feel free to paste it as is into the commit message for the next version of the patch. > > test/lua-Harness-tests/309-os.t | 4 ++-- > test/lua-Harness-tests/CMakeLists.txt | 5 ----- > 2 files changed, 2 insertions(+), 7 deletions(-) The fix itself is fine and clear, so no comments regarding it. > > -- > 2.31.1 > -- Best regards, IM