From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 08F3C6EC40; Tue, 6 Jul 2021 23:54:41 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 08F3C6EC40 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1625604881; bh=NuBjMvby3LL2edrTa1RxOta1ZqzfUsdolwG5eaiHi+8=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=m7DTEd/wtUm3ukLaW+7CzHaEWWZkfSIFFXCeY+k5JnZXfVDHph3URtedfh//PK4+5 3FIrf1ydpF9cgK9j0SBrdEV4YeBJuaRZbGhlHRfrlPi1y5olDeKJHD7Tt4CRrenO1e c8hLcOuD6Ok/wtpvrS8Tp2wrJY+X2ckQRIAlGncY= Received: from smtpng2.i.mail.ru (smtpng2.i.mail.ru [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 7DBE86EC40 for ; Tue, 6 Jul 2021 23:53:37 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 7DBE86EC40 Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1m0s4W-0005OX-Fv; Tue, 06 Jul 2021 23:53:36 +0300 Date: Tue, 6 Jul 2021 23:30:05 +0300 To: Maxim Kokryashkin Message-ID: <20210706203005.GE11494@tarantool.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD954DFF1DC42D673FB96E19CC2B9345E2B1F8975EC27617E56182A05F53808504000DC544FC1EDC71541B7A74E3C1AAE56D62095B8E3083DDCA4069CD831AE2873 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7B9D6DADD6B53929DEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637F10563012BA5CCB0EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38BBCA57AF85F7723F225F2570839F7F51ECC67C88E780D4E8ECC7F00164DA146DAFE8445B8C89999728AA50765F7900637F924B32C592EA89F389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC81D471462564A2E19F6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8B9EB32FE0C26A3A4C75ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A57BDFA53508B27C1FEBA967382CB2229A12FE46690AA9B8FED59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75342909995EBBA6E4410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D342E8FEDBD32DECB6DB8ED765C5F09DDA4037948EA4DC04315982053FD09A540ED465C34E4C12215DD1D7E09C32AA3244C09A2948E4B9E5DBED38F6F759FED2D1C60759606DA2E136A927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojwWhFrYo6Pn2Ol9M4uzAiLg== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5D2C9C89D1276A6196000AD72EF8F3E7F5A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 4/4] test: TAP module name collisions X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Max, Thanks for the patch! I left several comments regarding the commit message, please consider them in addition to the main comments in the cover letter. On 05.07.21, Maxim Kokryashkin wrote: > From: Maxim Kokryashkin > > Part of tarantool/tarantool#5970 > --- > The patch `fperrad/lua-Harness@8041c45` renames `tap` module to > `test_assertion` to avoid name collisions, hence, we can just > apply this patch. Unfortunately, this is very redundant patch (particularly when Tarantool profile is finally introduced for lua-Harness), but Francois decided to rename his module anyway. Considering all comments for the first patch, I propose the following rewording: | In scope of this patch[1] from lua-Harness assertion module tap.lua is | renamed to test_assertion.lua to avoid name collision with Tarantool | tap builtin module. | | [1]: https://framagit.org/fperrad/lua-Harness/-/commit/8041c45 | | Part of tarantool/tarantool#5970 | Part of tarantool/tarantool#4473 If you are OK with the part above, feel free to paste it as is into the commit message for the next version of the patch. > > test/lua-Harness-tests/090-tap.t | 2 +- > test/lua-Harness-tests/091-profile.t | 2 +- > test/lua-Harness-tests/101-boolean.t | 2 +- > test/lua-Harness-tests/102-function.t | 2 +- > test/lua-Harness-tests/103-nil.t | 2 +- > test/lua-Harness-tests/104-number.t | 2 +- > test/lua-Harness-tests/105-string.t | 2 +- > test/lua-Harness-tests/106-table.t | 2 +- > test/lua-Harness-tests/107-thread.t | 2 +- > test/lua-Harness-tests/108-userdata.t | 2 +- > test/lua-Harness-tests/200-examples.t | 2 +- > test/lua-Harness-tests/201-assign.t | 2 +- > test/lua-Harness-tests/202-expr.t | 2 +- > test/lua-Harness-tests/203-lexico.t | 2 +- > test/lua-Harness-tests/204-grammar.t | 2 +- > test/lua-Harness-tests/211-scope.t | 2 +- > test/lua-Harness-tests/212-function.t | 2 +- > test/lua-Harness-tests/213-closure.t | 2 +- > test/lua-Harness-tests/214-coroutine.t | 2 +- > test/lua-Harness-tests/221-table.t | 2 +- > test/lua-Harness-tests/222-constructor.t | 2 +- > test/lua-Harness-tests/223-iterator.t | 2 +- > test/lua-Harness-tests/231-metatable.t | 2 +- > test/lua-Harness-tests/232-object.t | 2 +- > test/lua-Harness-tests/241-standalone.t.disabled | 2 +- > test/lua-Harness-tests/242-luac.t | 2 +- > test/lua-Harness-tests/301-basic.t | 2 +- > test/lua-Harness-tests/303-package.t | 6 +++--- > test/lua-Harness-tests/304-string.t | 2 +- > test/lua-Harness-tests/305-utf8.t | 2 +- > test/lua-Harness-tests/306-table.t | 2 +- > test/lua-Harness-tests/307-math.t | 2 +- > test/lua-Harness-tests/308-io.t | 2 +- > test/lua-Harness-tests/309-os.t | 2 +- > test/lua-Harness-tests/310-debug.t | 2 +- > test/lua-Harness-tests/311-bit32.t | 2 +- > test/lua-Harness-tests/314-regex.t | 2 +- > test/lua-Harness-tests/320-stdin.t | 2 +- > test/lua-Harness-tests/401-bitop.t | 2 +- > test/lua-Harness-tests/402-ffi.t | 2 +- > test/lua-Harness-tests/403-jit.t | 2 +- > test/lua-Harness-tests/404-ext.t | 2 +- > test/lua-Harness-tests/411-luajit.t.disabled | 2 +- > test/lua-Harness-tests/{tap.lua => test_assertion.lua} | 0 > 44 files changed, 45 insertions(+), 45 deletions(-) > rename test/lua-Harness-tests/{tap.lua => test_assertion.lua} (100%) The changes are quite trivial, so no comments regarding them. > > -- > 2.31.1 > -- Best regards, IM