Re: [Tarantool-patches] [PATCH 3/3] ci: enable LuaJIT tests in CI

[Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Timur,

On 20.02.21, Timur Safin wrote:
> : From: Tarantool-patches <tarantool-patches-bounces@dev.tarantool.org> On
> : Subject: Re: [Tarantool-patches] [PATCH 3/3] ci: enable LuaJIT tests in CI
> : 
> : Sergey,
> : 
> : Thanks for your review!
> : > Nit: There is one general comment for the whole patch:
> : > In my opinion, it is better to run `make LuaJIT-tests` **before**
> : > Tarantool test suite. If LuaJIT is broken failed Tarantool tests
> : > information is useless (Is it LuaJIT? Always has been.).
> : > Feel free to ignore.
> : 
> : I assume the following: there is no flaky tests in LuaJIT (at least now)
> : but there are many in Tarantool. If we place LuaJIT-related tests before
> : Tarantool tests, then we need to rerun the former if the latter fail.
> : But when Tarantool tests fully succeed (even with no test-run internal
> : issues), LuaJIT tests are unlikely to fail. This makes sense when LuaJIT
> : tests will grow in a nearest future.
> : 
> : Ignoring for now but let's return to the question if it is necessary.
> : 
> 
> Here I'd rather agree with Sergey, that LuaJIT tests are prerequisite for
> all lua testing in Tarantool.

Then OK. I reordered the commands, squashed, force-pushed to the branch.

> 
> Timur
> 

-- 
Best regards,
IM