From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Sergey Kaplun <skaplun@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH 3/3] ci: enable LuaJIT tests in CI Date: Sat, 20 Feb 2021 00:29:10 +0300 [thread overview] Message-ID: <20210219212910.GR5448@tarantool.org> (raw) In-Reply-To: <20210215162916.GJ9361@root> Sergey, Thanks for your review! On 15.02.21, Sergey Kaplun wrote: > Hi, Igor! > > Thanks for the patch! > > LGTM, except a few nits below. Added your tag: | Reviewed-by: Sergey Kaplun <skaplun@tarantool.org> > > On 04.02.21, Igor Munkin wrote: > > This patch adds LuaJIT tests to every CI job type except the one for > > static build testing routine on OSX: there is no way to run LuaJIT tests > > for out of source build on OSX due to SIP[1]. > > > > [1]: https://developer.apple.com/library/archive/documentation/Security/Conceptual/System_Integrity_Protection_Guide/FileSystemProtections/FileSystemProtections.html > > > > Follows up #4862 > > Nit: looks like 'Closes' not 'Follows up'. > Feel free to ignore. No, the issue is closed via the previous commit. There is not a word about CI in the issue, so this commit simply follows up the closing one. Ignoring. > > > > > Signed-off-by: Igor Munkin <imun@tarantool.org> > > --- > > .travis.mk | 20 ++++++++++++++++++++ > > 1 file changed, 20 insertions(+) > > Nit: There is one general comment for the whole patch: > In my opinion, it is better to run `make LuaJIT-tests` **before** > Tarantool test suite. If LuaJIT is broken failed Tarantool tests > information is useless (Is it LuaJIT? Always has been.). > Feel free to ignore. I assume the following: there is no flaky tests in LuaJIT (at least now) but there are many in Tarantool. If we place LuaJIT-related tests before Tarantool tests, then we need to rerun the former if the latter fail. But when Tarantool tests fully succeed (even with no test-run internal issues), LuaJIT tests are unlikely to fail. This makes sense when LuaJIT tests will grow in a nearest future. Ignoring for now but let's return to the question if it is necessary. > <snipped> > > -- > Best regards, > Sergey Kaplun -- Best regards, IM
next prev parent reply other threads:[~2021-02-19 21:29 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-03 23:22 [Tarantool-patches] [PATCH 0/3] Adjust LuaJIT build system Igor Munkin via Tarantool-patches 2021-02-03 23:22 ` [Tarantool-patches] [PATCH 1/3] build: fix lua.c file generation Igor Munkin via Tarantool-patches 2021-02-15 13:12 ` Sergey Kaplun via Tarantool-patches 2021-02-19 21:17 ` Igor Munkin via Tarantool-patches 2021-02-03 23:22 ` [Tarantool-patches] [PATCH 2/3] build: adjust LuaJIT build system Igor Munkin via Tarantool-patches 2021-02-15 16:13 ` Sergey Kaplun via Tarantool-patches 2021-02-19 23:10 ` Igor Munkin via Tarantool-patches 2021-02-20 7:42 ` Timur Safin via Tarantool-patches 2021-02-03 23:22 ` [Tarantool-patches] [PATCH 3/3] ci: enable LuaJIT tests in CI Igor Munkin via Tarantool-patches 2021-02-15 16:29 ` Sergey Kaplun via Tarantool-patches 2021-02-19 21:29 ` Igor Munkin via Tarantool-patches [this message] [not found] ` <0b6601d7075c$64329060$2c97b120$@tarantool.org> 2021-02-20 10:18 ` Igor Munkin via Tarantool-patches 2021-02-24 7:16 ` Timur Safin via Tarantool-patches 2021-02-25 22:08 ` Igor Munkin via Tarantool-patches 2021-02-26 19:04 ` Timur Safin via Tarantool-patches 2021-02-26 19:09 ` [Tarantool-patches] [PATCH 0/3] Adjust LuaJIT build system Timur Safin via Tarantool-patches 2021-02-26 21:06 ` Igor Munkin via Tarantool-patches 2021-02-27 13:56 ` Sergey Kaplun via Tarantool-patches 2021-02-28 22:05 ` Igor Munkin via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210219212910.GR5448@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=imun@tarantool.org \ --cc=skaplun@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH 3/3] ci: enable LuaJIT tests in CI' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox