From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id E89086EC58; Sat, 20 Feb 2021 00:29:16 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E89086EC58 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1613770157; bh=ueCfqnQgXq1pjfUJDtepu0h48UC3A7AJVY2MTriHvy8=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=pPLGZeSzbopOqstnYMRCGIHYAf9lcnZKYrI88tebrk19v3q7OE4IFF0QbiqS+WTjL JQtW/JuzQZoAGNquk+H5MgTTtjMVSeEZd9Y6oR3jtYCL+uQRESV5p08vEBNwgDzKck fNgm2rxXgddHWkUNHaHbV6JW9OHYLqF9jtHsV3Bk= Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 3ED276EC58 for ; Sat, 20 Feb 2021 00:29:14 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 3ED276EC58 Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1lDDKr-0001s1-8j; Sat, 20 Feb 2021 00:29:13 +0300 Date: Sat, 20 Feb 2021 00:29:10 +0300 To: Sergey Kaplun Message-ID: <20210219212910.GR5448@tarantool.org> References: <2ac28542e4eac2031e5c30b279aabd3bcacbd7a1.1612390822.git.imun@tarantool.org> <20210215162916.GJ9361@root> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210215162916.GJ9361@root> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD975C3EC174F5669229511437AA01F46811CFCF616A939B362182A05F538085040A6710B871F07B06E35E2E3B2C71385540289C65EBB7C2913292175D633988D52 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7AEA4A6B3AFC9B957C2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6778DA827A17800CE7F2393C4755A27B53EA1F7E6F0F101C674E70A05D1297E1BBC6CDE5D1141D2B1C7C068B9E8F3CC59F5EA26E8FA397F5D9529BA7B811F1FF4A9FA2833FD35BB23D9E625A9149C048EE1E561CDFBCA1751FF6B57BC7E64490618DEB871D839B7333395957E7521B51C2DFABB839C843B9C08941B15DA834481F8AA50765F7900637028599BB38096F4F389733CBF5DBD5E9B5C8C57E37DE458BD96E472CDF7238E04AD6D5ED66289B5278DA827A17800CE70BB89B22BF4660DC67F23339F89546C5A8DF7F3B2552694A6FED454B719173D6725E5C173C3A84C3C8F21CEC4765490D35872C767BF85DA2F004C906525384306FED454B719173D6462275124DF8B9C9DE2850DD75B2526BE5BFE6E7EFDEDCD789D4C264860C145E X-C1DE0DAB: 0D63561A33F958A57B1364EFC750351437AEADCEF628D8E3E00CDE81A8773CDED59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75448CF9D3A7B2C848410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34728AF701C68E4539579CB506DFAEF85A00891DFAF9974AC03D0519F3262C025C7F68BA6EFA6496C01D7E09C32AA3244CDE7A2FAB76674B718940E5EA19C540171E098CBE561D6343927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojPfquRGj7313aPZWWLHCziA== X-Mailru-Sender: 689FA8AB762F73936BC43F508A0638225A225934C5F1731D5672741CF82BFB04A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 3/3] ci: enable LuaJIT tests in CI X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, Thanks for your review! On 15.02.21, Sergey Kaplun wrote: > Hi, Igor! > > Thanks for the patch! > > LGTM, except a few nits below. Added your tag: | Reviewed-by: Sergey Kaplun > > On 04.02.21, Igor Munkin wrote: > > This patch adds LuaJIT tests to every CI job type except the one for > > static build testing routine on OSX: there is no way to run LuaJIT tests > > for out of source build on OSX due to SIP[1]. > > > > [1]: https://developer.apple.com/library/archive/documentation/Security/Conceptual/System_Integrity_Protection_Guide/FileSystemProtections/FileSystemProtections.html > > > > Follows up #4862 > > Nit: looks like 'Closes' not 'Follows up'. > Feel free to ignore. No, the issue is closed via the previous commit. There is not a word about CI in the issue, so this commit simply follows up the closing one. Ignoring. > > > > > Signed-off-by: Igor Munkin > > --- > > .travis.mk | 20 ++++++++++++++++++++ > > 1 file changed, 20 insertions(+) > > Nit: There is one general comment for the whole patch: > In my opinion, it is better to run `make LuaJIT-tests` **before** > Tarantool test suite. If LuaJIT is broken failed Tarantool tests > information is useless (Is it LuaJIT? Always has been.). > Feel free to ignore. I assume the following: there is no flaky tests in LuaJIT (at least now) but there are many in Tarantool. If we place LuaJIT-related tests before Tarantool tests, then we need to rerun the former if the latter fail. But when Tarantool tests fully succeed (even with no test-run internal issues), LuaJIT tests are unlikely to fail. This makes sense when LuaJIT tests will grow in a nearest future. Ignoring for now but let's return to the question if it is necessary. > > > -- > Best regards, > Sergey Kaplun -- Best regards, IM