From: Timur Safin via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: "'Igor Munkin'" <imun@tarantool.org>, "'Sergey Kaplun'" <skaplun@tarantool.org> Cc: <tarantool-patches@dev.tarantool.org> Subject: Re: [Tarantool-patches] [PATCH 0/3] Adjust LuaJIT build system Date: Fri, 26 Feb 2021 22:09:11 +0300 [thread overview] Message-ID: <115401d70c72$ddb83140$992893c0$@tarantool.org> (raw) In-Reply-To: <cover.1612390822.git.imun@tarantool.org> Without newer versions of patchsets it's hard to mark properly the exact patch you actually approve, so putting this the simpler way - I ack it from the patchset cover letter LGTM whole patchset! Regards, Timur : From: Igor Munkin <imun@tarantool.org> : Subject: [PATCH 0/3] Adjust LuaJIT build system : : The first patch of this series fixes the inaccuracy for out of source : build type. If Lua source path given to <lua_source> function is : relative, the output file is generated in the binary directory. At the : same time if the given path to be compiled to *.lua.c is absolute, the : output file is generated in source directory instead of the binary one. : : In scope of the second patch the module for building the bundled LuaJIT : is completely reworked considering the changes made in LuaJIT repo[1]. : : The last patch adds LuaJIT tests to every CI job type except the one for : static build testing routine on OSX: there is no way to run LuaJIT tests : for out of source build on OSX due to SIP[2]. : : [1]: https://lists.tarantool.org/tarantool- : patches/cover.1612291495.git.imun@tarantool.org/T/#t : [2]: : https://developer.apple.com/library/archive/documentation/Security/Conceptua : l/System_Integrity_Protection_Guide/FileSystemProtections/FileSystemProtecti : ons.html : : Branch: https://github.com/tarantool/tarantool/tree/imun/gh-4862-cmake-full- : ci : Issues: : * https://github.com/tarantool/tarantool/issues/4862 : * https://github.com/tarantool/tarantool/issues/5470 : : CI is not green since OSX 11 is pretty stormy today. Hope it will be : fine the day when the changeset is merged into the trunk. : : @ChangeLog: : * Port LuaJIT build system to CMake and make its testing environment : self-sufficient (gh-4862, gh-5470). : : Igor Munkin (3): : build: fix lua.c file generation : build: adjust LuaJIT build system : ci: enable LuaJIT tests in CI : : .luacheckrc | 1 - : .travis.mk | 20 +++ : CMakeLists.txt | 2 +- : cmake/luajit.cmake | 375 ++++++++++++-------------------------------- : cmake/luatest.cpp | 80 ---------- : cmake/utils.cmake | 6 +- : debian/control | 2 + : rpm/tarantool.spec | 2 + : src/CMakeLists.txt | 28 ++-- : test/CMakeLists.txt | 18 +-- : third_party/luajit | 2 +- : 11 files changed, 143 insertions(+), 393 deletions(-) : delete mode 100644 cmake/luatest.cpp : : -- : 2.25.0
next prev parent reply other threads:[~2021-02-26 19:09 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-03 23:22 Igor Munkin via Tarantool-patches 2021-02-03 23:22 ` [Tarantool-patches] [PATCH 1/3] build: fix lua.c file generation Igor Munkin via Tarantool-patches 2021-02-15 13:12 ` Sergey Kaplun via Tarantool-patches 2021-02-19 21:17 ` Igor Munkin via Tarantool-patches 2021-02-03 23:22 ` [Tarantool-patches] [PATCH 2/3] build: adjust LuaJIT build system Igor Munkin via Tarantool-patches 2021-02-15 16:13 ` Sergey Kaplun via Tarantool-patches 2021-02-19 23:10 ` Igor Munkin via Tarantool-patches 2021-02-20 7:42 ` Timur Safin via Tarantool-patches 2021-02-03 23:22 ` [Tarantool-patches] [PATCH 3/3] ci: enable LuaJIT tests in CI Igor Munkin via Tarantool-patches 2021-02-15 16:29 ` Sergey Kaplun via Tarantool-patches 2021-02-19 21:29 ` Igor Munkin via Tarantool-patches [not found] ` <0b6601d7075c$64329060$2c97b120$@tarantool.org> 2021-02-20 10:18 ` Igor Munkin via Tarantool-patches 2021-02-24 7:16 ` Timur Safin via Tarantool-patches 2021-02-25 22:08 ` Igor Munkin via Tarantool-patches 2021-02-26 19:04 ` Timur Safin via Tarantool-patches 2021-02-26 19:09 ` Timur Safin via Tarantool-patches [this message] 2021-02-26 21:06 ` [Tarantool-patches] [PATCH 0/3] Adjust LuaJIT build system Igor Munkin via Tarantool-patches 2021-02-27 13:56 ` Sergey Kaplun via Tarantool-patches 2021-02-28 22:05 ` Igor Munkin via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='115401d70c72$ddb83140$992893c0$@tarantool.org' \ --to=tarantool-patches@dev.tarantool.org \ --cc=imun@tarantool.org \ --cc=skaplun@tarantool.org \ --cc=tsafin@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH 0/3] Adjust LuaJIT build system' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox