From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 998E56EC58; Sat, 20 Feb 2021 13:18:43 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 998E56EC58 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1613816323; bh=IyGSXDiungKX2QncbO+m5YK6quJ4Sbh9HCYCvfveqfw=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=B1mUG+YS2aqTrc5W72NQv7ApOIy/TZtIzw1TQT5VW83EjsuCblyOHcqdtpsMtgMwG skfY95IQTgKnVD9N1jY/DAXiHycQjkcWcwrl723AzJuTSRnmOnbi/aqWS0wYYHT6US wSrSeb1j0Lwc75n1ESqJ9Df9rcB4nyiVg7no07dU= Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A53F16EC58 for ; Sat, 20 Feb 2021 13:18:42 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A53F16EC58 Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1lDPLV-0004Fc-Ow; Sat, 20 Feb 2021 13:18:42 +0300 Date: Sat, 20 Feb 2021 13:18:38 +0300 To: Timur Safin Message-ID: <20210220101838.GA9042@tarantool.org> References: <2ac28542e4eac2031e5c30b279aabd3bcacbd7a1.1612390822.git.imun@tarantool.org> <20210215162916.GJ9361@root> <20210219212910.GR5448@tarantool.org> <0b6601d7075c$64329060$2c97b120$@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <0b6601d7075c$64329060$2c97b120$@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD975C3EC174F56692254B0AABE1FB071B2BA6557555153D6A0182A05F5380850408C331EDC3D3BF1C9EE8C0004A25036F2F65EDEA6CC2925058ADA6C5BA860F655 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7C6068CE86C2B75F5EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637560334CFC131571A8638F802B75D45FF5571747095F342E8C7A0BC55FA0FE5FCBE462577C01A1BBA1D06070A3355901059D5B57DC0EB5105389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C0D9442B0B5983000E8941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B636DA1BED736F9328CC7F00164DA146DA6F5DAA56C3B73B23C77107234E2CFBA567F23339F89546C55F5C1EE8F4F765FC851EDB9C5A93305EA7F4EDE966BC389F395957E7521B51C24C7702A67D5C33162DBA43225CD8A89F890A246B268E114E6D8C47C27EEC5E9FB5C8C57E37DE458B4C7702A67D5C3316FA3894348FB808DB48C21F01D89DB561574AF45C6390F7469DAA53EE0834AAEE X-C1DE0DAB: 0D63561A33F958A57C66918567C9EC2DFD149F03D1ED4A44C8D5305065812804D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75448CF9D3A7B2C848410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34A150564C13026C18916B87E7DFFF8999C5F9A2DF70E0F3AA5A26640423EF791050FC5327985B07F31D7E09C32AA3244CFD15E44267ABFAF5D1C4630A9D22D9BEE8FBBEFAE1C4874C927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj2CfMKaWP9xuBHPD/crEtGA== X-Mailru-Sender: 689FA8AB762F73936BC43F508A0638228AAB0964C66F1E945EA75208EAB69728A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 3/3] ci: enable LuaJIT tests in CI X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Timur, On 20.02.21, Timur Safin wrote: > : From: Tarantool-patches On > : Subject: Re: [Tarantool-patches] [PATCH 3/3] ci: enable LuaJIT tests in CI > : > : Sergey, > : > : Thanks for your review! > : > Nit: There is one general comment for the whole patch: > : > In my opinion, it is better to run `make LuaJIT-tests` **before** > : > Tarantool test suite. If LuaJIT is broken failed Tarantool tests > : > information is useless (Is it LuaJIT? Always has been.). > : > Feel free to ignore. > : > : I assume the following: there is no flaky tests in LuaJIT (at least now) > : but there are many in Tarantool. If we place LuaJIT-related tests before > : Tarantool tests, then we need to rerun the former if the latter fail. > : But when Tarantool tests fully succeed (even with no test-run internal > : issues), LuaJIT tests are unlikely to fail. This makes sense when LuaJIT > : tests will grow in a nearest future. > : > : Ignoring for now but let's return to the question if it is necessary. > : > > Here I'd rather agree with Sergey, that LuaJIT tests are prerequisite for > all lua testing in Tarantool. Then OK. I reordered the commands, squashed, force-pushed to the branch. > > Timur > -- Best regards, IM