Re: [Tarantool-patches] [PATCH v7 1/2] test: fix luacheck warnings in test/replication

[Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Thanks for review!

On 28.01.2021 01:24, Vladislav Shpilevoy wrote:
> Hi! Thanks for the patch!
>
>> diff --git a/test/replication/replica_quorum.lua b/test/replication/replica_quorum.lua
>> index 8dfad8b6e..80886e1c4 100644
>> --- a/test/replication/replica_quorum.lua
>> +++ b/test/replication/replica_quorum.lua
>> @@ -5,9 +5,9 @@ local SOCKET_DIR = require('fio').cwd()
>>   local QUORUM = tonumber(arg[1])
>>   local TIMEOUT = arg[2] and tonumber(arg[2]) or 0.1
>>   local CONNECT_TIMEOUT = arg[3] and tonumber(arg[3]) or 10
>> -INSTANCE_URI = SOCKET_DIR .. '/replica_quorum.sock'
>> +INSTANCE_URI = SOCKET_DIR .. '/replica_quorum.sock' -- luacheck: ignore
>>   
>> -function nonexistent_uri(id)
>> +function nonexistent_uri(id) -- luacheck: ignore
>>       return SOCKET_DIR .. '/replica_quorum' .. (1000 + id) .. '.sock'
>>   end
> I reverted this file entirely, and the check passed.

Reverted changes and force-pushed as we already have suppressions for 
INSTANCE_URI and nonexistent_uri in .luacheckrc.

--- a/test/replication/replica_quorum.lua
+++ b/test/replication/replica_quorum.lua
@@ -5,9 +5,9 @@ local SOCKET_DIR = require('fio').cwd()
  local QUORUM = tonumber(arg[1])
  local TIMEOUT = arg[2] and tonumber(arg[2]) or 0.1
  local CONNECT_TIMEOUT = arg[3] and tonumber(arg[3]) or 10
-INSTANCE_URI = SOCKET_DIR .. '/replica_quorum.sock' -- luacheck: ignore
+INSTANCE_URI = SOCKET_DIR .. '/replica_quorum.sock'

-function nonexistent_uri(id) -- luacheck: ignore
+function nonexistent_uri(id)
      return SOCKET_DIR .. '/replica_quorum' .. (1000 + id) .. '.sock'
  end