From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 735A96EC5C; Fri, 29 Jan 2021 17:49:24 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 735A96EC5C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1611931764; bh=dSZsHW4LzwdSYk833Tape5QnDDT7qb7OpcF6PydYDHU=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=L1vmBgOCWol00QlIROhps0CcAgtFobG5D/ZyOucID+W1tHpSA6H0OaUOgffU6dPPt kNnX/RqoDWofl1dh7Qc86sfVK1emC5k1wGobuGJuOOkNWf5FKooWpxXbTsZqzRDnR+ OygRzrmlJNxKdlD1s06A/W+HJ4t9LrNYd8+CIeTM= Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 3BAB66EC5C for ; Fri, 29 Jan 2021 17:49:23 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 3BAB66EC5C Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1l5V5O-00072L-DL; Fri, 29 Jan 2021 17:49:22 +0300 To: Vladislav Shpilevoy , tarantool-patches@dev.tarantool.org References: Message-ID: <053f6107-0044-a904-710d-cf62d82a0353@tarantool.org> Date: Fri, 29 Jan 2021 17:49:22 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD953AC099BC0052A9CD238BCF93DF23716D1711D0DDC4F5AC2182A05F53808504061A6D3BEF4B30F86ACD67B3FBEEC9660CDB9B47EEBC2BCA1056A605E2599C4B7 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE757AEC41D7AA04458EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637826327602763C04B8638F802B75D45FF5571747095F342E8C7A0BC55FA0FE5FCC9502DD27318FC346FD119C6C2F87B9395537E5290AE33F8389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C0D9442B0B5983000E8941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B64854413538E1713FCC7F00164DA146DA6F5DAA56C3B73B23C77107234E2CFBA567F23339F89546C55F5C1EE8F4F765FCA43F4593FF08F5ED75ECD9A6C639B01BBD4B6F7A4D31EC0BC0CAF46E325F83A522CA9DD8327EE493B89ED3C7A62817819EF166FBCB559E95C4224003CC836476C0CAF46E325F83A50BF2EBBBDD9D6B0F05F538519369F3743B503F486389A921A5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A5F16A8664D07EA8BC78EE13AC71C4B3016363EB335DA4FB4ED59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75F04B387B5D7535DE410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3480A9008907CB2FD0E81A9875AB878A5FCCE6085CBF28B40C409FB02310199FDB075FC062C5B8585F1D7E09C32AA3244CEAAE58A9C1A609624EE0F4CC9FFC7FB024AF4FAF06DA24FD729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj0axADxPFAF/uRN/LRf12Bw== X-Mailru-Sender: 689FA8AB762F73936BC43F508A06382222538AD9DE8BADAF7BAA2A07D48456BDDD788429FD8613638ED9BB8B05EE7B3AFB559BB5D741EB96D19CD4E7312BAA970A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v7 1/2] test: fix luacheck warnings in test/replication X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for review! On 28.01.2021 01:24, Vladislav Shpilevoy wrote: > Hi! Thanks for the patch! > >> diff --git a/test/replication/replica_quorum.lua b/test/replication/replica_quorum.lua >> index 8dfad8b6e..80886e1c4 100644 >> --- a/test/replication/replica_quorum.lua >> +++ b/test/replication/replica_quorum.lua >> @@ -5,9 +5,9 @@ local SOCKET_DIR = require('fio').cwd() >> local QUORUM = tonumber(arg[1]) >> local TIMEOUT = arg[2] and tonumber(arg[2]) or 0.1 >> local CONNECT_TIMEOUT = arg[3] and tonumber(arg[3]) or 10 >> -INSTANCE_URI = SOCKET_DIR .. '/replica_quorum.sock' >> +INSTANCE_URI = SOCKET_DIR .. '/replica_quorum.sock' -- luacheck: ignore >> >> -function nonexistent_uri(id) >> +function nonexistent_uri(id) -- luacheck: ignore >> return SOCKET_DIR .. '/replica_quorum' .. (1000 + id) .. '.sock' >> end > I reverted this file entirely, and the check passed. Reverted changes and force-pushed as we already have suppressions for INSTANCE_URI and nonexistent_uri in .luacheckrc. --- a/test/replication/replica_quorum.lua +++ b/test/replication/replica_quorum.lua @@ -5,9 +5,9 @@ local SOCKET_DIR = require('fio').cwd()  local QUORUM = tonumber(arg[1])  local TIMEOUT = arg[2] and tonumber(arg[2]) or 0.1  local CONNECT_TIMEOUT = arg[3] and tonumber(arg[3]) or 10 -INSTANCE_URI = SOCKET_DIR .. '/replica_quorum.sock' -- luacheck: ignore +INSTANCE_URI = SOCKET_DIR .. '/replica_quorum.sock' -function nonexistent_uri(id) -- luacheck: ignore +function nonexistent_uri(id)      return SOCKET_DIR .. '/replica_quorum' .. (1000 + id) .. '.sock'  end