Tarantool development patches archive
 help / color / mirror / Atom feed
From: Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>,
	tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v7 1/2] test: fix luacheck warnings in test/replication
Date: Sat, 30 Jan 2021 22:48:28 +0300	[thread overview]
Message-ID: <43fb5cd6-332c-b713-3c70-26728d442ba1@tarantool.org> (raw)
In-Reply-To: <626eea47-b7f8-2a5a-6934-24123b88660a@tarantool.org>

Thanks for review!

On 30.01.2021 22:01, Vladislav Shpilevoy wrote:
> Hi! Thanks for the fixes!
>
> Here is the diff --stat of the commit:
>
> ====================
> .luacheckrc                                 |   8 +++++++-
>   .luacheckrc_                                | 127 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>   test/replication/lua/fast_replica.lua       |  33 +++++++++++++++++----------------
>   test/replication/lua/rlimit.lua             |   2 +-
>   test/replication/master.lua                 |   2 +-
>   test/replication/master_quorum.lua          |   4 ++--
>   test/replication/on_replace.lua             |   6 +++---
>   test/replication/replica.lua                |   4 ++--
>   test/replication/replica_on_schema_init.lua |   4 ++--
>   9 files changed, 162 insertions(+), 28 deletions(-)
> ====================
>
> What is the second luacheck file?
Accidentally committed. Removed and force-pushed.

  reply	other threads:[~2021-01-30 19:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-21 14:47 [Tarantool-patches] [PATCH v7 0/2] Fix luacheck warnings in test/replication and test/replication-py Sergey Bronnikov via Tarantool-patches
2021-01-21 14:47 ` [Tarantool-patches] [PATCH v7 1/2] test: fix luacheck warnings in test/replication Sergey Bronnikov via Tarantool-patches
2021-01-27 22:24   ` Vladislav Shpilevoy via Tarantool-patches
2021-01-29 14:49     ` Sergey Bronnikov via Tarantool-patches
2021-01-30 19:01       ` Vladislav Shpilevoy via Tarantool-patches
2021-01-30 19:48         ` Sergey Bronnikov via Tarantool-patches [this message]
2021-01-21 14:47 ` [Tarantool-patches] [PATCH v7 2/2] test: fix luacheck warnings in test/replication-py Sergey Bronnikov via Tarantool-patches
2021-01-31 17:18 ` [Tarantool-patches] [PATCH v7 0/2] Fix luacheck warnings in test/replication and test/replication-py Vladislav Shpilevoy via Tarantool-patches
2021-02-01 12:24 ` Kirill Yukhin via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43fb5cd6-332c-b713-3c70-26728d442ba1@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=sergeyb@tarantool.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v7 1/2] test: fix luacheck warnings in test/replication' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox