Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: sergeyb@tarantool.org, tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v7 1/2] test: fix luacheck warnings in test/replication
Date: Wed, 27 Jan 2021 23:24:26 +0100	[thread overview]
Message-ID: <d5fdb4ab-d6ee-45b6-c803-ed9d88820b1b@tarantool.org> (raw)
In-Reply-To: <b994ccf7c484b7114eda1ef253ec9f069812e457.1611240117.git.sergeyb@tarantool.org>

Hi! Thanks for the patch!

> diff --git a/test/replication/replica_quorum.lua b/test/replication/replica_quorum.lua
> index 8dfad8b6e..80886e1c4 100644
> --- a/test/replication/replica_quorum.lua
> +++ b/test/replication/replica_quorum.lua
> @@ -5,9 +5,9 @@ local SOCKET_DIR = require('fio').cwd()
>  local QUORUM = tonumber(arg[1])
>  local TIMEOUT = arg[2] and tonumber(arg[2]) or 0.1
>  local CONNECT_TIMEOUT = arg[3] and tonumber(arg[3]) or 10
> -INSTANCE_URI = SOCKET_DIR .. '/replica_quorum.sock'
> +INSTANCE_URI = SOCKET_DIR .. '/replica_quorum.sock' -- luacheck: ignore
>  
> -function nonexistent_uri(id)
> +function nonexistent_uri(id) -- luacheck: ignore
>      return SOCKET_DIR .. '/replica_quorum' .. (1000 + id) .. '.sock'
>  end

I reverted this file entirely, and the check passed.

  reply	other threads:[~2021-01-27 22:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-21 14:47 [Tarantool-patches] [PATCH v7 0/2] Fix luacheck warnings in test/replication and test/replication-py Sergey Bronnikov via Tarantool-patches
2021-01-21 14:47 ` [Tarantool-patches] [PATCH v7 1/2] test: fix luacheck warnings in test/replication Sergey Bronnikov via Tarantool-patches
2021-01-27 22:24   ` Vladislav Shpilevoy via Tarantool-patches [this message]
2021-01-29 14:49     ` Sergey Bronnikov via Tarantool-patches
2021-01-30 19:01       ` Vladislav Shpilevoy via Tarantool-patches
2021-01-30 19:48         ` Sergey Bronnikov via Tarantool-patches
2021-01-21 14:47 ` [Tarantool-patches] [PATCH v7 2/2] test: fix luacheck warnings in test/replication-py Sergey Bronnikov via Tarantool-patches
2021-01-31 17:18 ` [Tarantool-patches] [PATCH v7 0/2] Fix luacheck warnings in test/replication and test/replication-py Vladislav Shpilevoy via Tarantool-patches
2021-02-01 12:24 ` Kirill Yukhin via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d5fdb4ab-d6ee-45b6-c803-ed9d88820b1b@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=sergeyb@tarantool.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v7 1/2] test: fix luacheck warnings in test/replication' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox