Tarantool development patches archive
 help / color / mirror / Atom feed
From: Timur Safin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: "'Igor Munkin'" <imun@tarantool.org>
Cc: <alexander.turenko@tarantool.org>, <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v2 1/3] test: corrected reported error lines
Date: Wed, 30 Jun 2021 09:49:32 +0300
Message-ID: <015801d76d7c$15754c20$405fe460$@tarantool.org> (raw)
In-Reply-To: <20210629162105.GD10212@tarantool.org>

: From: Igor Munkin <imun@tarantool.org>
: Subject: Re: [Tarantool-patches] [PATCH v2 1/3] test: corrected reported
: error lines
: 
: Timur,
: 
 
: > :
: > : Minor: Strictly saying :123 part is also broken.
: >
: > O_o, why? Could you please clarify? We report it as line number in the
: > source file, in this case tkt-9a8b09f8e6.test.lua:123 was exactly the
: > caller location?
: 
: Do you need the location of definition (:123) or location where the
: function execution is stopped at the moment (:142)? If I got your point,
: you prefer the latter, right?

FWIW, currentline is pointing _exactly_ to the line number in the file
Which was calling this error, not to the start of function definition. 
At least in our cases, when we not introduce any extra do scopes.

[Now I start to worry with the question when .linedefined is not 0
and whether we would need to sum .currentline and .linedefined to 
get actual source line in the file?]

: > if currentline may be missing in the traceback object for any reason.
: 
: It may not, considering the flags used for obtaining debug info.
: 
: > If it's impossible for the set of requested flags, then I'll get rid
: > of linedefined here.
: 
: Yes, <currentline> field is provided by 'l' flag[1]. Please, get rid of
: <linedefined> and the default 0 and drop a few sentences regarding this
: change in commit message.

Please see my worries about .linedefined above. Currently it's in main scope,
when it will be not main scope, do any extra do create separate scope? 
Could .currentline be .linedefined related or it's guaranteed to be 
Counted from start of file?

: 
: [1]: https://www.lua.org/manual/5.1/manual.html#lua_getinfo
: 
: --
: Best regards,
: IM


  reply	other threads:[~2021-06-30  6:49 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-11  7:48 [Tarantool-patches] [PATCH v2 0/3] sql: modify explicit and implicit conversion tables Timur Safin via Tarantool-patches
2021-06-11  7:48 ` [Tarantool-patches] [PATCH v2 1/3] test: corrected reported error lines Timur Safin via Tarantool-patches
2021-06-20 18:57   ` Igor Munkin via Tarantool-patches
2021-06-23 21:01     ` Alexander Turenko via Tarantool-patches
2021-06-27 23:16     ` Timur Safin via Tarantool-patches
2021-06-29 16:21       ` Igor Munkin via Tarantool-patches
2021-06-30  6:49         ` Timur Safin via Tarantool-patches [this message]
2021-07-21  7:24           ` Igor Munkin via Tarantool-patches
2021-06-11  7:48 ` [Tarantool-patches] [PATCH v2 2/3] sql: updated explicit conversion table Timur Safin via Tarantool-patches
2021-06-20 18:52   ` Mergen Imeev via Tarantool-patches
2021-06-25 21:26     ` Timur Safin via Tarantool-patches
2021-06-25 21:26     ` [Tarantool-patches] Отзыв: " Timur Safin via Tarantool-patches
2021-06-27 23:46       ` [Tarantool-patches] " Timur Safin via Tarantool-patches
2021-06-11  7:48 ` [Tarantool-patches] [PATCH v2 3/3] sql: updated implicit " Timur Safin via Tarantool-patches
2021-06-20 18:52   ` Mergen Imeev via Tarantool-patches
2021-06-28  0:06     ` Timur Safin via Tarantool-patches
2021-06-20 18:52 ` [Tarantool-patches] [PATCH v2 0/3] sql: modify explicit and implicit conversion tables Mergen Imeev via Tarantool-patches
2021-06-27 23:29   ` Timur Safin via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='015801d76d7c$15754c20$405fe460$@tarantool.org' \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=alexander.turenko@tarantool.org \
    --cc=imun@tarantool.org \
    --cc=tsafin@tarantool.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Tarantool development patches archive

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://lists.tarantool.org/tarantool-patches/0 tarantool-patches/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 tarantool-patches tarantool-patches/ https://lists.tarantool.org/tarantool-patches \
		tarantool-patches@dev.tarantool.org.
	public-inbox-index tarantool-patches

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git