From: Alexander Turenko via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Timur Safin <tsafin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2 1/3] test: corrected reported error lines
Date: Thu, 24 Jun 2021 00:01:42 +0300 [thread overview]
Message-ID: <20210623210142.om7ofpoksdhshsnf@tkn_work_nb> (raw)
In-Reply-To: <20210620185759.GC10212@tarantool.org>
Good catch!
All comments from Igor look meaningful for me. After fixes according to
those comments -- no objections from me.
> <..> Please adjust the commit subject according to
> our contribution guidelines[1].
I would highlight that the 'test' prefix is used for pure testing
changes, but here we touch the built-in module. I would use 'lua' here.
WBR, Alexander Turenko.
next prev parent reply other threads:[~2021-06-23 21:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-11 7:48 [Tarantool-patches] [PATCH v2 0/3] sql: modify explicit and implicit conversion tables Timur Safin via Tarantool-patches
2021-06-11 7:48 ` [Tarantool-patches] [PATCH v2 1/3] test: corrected reported error lines Timur Safin via Tarantool-patches
2021-06-20 18:57 ` Igor Munkin via Tarantool-patches
2021-06-23 21:01 ` Alexander Turenko via Tarantool-patches [this message]
2021-06-27 23:16 ` Timur Safin via Tarantool-patches
2021-06-29 16:21 ` Igor Munkin via Tarantool-patches
2021-06-30 6:49 ` Timur Safin via Tarantool-patches
2021-07-21 7:24 ` Igor Munkin via Tarantool-patches
2021-06-11 7:48 ` [Tarantool-patches] [PATCH v2 2/3] sql: updated explicit conversion table Timur Safin via Tarantool-patches
2021-06-20 18:52 ` Mergen Imeev via Tarantool-patches
2021-06-25 21:26 ` Timur Safin via Tarantool-patches
2021-06-25 21:26 ` [Tarantool-patches] Отзыв: " Timur Safin via Tarantool-patches
2021-06-27 23:46 ` [Tarantool-patches] " Timur Safin via Tarantool-patches
2021-06-11 7:48 ` [Tarantool-patches] [PATCH v2 3/3] sql: updated implicit " Timur Safin via Tarantool-patches
2021-06-20 18:52 ` Mergen Imeev via Tarantool-patches
2021-06-28 0:06 ` Timur Safin via Tarantool-patches
2021-06-20 18:52 ` [Tarantool-patches] [PATCH v2 0/3] sql: modify explicit and implicit conversion tables Mergen Imeev via Tarantool-patches
2021-06-27 23:29 ` Timur Safin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210623210142.om7ofpoksdhshsnf@tkn_work_nb \
--to=tarantool-patches@dev.tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=tsafin@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 1/3] test: corrected reported error lines' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox