From: Timur Safin via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: alexander.turenko@tarantool.org Cc: tarantool-patches@dev.tarantool.org Subject: [Tarantool-patches] [PATCH v2 1/3] test: corrected reported error lines Date: Fri, 11 Jun 2021 10:48:11 +0300 [thread overview] Message-ID: <d3639649921666f45b4110630ad4515b253b3675.1623396615.git.tsafin@tarantool.org> (raw) In-Reply-To: <cover.1623396615.git.tsafin@tarantool.org> It always was a problem that reported source line was not pointing to the actual callee line number, but rather to the start of file, i.e. we have seen: ``` [001] sql-tap/tkt-9a8b09f8e6.test.lua memtx [001] not ok 22 - 4.3 # [001] Traceback: [001] [Lua ] function 'do_catchsql_test' at </home/tsafin/tarantool/test/var/001_sql-tap/sqltester.lua:123> [001] [main] at </home/tsafin/tarantool/test/sql-tap/tkt-9a8b09f8e6.test.lua:0> [001] [001] not ok 23 - 4.4 # [001] Traceback: [001] [Lua ] function 'do_catchsql_test' at </home/tsafin/tarantool/test/var/001_sql-tap/sqltester.lua:123> [001] [main] at </home/tsafin/tarantool/test/sql-tap/tkt-9a8b09f8e6.test.lua:0> ``` (see the :0 part) Instead of correct line numbers: ``` [001] sql-tap/tkt-9a8b09f8e6.test.lua memtx [001] not ok 22 - 4.3 # [001] Traceback: [001] [Lua ] function 'do_catchsql_test' at </home/tsafin/tarantool/test/var/001_sql-tap/sqltester.lua:142> [001] [main] at </home/tsafin/tarantool/test/sql-tap/tkt-9a8b09f8e6.test.lua:242> [001] [001] not ok 23 - 4.4 # [001] Traceback: [001] [Lua ] function 'do_catchsql_test' at </home/tsafin/tarantool/test/var/001_sql-tap/sqltester.lua:142> [001] [main] at </home/tsafin/tarantool/test/sql-tap/tkt-9a8b09f8e6.test.lua:252> ``` The problem was due to `.linedefined` used, instead of source line in `.currentline`. Closes #6134 --- src/lua/tap.lua | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lua/tap.lua b/src/lua/tap.lua index 346724d84..77fd8d096 100644 --- a/src/lua/tap.lua +++ b/src/lua/tap.lua @@ -23,7 +23,7 @@ local function traceback(level) local frame = { source = info.source; src = info.short_src; - line = info.linedefined or 0; + line = info.currentline or info.linedefined or 0; what = info.what; name = info.name; namewhat = info.namewhat; -- 2.29.2
next prev parent reply other threads:[~2021-06-11 7:49 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-11 7:48 [Tarantool-patches] [PATCH v2 0/3] sql: modify explicit and implicit conversion tables Timur Safin via Tarantool-patches 2021-06-11 7:48 ` Timur Safin via Tarantool-patches [this message] 2021-06-20 18:57 ` [Tarantool-patches] [PATCH v2 1/3] test: corrected reported error lines Igor Munkin via Tarantool-patches 2021-06-23 21:01 ` Alexander Turenko via Tarantool-patches 2021-06-27 23:16 ` Timur Safin via Tarantool-patches 2021-06-29 16:21 ` Igor Munkin via Tarantool-patches 2021-06-30 6:49 ` Timur Safin via Tarantool-patches 2021-07-21 7:24 ` Igor Munkin via Tarantool-patches 2021-06-11 7:48 ` [Tarantool-patches] [PATCH v2 2/3] sql: updated explicit conversion table Timur Safin via Tarantool-patches 2021-06-20 18:52 ` Mergen Imeev via Tarantool-patches 2021-06-25 21:26 ` Timur Safin via Tarantool-patches 2021-06-25 21:26 ` [Tarantool-patches] Отзыв: " Timur Safin via Tarantool-patches 2021-06-27 23:46 ` [Tarantool-patches] " Timur Safin via Tarantool-patches 2021-06-11 7:48 ` [Tarantool-patches] [PATCH v2 3/3] sql: updated implicit " Timur Safin via Tarantool-patches 2021-06-20 18:52 ` Mergen Imeev via Tarantool-patches 2021-06-28 0:06 ` Timur Safin via Tarantool-patches 2021-06-20 18:52 ` [Tarantool-patches] [PATCH v2 0/3] sql: modify explicit and implicit conversion tables Mergen Imeev via Tarantool-patches 2021-06-27 23:29 ` Timur Safin via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=d3639649921666f45b4110630ad4515b253b3675.1623396615.git.tsafin@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=alexander.turenko@tarantool.org \ --cc=tsafin@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v2 1/3] test: corrected reported error lines' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox