From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 45F276EC40; Wed, 30 Jun 2021 09:49:41 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 45F276EC40 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1625035781; bh=Z3vaWiwcaHrbmnxpcrThH69eN5JgU1oHHROoTByi93I=; h=To:Cc:References:In-Reply-To:Date:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=l9r6vpwOy7blVGgdyfSoXqezWKT8WSCuZB7ap2owV2i3aAzOYRKhstWGaDeNmyeRi oOM413UYVV8ARBbjAes+JBKZFkrRYxOJLbi4H+WSrPrgGxj0hQ0IEex5qpQQJ+nxj+ BBHWpFbW628fIPy2+eea3LuEICcq1m2Ci9tG8MXc= Received: from smtp56.i.mail.ru (smtp56.i.mail.ru [217.69.128.36]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 9BA826EC40 for ; Wed, 30 Jun 2021 09:49:40 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 9BA826EC40 Received: by smtp56.i.mail.ru with esmtpa (envelope-from ) id 1lyU2V-0003V8-JX; Wed, 30 Jun 2021 09:49:40 +0300 To: "'Igor Munkin'" Cc: , References: <20210620185759.GC10212@tarantool.org> <151601d76baa$6d360c70$47a22550$@tarantool.org> <20210629162105.GD10212@tarantool.org> In-Reply-To: <20210629162105.GD10212@tarantool.org> Date: Wed, 30 Jun 2021 09:49:32 +0300 Message-ID: <015801d76d7c$15754c20$405fe460$@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQH9YP+QCEY6e5VusJ0O6Ha7mUcGiQNUyBTjAg9NfjMBvoFAAwGGgGGMqprrniA= Content-Language: ru X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD954DFF1DC42D673FB8EEAA58EF109ED2DCA3B880632F394B8182A05F538085040B540BE338E33C30E3FE1E64F4EF505066F2D386E6884527059D63F258C6BA1BE X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7AED985C8E545F588EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006376602C647E39EFA3A8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8FED527F4E33636C8A4ACD42A6811711E117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAE9A1BBD95851C5BA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735201E561CDFBCA1751FF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947C3916E35B8AF55EAF302FCEF25BFAB3454AD6D5ED66289B52698AB9A7B718F8C46E0066C2D8992A16725E5C173C3A84C37C6E5A447658E3FFBA3038C0950A5D36B5C8C57E37DE458B0BC6067A898B09E46D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE7588D3C263EAE74EA731C566533BA786AA5CC5B56E945C8DA X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A24209795067102C07E8F7B195E1C97831B056C3D5FAC1319C11447ED96C72CD2D X-C1DE0DAB: 0D63561A33F958A54DF8DE497688C95F07D3457C6D40286D274809830B387DB4D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA752546FE575EB473F1410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D340DAE5B306C240CF5AA3DC3ACB4CD45E1554400785CDBA2DDE4DED0C506370624482ECC0BD127E9001D7E09C32AA3244CCBA4C78CC8B4A9FC1930B83E7002CB8530452B15D76AEC14FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojYs6lrUQryK6iIU60P6OpLg== X-Mailru-Sender: B5B6A6EBBD94DAD83D7E83A6E8C9D875D55B7D7D509ABD94C750962B3F2B7A017294268B687DDCF21EC9E4A2C82A33BC8C24925A86E657CE0C70AEE3C9A96FBAB3D7EE8ED63280BE112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 1/3] test: corrected reported error lines X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Timur Safin via Tarantool-patches Reply-To: Timur Safin Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" : From: Igor Munkin : Subject: Re: [Tarantool-patches] [PATCH v2 1/3] test: corrected reported : error lines : : Timur, : : > : : > : Minor: Strictly saying :123 part is also broken. : > : > O_o, why? Could you please clarify? We report it as line number in the : > source file, in this case tkt-9a8b09f8e6.test.lua:123 was exactly the : > caller location? : : Do you need the location of definition (:123) or location where the : function execution is stopped at the moment (:142)? If I got your point, : you prefer the latter, right? FWIW, currentline is pointing _exactly_ to the line number in the file Which was calling this error, not to the start of function definition. At least in our cases, when we not introduce any extra do scopes. [Now I start to worry with the question when .linedefined is not 0 and whether we would need to sum .currentline and .linedefined to get actual source line in the file?] : > if currentline may be missing in the traceback object for any reason. : : It may not, considering the flags used for obtaining debug info. : : > If it's impossible for the set of requested flags, then I'll get rid : > of linedefined here. : : Yes, field is provided by 'l' flag[1]. Please, get rid of : and the default 0 and drop a few sentences regarding this : change in commit message. Please see my worries about .linedefined above. Currently it's in main scope, when it will be not main scope, do any extra do create separate scope? Could .currentline be .linedefined related or it's guaranteed to be Counted from start of file? : : [1]: https://www.lua.org/manual/5.1/manual.html#lua_getinfo : : -- : Best regards, : IM