Tarantool development patches archive
 help / color / mirror / Atom feed
From: Maxim Kokryashkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Bronnikov <sergeyb@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org,
	Sergey Bronnikov <estetus@gmail.com>
Subject: Re: [Tarantool-patches] [PATCH luajit 2/2] OSX/iOS: Always generate 64 bit non-FAT Mach-O object files.
Date: Mon, 19 Aug 2024 12:45:55 +0300	[thread overview]
Message-ID: <kxjjpuv7otur5pfel7iqr5ydt4zrh45ay2lfr33b455o7xtfpo@oraiqjeoscys> (raw)
In-Reply-To: <dcb4bc6e-2183-419a-b007-7df80c5d37bd@tarantool.org>

Hi, Sergey!
Thanks for the patch!

As this thread replies grew way beyond comprehensible limit, I'll refer
to the GitHub commit instead.

> Sergey Bronnikov:
> * added the description and the trimmed the test for the problem
Typo: s/the trimmed/trimmed/

<lj-865-cross-generation-mach-o-file.test.lua>

Lines: 149-150:
> -- The function builds a Mach-O object file and retrieves its
> -- header fields.
I believe, "validates" fits better than "retrieves" here.

Line: 153:
> -- LuaJIT always generate 64-bit, non-FAT Mach-O object files.
Typo: s/generate/generates/

Otherwise, LGTM.

  reply	other threads:[~2024-08-19  9:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-05 13:10 [Tarantool-patches] [PATCH luajit 0/2] Fixes in Mach-O generation code Sergey Bronnikov via Tarantool-patches
2024-07-05 13:10 ` [Tarantool-patches] [PATCH luajit 1/2] Fix typo Sergey Bronnikov via Tarantool-patches
2024-07-09 12:15   ` Sergey Kaplun via Tarantool-patches
2024-07-11  9:15   ` Maxim Kokryashkin via Tarantool-patches
2024-07-05 13:10 ` [Tarantool-patches] [PATCH luajit 2/2] OSX/iOS: Always generate 64 bit non-FAT Mach-O object files Sergey Bronnikov via Tarantool-patches
2024-07-09 13:03   ` Sergey Kaplun via Tarantool-patches
2024-07-10 12:43     ` Sergey Bronnikov via Tarantool-patches
2024-07-11  7:29       ` Sergey Kaplun via Tarantool-patches
2024-07-23 20:07         ` Sergey Bronnikov via Tarantool-patches
2024-08-19  9:45           ` Maxim Kokryashkin via Tarantool-patches [this message]
2024-08-20  8:57             ` Sergey Bronnikov via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=kxjjpuv7otur5pfel7iqr5ydt4zrh45ay2lfr33b455o7xtfpo@oraiqjeoscys \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=estetus@gmail.com \
    --cc=m.kokryashkin@tarantool.org \
    --cc=sergeyb@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH luajit 2/2] OSX/iOS: Always generate 64 bit non-FAT Mach-O object files.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox