From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id D5E29C3FD23; Mon, 19 Aug 2024 12:45:59 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D5E29C3FD23 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1724060759; bh=COhQDHpkJJgdVCDPOUjsw9fWD6srPTrjeSdfeZQ0aRw=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=qIm3kb8gSqHnQrIVOFubQAFm73f2yIaiW6udL2av88SNBCc5vwz/1s8pB7LA/h8q3 lhAp4hG14yLInRSMM4eXlWvre0/7o3bzxy2jLTAM+k1/tO3Bn2Hhlvwh65dNS4SIAm i2gOAA1DQSebq8wxsQlxZpELO+VDDFa5Lh0usLSs= Received: from smtp47.i.mail.ru (smtp47.i.mail.ru [95.163.41.85]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 82D34C3FD23 for ; Mon, 19 Aug 2024 12:45:58 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 82D34C3FD23 Received: by smtp47.i.mail.ru with esmtpa (envelope-from ) id 1sfyxY-00000006NWV-395u; Mon, 19 Aug 2024 12:45:57 +0300 Date: Mon, 19 Aug 2024 12:45:55 +0300 To: Sergey Bronnikov Message-ID: References: <10ed208fcfacfa4c772f1cebe090595af3452ff3.1720182442.git.sergeyb@tarantool.org> <95ce34d1-234c-4e5c-a9a5-a62a5a5633e8@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9F97E3C14763C38E2F9BEF1302460B6E58325028F501E713F182A05F538085040D16474598178ACEC2EB5D77EF37489D171349DE0AFD89EA001C6428AB60C801911835EED5C149C5A X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7544B1CCE26E01C74EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637F63E14183F8C6AF98638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D892729D835285DFE180714BD584BFF36C33222208AD614332CC7F00164DA146DAFE8445B8C89999728AA50765F7900637F6B57BC7E64490618DEB871D839B7333395957E7521B51C2DFABB839C843B9C08941B15DA834481F8AA50765F7900637CAEE156C82D3D7D9389733CBF5DBD5E9B5C8C57E37DE458BD9DD9810294C998ED8FC6C240DEA76428AA50765F79006379E0ED5494A51127FD81D268191BDAD3DBD4B6F7A4D31EC0BE2F48590F00D11D6D81D268191BDAD3D78DA827A17800CE721F7820B0673994CEC76A7562686271ED91E3A1F190DE8FD2E808ACE2090B5E14AD6D5ED66289B5259CC434672EE63711DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C384C61F09AF66B0A435872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A55777FCFC1742C2635002B1117B3ED6967C36EB3C89F0AAD5C81EEE05487B0209823CB91A9FED034534781492E4B8EEAD9CFA8CFAC159CE19BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D3453741B480A6503C3B8045E7A9FE05C3326C2E36EB071DC5761C093158794583C840AF60CE544A2DB1D7E09C32AA3244C908EBF9C369EAE63A0CBE312C330D7D5012947EEE303991CEA455F16B58544A21C197AAF4D2E4732965026E5D17F6739C77C69D99B9914278E50E1F0597A6FD5CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojxd0rRjfnTmbT6aU1EcxOuA== X-Mailru-Sender: 7940E2A4EB16C9975BD3B8E5EDDE1B6ED6D664FE360D91E562C2911B6B55F59AF1433778DF336E1528C44B9C631FF20DE747D2BC1AD30F01FB559BB5D741EB9612EB40C6FA10D71EFD657A8799238ED55FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 2/2] OSX/iOS: Always generate 64 bit non-FAT Mach-O object files. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Maxim Kokryashkin via Tarantool-patches Reply-To: Maxim Kokryashkin Cc: tarantool-patches@dev.tarantool.org, Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the patch! As this thread replies grew way beyond comprehensible limit, I'll refer to the GitHub commit instead. > Sergey Bronnikov: > * added the description and the trimmed the test for the problem Typo: s/the trimmed/trimmed/ Lines: 149-150: > -- The function builds a Mach-O object file and retrieves its > -- header fields. I believe, "validates" fits better than "retrieves" here. Line: 153: > -- LuaJIT always generate 64-bit, non-FAT Mach-O object files. Typo: s/generate/generates/ Otherwise, LGTM.