From: Vladislav Shpilevoy via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Serge Petrenko <sergepetrenko@tarantool.org>,
tarantool-patches@dev.tarantool.org, olegrok@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 1/1] json: use cord_ibuf for encoding and decoding
Date: Mon, 24 May 2021 17:47:06 +0200 [thread overview]
Message-ID: <ff048551-7bf8-1e1c-bd00-49ce273c3fb9@tarantool.org> (raw)
In-Reply-To: <f6c48605-b989-4768-d0c5-636c4506d2cf@tarantool.org>
Hi! Thanks for the review!
>> @@ -171,9 +127,21 @@ void strbuf_resize(strbuf_t *s, int len)
>> fprintf(stderr, "strbuf(%lx) resize: %d => %d\n",
>> (long)s, s->size, newsize);
>> }
>> -
>> s->size = newsize;
>
> ^ Extraneous change
This was rather intentional, there are too many empty lines in this
function now. But I don't mind to leave it:
====================
@@ -127,6 +127,7 @@ void strbuf_resize(strbuf_t *s, int len)
fprintf(stderr, "strbuf(%lx) resize: %d => %d\n",
(long)s, s->size, newsize);
}
+
s->size = newsize;
struct ibuf *ibuf = s->ibuf;
next prev parent reply other threads:[~2021-05-24 15:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-23 14:06 Vladislav Shpilevoy via Tarantool-patches
2021-05-24 10:04 ` Oleg Babin via Tarantool-patches
2021-05-24 15:49 ` Vladislav Shpilevoy via Tarantool-patches
2021-05-24 16:00 ` Oleg Babin via Tarantool-patches
2021-05-24 13:01 ` Serge Petrenko via Tarantool-patches
2021-05-24 13:05 ` Serge Petrenko via Tarantool-patches
2021-05-24 15:47 ` Vladislav Shpilevoy via Tarantool-patches
2021-05-24 15:47 ` Vladislav Shpilevoy via Tarantool-patches [this message]
2021-05-24 16:17 ` Serge Petrenko via Tarantool-patches
2021-05-25 21:20 ` Vladislav Shpilevoy via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff048551-7bf8-1e1c-bd00-49ce273c3fb9@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=olegrok@tarantool.org \
--cc=sergepetrenko@tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 1/1] json: use cord_ibuf for encoding and decoding' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox