From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 6B7BE7030C; Mon, 24 May 2021 18:47:39 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 6B7BE7030C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1621871259; bh=Cp1ICEZ+e1IRbvMeb9aTcR9q961GqfPmnLBtcoemVpo=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=f9h1l9tJLN00eJ98lYkqvT2lVbmwmQCr6WA0dAB6tsJEFVd1s6MND0In1X+r2Zj1B 3HRL0DISvtLX35mKSAb5UFJx1kft9EDE6ZlZqLZ7X/QiqY8brGm1jYKOT3mtZUYTIR F/avomQO2kY3TrxZgQKNslI2hsYw6UIcot+iug4E= Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 0378B74141 for ; Mon, 24 May 2021 18:47:09 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 0378B74141 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1llCnL-0001Fu-Jq; Mon, 24 May 2021 18:47:07 +0300 To: Serge Petrenko , tarantool-patches@dev.tarantool.org, olegrok@tarantool.org References: <2fb4c066558879eea74acab2e20b8a1c8f85d86b.1621778740.git.v.shpilevoy@tarantool.org> Message-ID: Date: Mon, 24 May 2021 17:47:06 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD91B019B01C53E51AFCAACD197781D6F0CB42DE8FB7A42148700894C459B0CD1B956E2F493B9B5EAF432F1E0919B3428F48E2CFE174D4D9C6F8ED064EC5171B301 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7C2204D4F9A221771EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637822A0A225AD602F38638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8BBD0298903941082A940F1174B28F49F117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAA867293B0326636D2E47CDBA5A96583BD4B6F7A4D31EC0BC014FD901B82EE079FA2833FD35BB23D27C277FBC8AE2E8BAA867293B0326636D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6B1CFA6D474D4A6A4089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A56135B4BDF2560D4283C56E50D6717385DA0994974CAC7517D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA753C350047980234DB410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34987A0E8D235BB534790A114CF71DEE809E8AA43D5E95DCD1C304E36EE85CB07571049749FDC5D66A1D7E09C32AA3244C9B9C93574BE0FC6A72BE38B8D38F99BC435BF7150578642FFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj+gjVyQcIK6J7jU67fdy1cg== X-Mailru-Sender: 689FA8AB762F73936BC43F508A0638225630B3610FE34626068F6BD79E5F526C3841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 1/1] json: use cord_ibuf for encoding and decoding X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! Thanks for the review! >> @@ -171,9 +127,21 @@ void strbuf_resize(strbuf_t *s, int len) >>           fprintf(stderr, "strbuf(%lx) resize: %d => %d\n", >>                   (long)s, s->size, newsize); >>       } >> - >>       s->size = newsize; > >  ^ Extraneous change This was rather intentional, there are too many empty lines in this function now. But I don't mind to leave it: ==================== @@ -127,6 +127,7 @@ void strbuf_resize(strbuf_t *s, int len) fprintf(stderr, "strbuf(%lx) resize: %d => %d\n", (long)s, s->size, newsize); } + s->size = newsize; struct ibuf *ibuf = s->ibuf;