Re: [Tarantool-patches] [PATCH 1/1] json: use cord_ibuf for encoding and decoding

[Serge Petrenko via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

24.05.2021 18:47, Vladislav Shpilevoy пишет:
> Hi! Thanks for the review!
>
>>> @@ -171,9 +127,21 @@ void strbuf_resize(strbuf_t *s, int len)
>>>            fprintf(stderr, "strbuf(%lx) resize: %d => %d\n",
>>>                    (long)s, s->size, newsize);
>>>        }
>>> -
>>>        s->size = newsize;
>>   ^ Extraneous change
> This was rather intentional, there are too many empty lines in this
> function now. But I don't mind to leave it:
>
> ====================
> @@ -127,6 +127,7 @@ void strbuf_resize(strbuf_t *s, int len)
>           fprintf(stderr, "strbuf(%lx) resize: %d => %d\n",
>                   (long)s, s->size, newsize);
>       }
> +
>       s->size = newsize;
>   
>       struct ibuf *ibuf = s->ibuf;
Thanks for the fixes!

LGTM.

-- 
Serge Petrenko