From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id BF71B7030C; Mon, 24 May 2021 19:17:22 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org BF71B7030C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1621873042; bh=Pq1G5h5CQVD/zHtx0AgHI/WxuafyMpghvJIvXvCv01Y=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=lOd0cl5c7ibtUfqltgTQKs9jKszqvldA9y6CCmgwyTjHVMsMPme84rIa5ufa9MoKv 5sy59WHLs8ThMUFs8MssRtZw0HqsXCU9WF+ALEoZaq4U8LyKpgkc9kuFaS7XfyOy9y 6gid0sX4p/x6vAyYX4FvbB1R2B/cxL2pTLOhzV/0= Received: from smtp36.i.mail.ru (smtp36.i.mail.ru [94.100.177.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 9482F7030C for ; Mon, 24 May 2021 19:17:20 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 9482F7030C Received: by smtp36.i.mail.ru with esmtpa (envelope-from ) id 1llDGZ-0002FN-Te; Mon, 24 May 2021 19:17:20 +0300 To: Vladislav Shpilevoy , tarantool-patches@dev.tarantool.org, olegrok@tarantool.org References: <2fb4c066558879eea74acab2e20b8a1c8f85d86b.1621778740.git.v.shpilevoy@tarantool.org> Message-ID: Date: Mon, 24 May 2021 19:17:19 +0300 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: ru X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD91B019B01C53E51AF113D6D562FBA72891FA115C4A817A10000894C459B0CD1B984C57129924C37956C8BEC996FCC98F2887F9A42EDEAD7F45709D77201D190DA X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7C2204D4F9A221771EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637CAA352D56883AEE98638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D89D42EABCD1ADB25BAC0946BA71AB4759117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAA867293B0326636D2E47CDBA5A96583BD4B6F7A4D31EC0BC014FD901B82EE079FA2833FD35BB23D27C277FBC8AE2E8BAA867293B0326636D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE4B6963042765DA4B7C6FCE95544A9834D8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE3A7DFDF579AB090EF040F9FF01DFDA4A8C4224003CC836476EA7A3FFF5B025636E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F79006373BA04B6A498D0BA4731C566533BA786AA5CC5B56E945C8DA X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A24209795067102C07E8F7B195E1C9783116F3E9B2A9A7F81E49269A4754B3489E X-C1DE0DAB: 0D63561A33F958A53FDD57DA00915A2E582005B41D8F62E0B892E6D099431268D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA753C350047980234DB410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34C264B329661203DA2ADAD17492B311D2E2614459C1CE02A1F1A09B9DAB94EF606ACC866D9400B26F1D7E09C32AA3244CF5D609FC2FDD9D8E230763D104E665DCA995755A1445935EFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj+gjVyQcIK6JtR4hYDilzgQ== X-Mailru-Sender: 583F1D7ACE8F49BD95918038521BA2AAF591882BAAA6DE4F7B12B1CE04B42CEC976AF1CB91E6E881424AE0EB1F3D1D21E2978F233C3FAE6EE63DB1732555E4A8EE80603BA4A5B0BC112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 1/1] json: use cord_ibuf for encoding and decoding X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Serge Petrenko via Tarantool-patches Reply-To: Serge Petrenko Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" 24.05.2021 18:47, Vladislav Shpilevoy пишет: > Hi! Thanks for the review! > >>> @@ -171,9 +127,21 @@ void strbuf_resize(strbuf_t *s, int len) >>>           fprintf(stderr, "strbuf(%lx) resize: %d => %d\n", >>>                   (long)s, s->size, newsize); >>>       } >>> - >>>       s->size = newsize; >>  ^ Extraneous change > This was rather intentional, there are too many empty lines in this > function now. But I don't mind to leave it: > > ==================== > @@ -127,6 +127,7 @@ void strbuf_resize(strbuf_t *s, int len) > fprintf(stderr, "strbuf(%lx) resize: %d => %d\n", > (long)s, s->size, newsize); > } > + > s->size = newsize; > > struct ibuf *ibuf = s->ibuf; Thanks for the fixes! LGTM. -- Serge Petrenko