From: Vladislav Shpilevoy via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Oleg Babin <olegrok@tarantool.org>,
tarantool-patches@dev.tarantool.org,
yaroslav.dynnikov@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH vshard 4/6] config: introduce master 'auto' replicaset option
Date: Fri, 2 Jul 2021 23:32:32 +0200 [thread overview]
Message-ID: <fe4b22cc-7466-4443-f3be-6b6197e4df8a@tarantool.org> (raw)
In-Reply-To: <85b44610-ba58-75af-07ec-7ae4dc66d372@tarantool.org>
Hi! Thanks for the extensive review!
>> +local function check_replicaset_master(master, ctx)
>> + if not lutil.version_is_at_least(1, 10, 0) then
>> + error('Only versions >= 1.10 support master discovery')
>> + end
>
> If we talk about "is_async" netbox option. We should check 1.10.1:
>
> https://github.com/tarantool/tarantool/commit/0f686829a89b87d4f8d10fd25d4acfdea9b3dc60#diff-1e545a3af3d3592423eff523367e962e18f7eda45c2f9bef6994a254f6044d70
>
> There is a gap between 1.10.0 and 1.10.1 when there is no is_async.
Good call. It is easy to fix so I did it:
====================
@@ -22,8 +22,9 @@ local function check_replica_master(master, ctx)
end
local function check_replicaset_master(master, ctx)
- if not lutil.version_is_at_least(1, 10, 0) then
- error('Only versions >= 1.10 support master discovery')
+ -- Limit the version due to extensive usage of netbox is_async feature.
+ if not lutil.version_is_at_least(1, 10, 1) then
+ error('Only versions >= 1.10.1 support master discovery')
end
if master ~= 'auto' then
error('Only "auto" master is supported')
next prev parent reply other threads:[~2021-07-02 21:32 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-01 22:09 [Tarantool-patches] [PATCH vshard 0/6] Master discovery Vladislav Shpilevoy via Tarantool-patches
2021-07-01 22:09 ` [Tarantool-patches] [PATCH vshard 1/6] replicaset: introduce netbox_wait_connected() Vladislav Shpilevoy via Tarantool-patches
2021-07-02 11:46 ` Oleg Babin via Tarantool-patches
2021-07-01 22:09 ` [Tarantool-patches] [PATCH vshard 2/6] test: sort some table prints Vladislav Shpilevoy via Tarantool-patches
2021-07-02 11:46 ` Oleg Babin via Tarantool-patches
2021-07-01 22:09 ` [Tarantool-patches] [PATCH vshard 3/6] storage: introduce vshard.storage._call('info') Vladislav Shpilevoy via Tarantool-patches
2021-07-02 11:46 ` Oleg Babin via Tarantool-patches
2021-07-01 22:09 ` [Tarantool-patches] [PATCH vshard 4/6] config: introduce master 'auto' replicaset option Vladislav Shpilevoy via Tarantool-patches
2021-07-02 11:47 ` Oleg Babin via Tarantool-patches
2021-07-02 21:32 ` Vladislav Shpilevoy via Tarantool-patches [this message]
2021-07-05 9:23 ` Oleg Babin via Tarantool-patches
2021-07-01 22:09 ` [Tarantool-patches] [PATCH vshard 5/6] router: introduce automatic master discovery Vladislav Shpilevoy via Tarantool-patches
2021-07-02 11:48 ` Oleg Babin via Tarantool-patches
2021-07-02 21:35 ` Vladislav Shpilevoy via Tarantool-patches
2021-07-05 9:24 ` Oleg Babin via Tarantool-patches
2021-07-05 20:53 ` Vladislav Shpilevoy via Tarantool-patches
2021-07-06 8:54 ` Oleg Babin via Tarantool-patches
2021-07-06 21:19 ` Vladislav Shpilevoy via Tarantool-patches
2021-07-01 22:09 ` [Tarantool-patches] [PATCH vshard 6/6] router: update master using a hint from storage Vladislav Shpilevoy via Tarantool-patches
2021-07-02 11:49 ` Oleg Babin via Tarantool-patches
2021-07-02 21:36 ` Vladislav Shpilevoy via Tarantool-patches
2021-07-05 9:24 ` Oleg Babin via Tarantool-patches
2021-07-05 20:53 ` Vladislav Shpilevoy via Tarantool-patches
2021-07-06 8:55 ` Oleg Babin via Tarantool-patches
2021-07-02 21:36 ` [Tarantool-patches] [PATCH vshard 7/6] util: truncate too long fiber name Vladislav Shpilevoy via Tarantool-patches
2021-07-05 9:23 ` Oleg Babin via Tarantool-patches
2021-08-03 21:55 ` [Tarantool-patches] [PATCH vshard 0/6] Master discovery Vladislav Shpilevoy via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe4b22cc-7466-4443-f3be-6b6197e4df8a@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=olegrok@tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--cc=yaroslav.dynnikov@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH vshard 4/6] config: introduce master '\''auto'\'' replicaset option' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox