From: Oleg Babin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>,
tarantool-patches@dev.tarantool.org,
yaroslav.dynnikov@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH vshard 2/6] test: sort some table prints
Date: Fri, 2 Jul 2021 14:46:20 +0300 [thread overview]
Message-ID: <621f26ab-6654-892b-2d8b-201cc3b23226@tarantool.org> (raw)
In-Reply-To: <b9aff3688d26d84c62c69ed561ccb05fdf505b86.1625177221.git.v.shpilevoy@tarantool.org>
Thanks for your patch. LGTM.
On 02.07.2021 01:09, Vladislav Shpilevoy wrote:
> Router.test.lua and upgrade.test.lua printed some Lua tables which
> were not sorted. Next patches are going to alter them slightly and
> if the tables are not sorted, some old keys would change place and
> increase the diff.
>
> The patch makes these outputs sorted so any amendment won't touch
> the existing lines.
next prev parent reply other threads:[~2021-07-02 11:46 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-01 22:09 [Tarantool-patches] [PATCH vshard 0/6] Master discovery Vladislav Shpilevoy via Tarantool-patches
2021-07-01 22:09 ` [Tarantool-patches] [PATCH vshard 1/6] replicaset: introduce netbox_wait_connected() Vladislav Shpilevoy via Tarantool-patches
2021-07-02 11:46 ` Oleg Babin via Tarantool-patches
2021-07-01 22:09 ` [Tarantool-patches] [PATCH vshard 2/6] test: sort some table prints Vladislav Shpilevoy via Tarantool-patches
2021-07-02 11:46 ` Oleg Babin via Tarantool-patches [this message]
2021-07-01 22:09 ` [Tarantool-patches] [PATCH vshard 3/6] storage: introduce vshard.storage._call('info') Vladislav Shpilevoy via Tarantool-patches
2021-07-02 11:46 ` Oleg Babin via Tarantool-patches
2021-07-01 22:09 ` [Tarantool-patches] [PATCH vshard 4/6] config: introduce master 'auto' replicaset option Vladislav Shpilevoy via Tarantool-patches
2021-07-02 11:47 ` Oleg Babin via Tarantool-patches
2021-07-02 21:32 ` Vladislav Shpilevoy via Tarantool-patches
2021-07-05 9:23 ` Oleg Babin via Tarantool-patches
2021-07-01 22:09 ` [Tarantool-patches] [PATCH vshard 5/6] router: introduce automatic master discovery Vladislav Shpilevoy via Tarantool-patches
2021-07-02 11:48 ` Oleg Babin via Tarantool-patches
2021-07-02 21:35 ` Vladislav Shpilevoy via Tarantool-patches
2021-07-05 9:24 ` Oleg Babin via Tarantool-patches
2021-07-05 20:53 ` Vladislav Shpilevoy via Tarantool-patches
2021-07-06 8:54 ` Oleg Babin via Tarantool-patches
2021-07-06 21:19 ` Vladislav Shpilevoy via Tarantool-patches
2021-07-01 22:09 ` [Tarantool-patches] [PATCH vshard 6/6] router: update master using a hint from storage Vladislav Shpilevoy via Tarantool-patches
2021-07-02 11:49 ` Oleg Babin via Tarantool-patches
2021-07-02 21:36 ` Vladislav Shpilevoy via Tarantool-patches
2021-07-05 9:24 ` Oleg Babin via Tarantool-patches
2021-07-05 20:53 ` Vladislav Shpilevoy via Tarantool-patches
2021-07-06 8:55 ` Oleg Babin via Tarantool-patches
2021-07-02 21:36 ` [Tarantool-patches] [PATCH vshard 7/6] util: truncate too long fiber name Vladislav Shpilevoy via Tarantool-patches
2021-07-05 9:23 ` Oleg Babin via Tarantool-patches
2021-08-03 21:55 ` [Tarantool-patches] [PATCH vshard 0/6] Master discovery Vladislav Shpilevoy via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=621f26ab-6654-892b-2d8b-201cc3b23226@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=olegrok@tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--cc=yaroslav.dynnikov@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH vshard 2/6] test: sort some table prints' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox