From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 576F76EC40; Sat, 3 Jul 2021 00:32:36 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 576F76EC40 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1625261556; bh=DfzqVZRpJHq/qWPQmX2IBw1QKTJj1yJaCkG4YZpJECo=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=Tw15RrFZkT1hzoB8vn5ZSYxe9bcsoP2Rsw0BemEPCYasR2JhoTg2Q/InD3av5q9J7 VZZDVYYBSBlxgSHi4cLR48WSS9FZw5sANoYALAhAT/b2hmJCQ6dWNkDVoqLRKykKPW 7MJPKNaAv+eZMvvr8uzNgdZr/DPBh3tgDY1c/5sw= Received: from smtpng2.i.mail.ru (smtpng2.i.mail.ru [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A942D6EC40 for ; Sat, 3 Jul 2021 00:32:34 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A942D6EC40 Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1lzQm1-0003G1-P3; Sat, 03 Jul 2021 00:32:34 +0300 To: Oleg Babin , tarantool-patches@dev.tarantool.org, yaroslav.dynnikov@tarantool.org References: <888cee3d83fff78411e0cf96ee6b2e8292887677.1625177221.git.v.shpilevoy@tarantool.org> <85b44610-ba58-75af-07ec-7ae4dc66d372@tarantool.org> Message-ID: Date: Fri, 2 Jul 2021 23:32:32 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <85b44610-ba58-75af-07ec-7ae4dc66d372@tarantool.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD954DFF1DC42D673FB2F1AA0EB8A504C8721532AB396CDCF09182A05F538085040B2CD2E5EB13F75EB007FE6B1FCA4808AC057BF9B5CC07E3D1301CDA213D8365C X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE72F22E6DC541F75D9EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063757004B04402545C58638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8784E3958C56D8801438A659E269199A2117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCC908CD1B87A134A2A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352026055571C92BF10FCB629EEF1311BF91D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B60A62CEF541B197C8089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A5AC06C906FE1CCC758E9D6C0C4C43B41757231DC2263D7E3ED59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA753753CEE10E4ED4A7410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D340A58BF0C7EAC340F49F694C0C71B6519DD7475FFC446B5BD61B165311C3B514F87533B974F1137651D7E09C32AA3244CC5369C6780E3ED67471F2FBAC159D4956C24832127668422FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj/yEXjM+E11AcHQ5p1Ccz3Q== X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822D286465753E61BA1D9CB4702C03CF68E3841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH vshard 4/6] config: introduce master 'auto' replicaset option X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! Thanks for the extensive review! >> +local function check_replicaset_master(master, ctx) >> +    if not lutil.version_is_at_least(1, 10, 0) then >> +        error('Only versions >= 1.10 support master discovery') >> +    end > > If we talk about "is_async" netbox option. We should check 1.10.1: > > https://github.com/tarantool/tarantool/commit/0f686829a89b87d4f8d10fd25d4acfdea9b3dc60#diff-1e545a3af3d3592423eff523367e962e18f7eda45c2f9bef6994a254f6044d70 > > There is a gap between 1.10.0 and 1.10.1 when there is no is_async. Good call. It is easy to fix so I did it: ==================== @@ -22,8 +22,9 @@ local function check_replica_master(master, ctx) end local function check_replicaset_master(master, ctx) - if not lutil.version_is_at_least(1, 10, 0) then - error('Only versions >= 1.10 support master discovery') + -- Limit the version due to extensive usage of netbox is_async feature. + if not lutil.version_is_at_least(1, 10, 1) then + error('Only versions >= 1.10.1 support master discovery') end if master ~= 'auto' then error('Only "auto" master is supported')