From: Vladislav Shpilevoy via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>,
tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v8 0/2] relay: provide downstream lag information
Date: Mon, 7 Jun 2021 21:20:50 +0200 [thread overview]
Message-ID: <fdaaf89e-1bfd-dc01-d719-d274292f2486@tarantool.org> (raw)
In-Reply-To: <20210607155519.109626-1-gorcunov@gmail.com>
Hi! Thanks for the patchset!
Please, provide branch and issue links next time.
https://github.com/tarantool/tarantool/wiki/Code-review-procedure#sending-the-patch
I assume your branch is gorcunov/gh-5447-relay-lag-8.
It seems after your changes some tests start failing. Looks
like you didn't clear artifacts of your new test.
https://github.com/tarantool/tarantool/runs/2765786321
On 07.06.2021 17:55, Cyrill Gorcunov wrote:
> Guys, take a look once time permit. Previous version is here
>
> https://lists.tarantool.org/tarantool-patches/20210506214132.533913-1-gorcunov@gmail.com/
>
> I still think we might need some general statistics engine because this
> lag rather common data and we could move other "last" things like last_row_time
> there but since I didn't get approve on the idea I keep the timestamp
> in replica structure.
If you are talking about your perf metrics engine which we tried to
design for replication, it was approved. The problem is that there was
no a really good design on how should it look and work.
next prev parent reply other threads:[~2021-06-07 19:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-07 15:55 Cyrill Gorcunov via Tarantool-patches
2021-06-07 15:55 ` [Tarantool-patches] [PATCH v8 1/2] applier: send transaction's first row WAL time in the applier_writer_f Cyrill Gorcunov via Tarantool-patches
2021-06-07 19:20 ` Vladislav Shpilevoy via Tarantool-patches
2021-06-15 9:36 ` Serge Petrenko via Tarantool-patches
2021-06-16 13:32 ` Cyrill Gorcunov via Tarantool-patches
2021-06-17 9:16 ` Serge Petrenko via Tarantool-patches
2021-06-07 15:55 ` [Tarantool-patches] [PATCH v8 2/2] relay: provide information about downstream lag Cyrill Gorcunov via Tarantool-patches
2021-06-07 19:21 ` Vladislav Shpilevoy via Tarantool-patches
2021-06-08 8:40 ` Cyrill Gorcunov via Tarantool-patches
2021-06-08 9:58 ` Cyrill Gorcunov via Tarantool-patches
2021-06-08 18:15 ` Vladislav Shpilevoy via Tarantool-patches
2021-06-15 10:03 ` Serge Petrenko via Tarantool-patches
2021-06-17 6:55 ` Cyrill Gorcunov via Tarantool-patches
2021-06-17 9:01 ` Serge Petrenko via Tarantool-patches
2021-06-17 9:58 ` Cyrill Gorcunov via Tarantool-patches
2021-06-07 19:20 ` Vladislav Shpilevoy via Tarantool-patches [this message]
2021-06-07 20:00 ` [Tarantool-patches] [PATCH v8 0/2] relay: provide downstream lag information Cyrill Gorcunov via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fdaaf89e-1bfd-dc01-d719-d274292f2486@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=gorcunov@gmail.com \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v8 0/2] relay: provide downstream lag information' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox