From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 4E58B6EC40; Mon, 7 Jun 2021 22:20:54 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 4E58B6EC40 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1623093654; bh=gYQkWoH/ksGU5YYTlgr49Rjp3jEDwhfAql7Nmit/ksQ=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=pBC2lmlbdmr4p/vaTUU2yWgvR0JATn+irPCfEhA584x2s/tAZgZlK5utWsVeZcRRs fXO9QYDnqqqbsnZzNbth3g/WVEsiIrjqw8GigW87oZ09PK1WDsM7ZJLZ7eS4/2L+gm z0vdvlWTAmGeeJOB3sMeOxthvO3HuSe/Dlkly2WI= Received: from smtp32.i.mail.ru (smtp32.i.mail.ru [94.100.177.92]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 7D7DF6EC40 for ; Mon, 7 Jun 2021 22:20:53 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 7D7DF6EC40 Received: by smtp32.i.mail.ru with esmtpa (envelope-from ) id 1lqKns-0005yS-3F; Mon, 07 Jun 2021 22:20:52 +0300 To: Cyrill Gorcunov , tml References: <20210607155519.109626-1-gorcunov@gmail.com> Message-ID: Date: Mon, 7 Jun 2021 21:20:50 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210607155519.109626-1-gorcunov@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9D5B0DA836B685C5423CDB5763716BB867A249A0077715520182A05F538085040CEB6B985DB88AA4464CCCBF2E797E19C697323646BCDB7AA0772F6575B00D6E7 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7DB84ED444C624799EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063750E64749F09C4ED58638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D80D4748646057C4FFAC0E5F40974D1511117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC974A882099E279BDA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735201E561CDFBCA1751FCB629EEF1311BF91D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE437C869540D2AB0F1133410A2FE6C23AD8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE31E44367C8E80A7B49735652A29929C6CC4224003CC836476EA7A3FFF5B025636E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F79006373BC478629CBEC79DEFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A24209795067102C07E8F7B195E1C97831826B4634A2153949916D7973594ED144 X-C1DE0DAB: 0D63561A33F958A564D46BF55F96D20CC9F96ABFE282F1A2FB0435935A4D8A29D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75FBC5FED0552DA851410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34CAFBC0A7A4BEEE01047CDFCFF6CF0211BDE72CF5E3290AA309FE4F173656733E0515192657D49D891D7E09C32AA3244C2FA0A7B397C14DB2BC7CA66F5F3DCC1835DA7DC5AF9B58C0927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj/099YK7Sav0Or/IhcdmsTQ== X-Mailru-Sender: 504CC1E875BF3E7D9BC0E5172ADA3110BAF80A8638872315BA42A51E9CDD363B24F8A6663DC34D9507784C02288277CA03E0582D3806FB6A5317862B1921BA260ED6CFD6382C13A6112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v8 0/2] relay: provide downstream lag information X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! Thanks for the patchset! Please, provide branch and issue links next time. https://github.com/tarantool/tarantool/wiki/Code-review-procedure#sending-the-patch I assume your branch is gorcunov/gh-5447-relay-lag-8. It seems after your changes some tests start failing. Looks like you didn't clear artifacts of your new test. https://github.com/tarantool/tarantool/runs/2765786321 On 07.06.2021 17:55, Cyrill Gorcunov wrote: > Guys, take a look once time permit. Previous version is here > > https://lists.tarantool.org/tarantool-patches/20210506214132.533913-1-gorcunov@gmail.com/ > > I still think we might need some general statistics engine because this > lag rather common data and we could move other "last" things like last_row_time > there but since I didn't get approve on the idea I keep the timestamp > in replica structure. If you are talking about your perf metrics engine which we tried to design for replication, it was approved. The problem is that there was no a really good design on how should it look and work.