From: Serge Petrenko via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>, gorcunov@gmail.com Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH] relay: yield explicitly every N sent rows Date: Wed, 24 Feb 2021 12:48:07 +0300 [thread overview] Message-ID: <fd98be2e-6bf6-d937-4b4f-2c8c57ccf57d@tarantool.org> (raw) In-Reply-To: <f7bdb1a5-bdbf-194a-0b8f-c4e288f7826d@tarantool.org> 24.02.2021 01:30, Vladislav Shpilevoy пишет: > Thanks for the patch! Thanks for the reivew! >>>> diff --git a/src/box/relay.cc b/src/box/relay.cc >>>> index 1d8edf116..6d9269e1d 100644 >>>> --- a/src/box/relay.cc >>>> +++ b/src/box/relay.cc >>>> @@ -117,6 +117,11 @@ struct relay { >>>> * is passed by the replica on subscribe. >>>> */ >>>> uint32_t id_filter; >>>> + /** >>>> + * How many rows has this relay sent to the replica. Used to yield once >>>> + * in a while when reading a WAL to unblock the event loop. >>>> + */ >>>> + size_t row_cnt; > Name is a bit ugly, because all the other members are not > contractions. They use full words. But up to you. No problem, changed to `row_count`. >>> 1. But it is not a size of anything, right? Maybe make it >>> int64_t then? >> uint64_t, probably? > Nope, int64_t. It is supposed to be 'faster'. Because it does > not have defined overflow rules, and therefore the hardware does > not need to handle it. > > But honestly, I didn't measure. For me it is more cargo cult. I > just use signed integers where I can assuming that the hardware > really may omit an instruction or so. > > Up to you. Long story short, I'd like to leave it as is. Besides, we have an unsigned type (size_t) in local recovery. Ok, now I see what you meant. I never thought of this, and brief googling showed no signs of a speedup with signed arithmetic vs unsigned. Actually, the standard says signed overflow is an undefined behaviour while an unsigned overflow should result in a wrap (modulo 2^64 in our case). Do you think this wrap may be costly on some architecture? > > The patch about power of 2 worked btw. This is how it looks now: > > andq $0x7fff, %rcx ; imm = 0x7FFF > > this is how it used to look: > > movl $0x7d00, %ecx ; imm = 0x7D00 > divq %rcx Yeah, that was a nice catch. -- Serge Petrenko
next prev parent reply other threads:[~2021-02-24 9:48 UTC|newest] Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-12 11:25 Serge Petrenko via Tarantool-patches 2021-02-12 11:37 ` Cyrill Gorcunov via Tarantool-patches 2021-02-12 11:46 ` Cyrill Gorcunov via Tarantool-patches 2021-02-12 12:08 ` Serge Petrenko via Tarantool-patches 2021-02-12 17:00 ` Cyrill Gorcunov via Tarantool-patches 2021-02-12 21:48 ` Vladislav Shpilevoy via Tarantool-patches 2021-02-12 22:25 ` Cyrill Gorcunov via Tarantool-patches 2021-02-15 8:45 ` Serge Petrenko via Tarantool-patches 2021-02-15 8:40 ` Serge Petrenko via Tarantool-patches 2021-02-17 21:11 ` Vladislav Shpilevoy via Tarantool-patches 2021-02-18 20:24 ` Serge Petrenko via Tarantool-patches 2021-02-23 22:30 ` Vladislav Shpilevoy via Tarantool-patches 2021-02-24 9:48 ` Serge Petrenko via Tarantool-patches [this message] 2021-02-24 10:15 ` Cyrill Gorcunov via Tarantool-patches 2021-02-24 10:35 ` Serge Petrenko via Tarantool-patches 2021-02-24 12:07 ` Cyrill Gorcunov via Tarantool-patches 2021-02-24 12:14 ` Serge Petrenko via Tarantool-patches 2021-02-24 22:20 ` Vladislav Shpilevoy via Tarantool-patches 2021-02-26 8:41 ` Kirill Yukhin via Tarantool-patches 2021-02-26 20:24 ` Vladislav Shpilevoy via Tarantool-patches 2021-03-01 11:25 ` Serge Petrenko via Tarantool-patches 2021-03-01 21:24 ` Vladislav Shpilevoy via Tarantool-patches 2021-03-02 9:52 ` Kirill Yukhin via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=fd98be2e-6bf6-d937-4b4f-2c8c57ccf57d@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=gorcunov@gmail.com \ --cc=sergepetrenko@tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH] relay: yield explicitly every N sent rows' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox