From: Serge Petrenko via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>, gorcunov@gmail.com Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH] relay: yield explicitly every N sent rows Date: Thu, 18 Feb 2021 23:24:43 +0300 [thread overview] Message-ID: <774363df-6be5-a7b4-ea7f-d72903f3c409@tarantool.org> (raw) In-Reply-To: <c1123bed-b0eb-3617-7c00-c259a3a1a81c@tarantool.org> 18.02.2021 00:11, Vladislav Shpilevoy пишет: > Hi! Thanks for the fixes! Thanks for the review! > >> diff --git a/src/box/relay.cc b/src/box/relay.cc >> index 1d8edf116..6d9269e1d 100644 >> --- a/src/box/relay.cc >> +++ b/src/box/relay.cc >> @@ -117,6 +117,11 @@ struct relay { >> * is passed by the replica on subscribe. >> */ >> uint32_t id_filter; >> + /** >> + * How many rows has this relay sent to the replica. Used to yield once >> + * in a while when reading a WAL to unblock the event loop. >> + */ >> + size_t row_cnt; > 1. But it is not a size of anything, right? Maybe make it > int64_t then? uint64_t, probably? I'm fine with it. Fixed on the branch. > >> @@ -846,7 +851,7 @@ relay_send(struct relay *relay, struct xrow_header *packet) >> * It may happen that the socket is always ready for write, so yield >> * explicitly every now and then to not block the event loop. >> */ >> - if (++row_cnt % WAL_ROWS_PER_YIELD == 0) >> + if (++relay->row_cnt % WAL_ROWS_PER_YIELD == 0) > 2. I just found WAL_ROWS_PER_YIELD is not a power of 2. This means > '%' may be expensive. If WAL_ROWS_PER_YIELD would be a power of 2, > '%' would be turned by the compiler into '&' to cut the remainder off. > > Maybe worth changing in a separate non-related to this bug commit? Good idea, thanks! Pushed on top of the original commit. -- Serge Petrenko
next prev parent reply other threads:[~2021-02-18 20:24 UTC|newest] Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-12 11:25 Serge Petrenko via Tarantool-patches 2021-02-12 11:37 ` Cyrill Gorcunov via Tarantool-patches 2021-02-12 11:46 ` Cyrill Gorcunov via Tarantool-patches 2021-02-12 12:08 ` Serge Petrenko via Tarantool-patches 2021-02-12 17:00 ` Cyrill Gorcunov via Tarantool-patches 2021-02-12 21:48 ` Vladislav Shpilevoy via Tarantool-patches 2021-02-12 22:25 ` Cyrill Gorcunov via Tarantool-patches 2021-02-15 8:45 ` Serge Petrenko via Tarantool-patches 2021-02-15 8:40 ` Serge Petrenko via Tarantool-patches 2021-02-17 21:11 ` Vladislav Shpilevoy via Tarantool-patches 2021-02-18 20:24 ` Serge Petrenko via Tarantool-patches [this message] 2021-02-23 22:30 ` Vladislav Shpilevoy via Tarantool-patches 2021-02-24 9:48 ` Serge Petrenko via Tarantool-patches 2021-02-24 10:15 ` Cyrill Gorcunov via Tarantool-patches 2021-02-24 10:35 ` Serge Petrenko via Tarantool-patches 2021-02-24 12:07 ` Cyrill Gorcunov via Tarantool-patches 2021-02-24 12:14 ` Serge Petrenko via Tarantool-patches 2021-02-24 22:20 ` Vladislav Shpilevoy via Tarantool-patches 2021-02-26 8:41 ` Kirill Yukhin via Tarantool-patches 2021-02-26 20:24 ` Vladislav Shpilevoy via Tarantool-patches 2021-03-01 11:25 ` Serge Petrenko via Tarantool-patches 2021-03-01 21:24 ` Vladislav Shpilevoy via Tarantool-patches 2021-03-02 9:52 ` Kirill Yukhin via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=774363df-6be5-a7b4-ea7f-d72903f3c409@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=gorcunov@gmail.com \ --cc=sergepetrenko@tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH] relay: yield explicitly every N sent rows' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox