From: Vladislav Shpilevoy via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Serge Petrenko <sergepetrenko@tarantool.org>, gorcunov@gmail.com
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v3 01/12] replication: always send raft state to subscribers
Date: Sun, 4 Jul 2021 14:12:43 +0200 [thread overview]
Message-ID: <fd31fe13-c472-08d1-4312-9edd3b81a361@tarantool.org> (raw)
In-Reply-To: <099ee3af81a4d9c9b9dece44f5d75d0c4351c91c.1624918077.git.sergepetrenko@tarantool.org>
Hi! Thanks for the patch!
On 29.06.2021 00:12, Serge Petrenko via Tarantool-patches wrote:
> Tarantool used to send out raft state on subscribe only when raft was
> enabled. This was a safeguard against partially-upgraded clusters, where
> some nodes had no clue about Raft messages and couldn't handle them
> properly.
>
> Actually, Raft state should be sent out always. For example, promote
> will be changed to bump Raft term even when Raft is disabled, and it's
> important that everyone in cluster has the same term for the sake of promote
> at least.
>
> So, send out Raft state to every subscriber with version >= 2.6.0
> (that's when Raft was introduced).
> Do the same for Raft broadcasts. They should be sent only to replicas
> with version >= 2.6.0
>
> Closes #5438
> ---
> src/box/box.cc | 11 ++--
> src/box/relay.cc | 4 +-
> test/replication/gh-5438-raft-state.result | 63 ++++++++++++++++++++
> test/replication/gh-5438-raft-state.test.lua | 28 +++++++++
I propose to rename raft -> election in the test name. To be
consistent with the existing election tests. Also it simplifies
running all of them by doing `python test-run.py election`.
next prev parent reply other threads:[~2021-07-04 12:12 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-28 22:12 [Tarantool-patches] [PATCH v3 00/12] forbid implicit limbo ownership transition Serge Petrenko via Tarantool-patches
2021-06-28 22:12 ` [Tarantool-patches] [PATCH v3 01/12] replication: always send raft state to subscribers Serge Petrenko via Tarantool-patches
2021-07-04 12:12 ` Vladislav Shpilevoy via Tarantool-patches [this message]
2021-07-09 9:43 ` Serge Petrenko via Tarantool-patches
2021-06-28 22:12 ` [Tarantool-patches] [PATCH v3 02/12] txn_limbo: fix promote term filtering Serge Petrenko via Tarantool-patches
2021-06-28 22:12 ` [Tarantool-patches] [PATCH v3 03/12] raft: refactor raft_new_term() Serge Petrenko via Tarantool-patches
2021-06-28 22:12 ` [Tarantool-patches] [PATCH v3 04/12] box: make promote always bump the term Serge Petrenko via Tarantool-patches
2021-07-04 12:14 ` Vladislav Shpilevoy via Tarantool-patches
2021-07-14 18:26 ` Serge Petrenko via Tarantool-patches
2021-06-28 22:12 ` [Tarantool-patches] [PATCH v3 05/12] replication: forbid implicit limbo owner transition Serge Petrenko via Tarantool-patches
2021-06-28 22:12 ` [Tarantool-patches] [PATCH v3 06/12] box: allow calling promote on a candidate Serge Petrenko via Tarantool-patches
2021-07-04 12:14 ` Vladislav Shpilevoy via Tarantool-patches
2021-07-14 18:26 ` Serge Petrenko via Tarantool-patches
2021-06-28 22:12 ` [Tarantool-patches] [PATCH v3 07/12] box: introduce `box.ctl.demote` Serge Petrenko via Tarantool-patches
2021-07-04 12:27 ` Vladislav Shpilevoy via Tarantool-patches
2021-07-14 18:28 ` Serge Petrenko via Tarantool-patches
2021-07-21 23:28 ` Vladislav Shpilevoy via Tarantool-patches
2021-07-23 7:44 ` Sergey Petrenko via Tarantool-patches
2021-07-26 23:50 ` Vladislav Shpilevoy via Tarantool-patches
2021-07-29 20:56 ` Sergey Petrenko via Tarantool-patches
2021-08-01 16:19 ` Vladislav Shpilevoy via Tarantool-patches
2021-08-03 7:56 ` Serge Petrenko via Tarantool-patches
2021-08-03 23:25 ` Vladislav Shpilevoy via Tarantool-patches
2021-08-04 13:08 ` Serge Petrenko via Tarantool-patches
2021-06-28 22:12 ` [Tarantool-patches] [PATCH v3 08/12] txn_limbo: persist the latest effective promote in snapshot Serge Petrenko via Tarantool-patches
2021-06-28 22:12 ` [Tarantool-patches] [PATCH v3 09/12] replication: encode version in JOIN request Serge Petrenko via Tarantool-patches
2021-07-04 12:27 ` Vladislav Shpilevoy via Tarantool-patches
2021-07-14 18:28 ` Serge Petrenko via Tarantool-patches
2021-06-28 22:12 ` [Tarantool-patches] [PATCH v3 10/12] replication: add META stage to JOIN Serge Petrenko via Tarantool-patches
2021-07-04 12:28 ` Vladislav Shpilevoy via Tarantool-patches
2021-07-14 18:28 ` Serge Petrenko via Tarantool-patches
2021-06-28 22:12 ` [Tarantool-patches] [PATCH v3 11/12] replication: send latest effective promote in initial join Serge Petrenko via Tarantool-patches
2021-07-04 12:28 ` Vladislav Shpilevoy via Tarantool-patches
2021-07-14 18:28 ` Serge Petrenko via Tarantool-patches
2021-06-28 22:12 ` [Tarantool-patches] [PATCH v3 12/12] replication: send current Raft term in join response Serge Petrenko via Tarantool-patches
2021-07-04 12:29 ` Vladislav Shpilevoy via Tarantool-patches
2021-07-14 18:28 ` Serge Petrenko via Tarantool-patches
2021-08-04 22:41 ` [Tarantool-patches] [PATCH v3 00/12] forbid implicit limbo ownership transition Vladislav Shpilevoy via Tarantool-patches
2021-08-06 7:54 ` Vitaliia Ioffe via Tarantool-patches
2021-08-06 8:31 ` Kirill Yukhin via Tarantool-patches
2021-08-08 10:46 ` Vladislav Shpilevoy via Tarantool-patches
2021-08-09 7:14 ` Kirill Yukhin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd31fe13-c472-08d1-4312-9edd3b81a361@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=gorcunov@gmail.com \
--cc=sergepetrenko@tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v3 01/12] replication: always send raft state to subscribers' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox