Re: [Tarantool-patches] [PATCH v5 1/3] gc/xlog: delay xlog cleanup until relays are subscribed

[Vladislav Shpilevoy via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi! Danke schön für der Patch!

See 3 comments below.

> diff --git a/test/replication/replica_rejoin.lua b/test/replication/replica_rejoin.lua
> new file mode 100644
> index 000000000..76f6e5b75
> --- /dev/null
> +++ b/test/replication/replica_rejoin.lua
> @@ -0,0 +1,22 @@
> +#!/usr/bin/env tarantool
> +
> +local repl_include_self = arg[1] and arg[1] == 'true' or false

1. Why do you need that parameter? It is never used in the patch.

> +local repl_list
> +
> +if repl_include_self then
> +    repl_list = {os.getenv("MASTER"), os.getenv("LISTEN")}
> +else
> +    repl_list = os.getenv("MASTER")
> +end
> +
> +-- Start the console first to allow test-run to attach even before
> +-- box.cfg is finished.
> +require('console').listen(os.getenv('ADMIN'))
> +
> +box.cfg({
> +    listen              = os.getenv("LISTEN"),
> +    replication         = repl_list,
> +    memtx_memory        = 107374182,

2. Why do you need a specific memtx memory setting?

> +    replication_timeout = 0.1,
> +    wal_cleanup_delay   = 0,

3. I would better propose you to patch replica.lua so as we could
pass wal_cleanup_delay parameter to it somehow. But I don't mind
if you would keep your way + remove the dead code above.