From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 2BB4C6FF9D; Fri, 26 Mar 2021 22:45:32 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2BB4C6FF9D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1616787932; bh=NBA2ie2YX9CEmXm+sxmQMFaOvnhImzSI6xQlMcuhsUM=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=N9r4sc/G1I8oXIp4krojQvYiHIALSYMefL26bM6H+Om4Zb+dkkyKpeA/1ev0bEjwg qDAjSVWBDbUsg4ZWnhQCuYK2ibWqpUZ7KJ3U9WQV17JNrcRUVaYnSl3N4vZSNagfYa Mvl00x5XcmlB4p1Aa62aBgwNqPV5IRrlskI3KQbA= Received: from smtp39.i.mail.ru (smtp39.i.mail.ru [94.100.177.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id D4AFB6F3C7 for ; Fri, 26 Mar 2021 22:45:30 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D4AFB6F3C7 Received: by smtp39.i.mail.ru with esmtpa (envelope-from ) id 1lPsOg-0005dx-BB; Fri, 26 Mar 2021 22:45:30 +0300 To: Cyrill Gorcunov , tml References: <20210326120605.2160131-1-gorcunov@gmail.com> <20210326120605.2160131-2-gorcunov@gmail.com> Message-ID: Date: Fri, 26 Mar 2021 20:45:29 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210326120605.2160131-2-gorcunov@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E32947427BE79D20CABD4ABD7C98AF5DBFD37182A05F538085040E4A6DD2C2CC4E24A5F24EDA5D8205F62C7D927E77B3B67CAA12C05B67D93E76F X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE72C932D6B54DFB189EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637BB680D3A894950458638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95C5DD32608FC869F5D8D9CAE7FA30B10BB8D0FFA9277B93B3FA471835C12D1D9774AD6D5ED66289B5278DA827A17800CE70F3DDF2BBF19B93A9FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C3A12191B5F2BB8629117882F4460429728AD0CFFFB425014E868A13BD56FB6657D81D268191BDAD3DC09775C1D3CA48CFEA4DE0A5A0DC5E83BA3038C0950A5D36C8A9BA7A39EFB766EC990983EF5C0329BA3038C0950A5D36D5E8D9A59859A8B6357748AADE45CB2976E601842F6C81A1F004C906525384307823802FF610243DF43C7A68FF6260569E8FC8737B5C2249B372FE9A2E580EFC725E5C173C3A84C3C9BE88FFEDFA497A35872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2368A440D3B0F6089093C9A16E5BC824AC8B6CDF511875BC4E8F7B195E1C978312A66D9CA13B7FAA3491AA492AB43C9A7 X-C1DE0DAB: 0D63561A33F958A5F8F475BE6D32B7392DE27145FF47416E7DC1A5287330D5A6D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34A246DFF68F0EE19EBB58EA6FF79D5FCDAC48D280717127C566A33E5220B56232ED2B28DD454BCF371D7E09C32AA3244CECC9B4DD232CBFF81FEF52739E60A81E795D98D676DD64D0729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojapPp7P/VpAhKKRyyrrmPtg== X-Mailru-Sender: 504CC1E875BF3E7D9BC0E5172ADA3110125A87AEA67769C45D226316AAC51ADA8A6FDB08CA8617CB07784C02288277CA03E0582D3806FB6A5317862B1921BA260ED6CFD6382C13A6112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v5 1/3] gc/xlog: delay xlog cleanup until relays are subscribed X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! Danke schön für der Patch! See 3 comments below. > diff --git a/test/replication/replica_rejoin.lua b/test/replication/replica_rejoin.lua > new file mode 100644 > index 000000000..76f6e5b75 > --- /dev/null > +++ b/test/replication/replica_rejoin.lua > @@ -0,0 +1,22 @@ > +#!/usr/bin/env tarantool > + > +local repl_include_self = arg[1] and arg[1] == 'true' or false 1. Why do you need that parameter? It is never used in the patch. > +local repl_list > + > +if repl_include_self then > + repl_list = {os.getenv("MASTER"), os.getenv("LISTEN")} > +else > + repl_list = os.getenv("MASTER") > +end > + > +-- Start the console first to allow test-run to attach even before > +-- box.cfg is finished. > +require('console').listen(os.getenv('ADMIN')) > + > +box.cfg({ > + listen = os.getenv("LISTEN"), > + replication = repl_list, > + memtx_memory = 107374182, 2. Why do you need a specific memtx memory setting? > + replication_timeout = 0.1, > + wal_cleanup_delay = 0, 3. I would better propose you to patch replica.lua so as we could pass wal_cleanup_delay parameter to it somehow. But I don't mind if you would keep your way + remove the dead code above.