From: Cyrill Gorcunov via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: tml <tarantool-patches@dev.tarantool.org> Cc: Vladislav Shpilevoy <v.shpilevoy@tarantool.org> Subject: [Tarantool-patches] [PATCH v5 0/3] gc/xlog: delay xlog cleanup until relays are subscribed Date: Fri, 26 Mar 2021 15:06:02 +0300 [thread overview] Message-ID: <20210326120605.2160131-1-gorcunov@gmail.com> (raw) Take a look please. v2: - rebase code to the fresh master branch - keep wal_cleanup_delay option name - pass wal_cleanup_delay as an option to gc_init, so it won't be dependent on cfg engine - add comment about gc_delay_unref in plain bootstrap mode - allow to setup wal_cleanup_delay dynamically - update comment in gc_wait_cleanup and call it conditionally - declare wal_cleanup_delay as a double - rename gc.cleanup_is_paused to gc.is_paused and update output - do not show ref counter in box.info.gc() output - update documentation - move gc_delay_unref inside relay_subscribe call which runs in tx context (instead of relay's context) - update tests: - add a comment why we need a temp space on replica node - use explicit insert/snapshot operations - shrkink the number of insert/snapshot to speedup testing - use "restart" instead of stop/start pair - use wait_log helper instead of own function - add is_paused test v3: - fix changelog - rework box_check_wal_cleanup_delay, the replication_anon setting is considered only in box_set_wal_cleanup_delay, ie when config is checked and parsed, moreover the order of setup is set to be behind "replication_anon" option processing - delay cycle now considers deadline instead of per cycle calculation - use `double` type for timestamp - test update - verify `.is_paused` value - minimize number of inserts - no need to use temporary space, regular space works as well - add comments on why we should restart the master node v4: - drop argument from gc_init(), since we're configuring delay value from load_cfg.lua script there is no need to read the delay early, simply start gc paused and unpause it on demand - move unpause message to main wait cycle - test update: - verify tests and fix replication/replica_rejoin since it waits for xlogs to be cleaned up too early - use 10 seconds for XlogGapError instead of 0.1 second, this is a common deadline value v5: - define limits for `wal_cleanup_delay`: it should be either 0, or in range [0.001; TIMEOUT_INFINITY]. This is done to not consider fp epsilon as a meaningul value - fix comment about why anon replica is not using delay - rework cleanup delay'ed cycle - test update: - update vinyl/replica_rejoin -- we need to disable cleanup delay explicitly - update replication/replica_rejoin for same reason - drop unneded test_run:switch() calls - add a testcase where timeout is decreased and cleanup fiber is kicked to run even with stuck replica issue https://github.com/tarantool/tarantool/issues/5806 branch gorcunov/gh-5806-xlog-gc-5 Cyrill Gorcunov (3): gc/xlog: delay xlog cleanup until relays are subscribed test: add a test for wal_cleanup_delay option test: box-tap/gc -- add test for is_paused field .../unreleased/add-wal_cleanup_delay.md | 5 + src/box/box.cc | 41 ++ src/box/box.h | 1 + src/box/gc.c | 95 +++- src/box/gc.h | 36 ++ src/box/lua/cfg.cc | 9 + src/box/lua/info.c | 4 + src/box/lua/load_cfg.lua | 5 + src/box/relay.cc | 1 + src/box/replication.cc | 2 + test/app-tap/init_script.result | 1 + test/box-tap/gc.test.lua | 3 +- test/box/admin.result | 2 + test/box/cfg.result | 4 + test/replication/gh-5806-master.lua | 8 + test/replication/gh-5806-slave.lua | 8 + test/replication/gh-5806-xlog-cleanup.result | 435 ++++++++++++++++++ .../replication/gh-5806-xlog-cleanup.test.lua | 188 ++++++++ test/replication/replica_rejoin.lua | 22 + test/replication/replica_rejoin.result | 18 +- test/replication/replica_rejoin.test.lua | 11 +- test/vinyl/replica_rejoin.lua | 5 +- test/vinyl/replica_rejoin.result | 13 + test/vinyl/replica_rejoin.test.lua | 8 + 24 files changed, 916 insertions(+), 9 deletions(-) create mode 100644 changelogs/unreleased/add-wal_cleanup_delay.md create mode 100644 test/replication/gh-5806-master.lua create mode 100644 test/replication/gh-5806-slave.lua create mode 100644 test/replication/gh-5806-xlog-cleanup.result create mode 100644 test/replication/gh-5806-xlog-cleanup.test.lua create mode 100644 test/replication/replica_rejoin.lua base-commit: f4e248c0c13a46beee238fbebc38ef687ef09d02 -- 2.30.2
next reply other threads:[~2021-03-26 12:06 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-26 12:06 Cyrill Gorcunov via Tarantool-patches [this message] 2021-03-26 12:06 ` [Tarantool-patches] [PATCH v5 1/3] " Cyrill Gorcunov via Tarantool-patches 2021-03-26 13:42 ` Serge Petrenko via Tarantool-patches 2021-03-26 19:45 ` Vladislav Shpilevoy via Tarantool-patches 2021-03-26 20:57 ` Cyrill Gorcunov via Tarantool-patches 2021-03-26 21:59 ` Cyrill Gorcunov via Tarantool-patches 2021-03-26 12:06 ` [Tarantool-patches] [PATCH v5 2/3] test: add a test for wal_cleanup_delay option Cyrill Gorcunov via Tarantool-patches 2021-03-26 13:37 ` Serge Petrenko via Tarantool-patches 2021-03-26 13:57 ` Cyrill Gorcunov via Tarantool-patches 2021-03-26 19:45 ` Vladislav Shpilevoy via Tarantool-patches 2021-03-26 12:06 ` [Tarantool-patches] [PATCH v5 3/3] test: box-tap/gc -- add test for is_paused field Cyrill Gorcunov via Tarantool-patches 2021-03-26 12:08 ` [Tarantool-patches] [PATCH v5 0/3] gc/xlog: delay xlog cleanup until relays are subscribed Cyrill Gorcunov via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210326120605.2160131-1-gorcunov@gmail.com \ --to=tarantool-patches@dev.tarantool.org \ --cc=gorcunov@gmail.com \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v5 0/3] gc/xlog: delay xlog cleanup until relays are subscribed' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox