Tarantool development patches archive
 help / color / mirror / Atom feed
From: Oleg Babin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>,
Subject: Re: [Tarantool-patches] [PATCH vshard 1/1] recovery: relax recovery messages verbosity
Date: Thu, 3 Jun 2021 16:22:52 +0300	[thread overview]
Message-ID: <f2858b75-175e-c897-a7dc-b0586e5b71b8@tarantool.org> (raw)
In-Reply-To: <ac6c9030-9eb4-4faf-4a58-c5889f375d34@tarantool.org>

Thanks for changes and answers. LGTM. Single nit below.

On 03.06.2021 15:55, Vladislav Shpilevoy wrote:
> Hi! Thanks for the review!
>>> diff --git a/vshard/storage/init.lua b/vshard/storage/init.lua
>>> index 7045d91..8a019fa 100644
>>> --- a/vshard/storage/init.lua
>>> +++ b/vshard/storage/init.lua
>>> @@ -736,21 +736,25 @@ local function recovery_step_by_type(type)
>>>        local is_empty = true
>> To be honest I don't completely understand what "is_empty" means.
> It means the recovery step is empty - didn't find anything to
> recover.
> I use it so as not to log 'Starting ... buckets recovery step' on
> each call of recovery_step_by_type() - would be too many useless
> logs.

Ok, thanks for your answers. Probably, it's better to rename "is_empty" 
to "step_is_empty".

It's ok if you'll answer "no", since it's refactoring.

  reply	other threads:[~2021-06-03 13:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-02 21:34 Vladislav Shpilevoy via Tarantool-patches
2021-06-03 10:19 ` Oleg Babin via Tarantool-patches
2021-06-03 12:55   ` Vladislav Shpilevoy via Tarantool-patches
2021-06-03 13:22     ` Oleg Babin via Tarantool-patches [this message]
2021-06-03 14:13       ` Vladislav Shpilevoy via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f2858b75-175e-c897-a7dc-b0586e5b71b8@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=olegrok@tarantool.org \
    --cc=v.shpilevoy@tarantool.org \
    --cc=yaroslav.dynnikov@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH vshard 1/1] recovery: relax recovery messages verbosity' \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox