From: Vladislav Shpilevoy via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Oleg Babin <olegrok@tarantool.org>, tarantool-patches@dev.tarantool.org, yaroslav.dynnikov@tarantool.org Subject: Re: [Tarantool-patches] [PATCH vshard 1/1] recovery: relax recovery messages verbosity Date: Thu, 3 Jun 2021 14:55:05 +0200 [thread overview] Message-ID: <ac6c9030-9eb4-4faf-4a58-c5889f375d34@tarantool.org> (raw) In-Reply-To: <38f8a40b-4fe7-f26a-ddc5-7f088445e4f2@tarantool.org> Hi! Thanks for the review! >> diff --git a/vshard/storage/init.lua b/vshard/storage/init.lua >> index 7045d91..8a019fa 100644 >> --- a/vshard/storage/init.lua >> +++ b/vshard/storage/init.lua >> @@ -736,21 +736,25 @@ local function recovery_step_by_type(type) >> local is_empty = true > > To be honest I don't completely understand what "is_empty" means. It means the recovery step is empty - didn't find anything to recover. I use it so as not to log 'Starting ... buckets recovery step' on each call of recovery_step_by_type() - would be too many useless logs. >> local recovered = 0 >> local total = 0 >> + local start_format = 'Starting %s buckets recovery step' >> for _, bucket in _bucket.index.status:pairs(type) do >> total = total + 1 >> local bucket_id = bucket.id >> if M.rebalancer_transfering_buckets[bucket_id] then > > Side-note: transfering -> transferring Too late. There are tons of typos really, in all the code and comments. Worth making a patch to fix them all, but I am too lazy for that. Prefer to fix the typos along functional changes. >> goto continue >> end >> - if is_empty then >> - log.info('Starting %s buckets recovery step', type) >> - end >> - is_empty = false >> assert(bucket_is_transfer_in_progress(bucket)) >> - local destination = M.replicasets[bucket.destination] >> + local peer_uuid = bucket.destination >> + local destination = M.replicasets[peer_uuid] >> if not destination or not destination.master then >> -- No replicaset master for a bucket. Wait until it >> -- appears. > > This comment states that there is no critical and it's appropriate and we should just wait. Why "error" and not "warn"? Indeed, sounds fair. Changed to log.warn.
next prev parent reply other threads:[~2021-06-03 12:55 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-02 21:34 Vladislav Shpilevoy via Tarantool-patches 2021-06-03 10:19 ` Oleg Babin via Tarantool-patches 2021-06-03 12:55 ` Vladislav Shpilevoy via Tarantool-patches [this message] 2021-06-03 13:22 ` Oleg Babin via Tarantool-patches 2021-06-03 14:13 ` Vladislav Shpilevoy via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ac6c9030-9eb4-4faf-4a58-c5889f375d34@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=olegrok@tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --cc=yaroslav.dynnikov@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH vshard 1/1] recovery: relax recovery messages verbosity' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox