From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 3D9536EC40; Thu, 3 Jun 2021 15:55:10 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 3D9536EC40 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1622724910; bh=uuqLjh3t/7S3BU2sKPy/tWRP7wsvJalejFn8rFZU36E=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=jkC0eiJv3Np1ajU8lhIa83KKvsn/FzJ0jTjX48As7MjwTy3d3icf6jchWe0d03HpY 7Cxsw/FP20YbpKA0RmOR9J9PGMZQJ+NBUfweK3ElRxHAKjQN6NJWnF3Bl60Ul3m0v5 guzAhG4hW16DRQsveqYZYbM/REAgv89YVE8g507Q= Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 36EF86EC40 for ; Thu, 3 Jun 2021 15:55:08 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 36EF86EC40 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1lomsM-000161-Uq; Thu, 03 Jun 2021 15:55:07 +0300 To: Oleg Babin , tarantool-patches@dev.tarantool.org, yaroslav.dynnikov@tarantool.org References: <38f8a40b-4fe7-f26a-ddc5-7f088445e4f2@tarantool.org> Message-ID: Date: Thu, 3 Jun 2021 14:55:05 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: <38f8a40b-4fe7-f26a-ddc5-7f088445e4f2@tarantool.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9D5B0DA836B685C549A9F97C297FFF2C725C7934AD8E7B4B9182A05F538085040D02AC1661D8FC9142E9BFB715C7B12AA971577BE98D70E4FDB8708C066EC4044 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE737AE489DBC023F2AEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063790C8302959DAAF098638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8C1694F9AF311B93074F2DE4A8549494B117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC1F8789D36234D406A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F4460429728776938767073520B1593CA6EC85F86D28451B159A507268D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6B1CFA6D474D4A6A4089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A50CE224AF0CB6FF83659DE7399DFC96EBD1FADAA826CC6987D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75FBC5FED0552DA851410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3454CC76E5F54B410C1F6E5530B01A0A7C86EC556EE39F9B3CD4F5D7E749DD0965EE8BBC2B8C93016B1D7E09C32AA3244CDEE7771F5C3D59E4B2FB33C254E9C4DF435BF7150578642FFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojNbQUdF9mq4HRZE4C5ZDh+A== X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822F2A7B73296D6180629011695C7F7A7B33841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH vshard 1/1] recovery: relax recovery messages verbosity X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! Thanks for the review! >> diff --git a/vshard/storage/init.lua b/vshard/storage/init.lua >> index 7045d91..8a019fa 100644 >> --- a/vshard/storage/init.lua >> +++ b/vshard/storage/init.lua >> @@ -736,21 +736,25 @@ local function recovery_step_by_type(type) >>       local is_empty = true > > To be honest I don't completely understand what "is_empty" means. It means the recovery step is empty - didn't find anything to recover. I use it so as not to log 'Starting ... buckets recovery step' on each call of recovery_step_by_type() - would be too many useless logs. >>       local recovered = 0 >>       local total = 0 >> +    local start_format = 'Starting %s buckets recovery step' >>       for _, bucket in _bucket.index.status:pairs(type) do >>           total = total + 1 >>           local bucket_id = bucket.id >>           if M.rebalancer_transfering_buckets[bucket_id] then > > Side-note: transfering -> transferring Too late. There are tons of typos really, in all the code and comments. Worth making a patch to fix them all, but I am too lazy for that. Prefer to fix the typos along functional changes. >>               goto continue >>           end >> -        if is_empty then >> -            log.info('Starting %s buckets recovery step', type) >> -        end >> -        is_empty = false >>           assert(bucket_is_transfer_in_progress(bucket)) >> -        local destination = M.replicasets[bucket.destination] >> +        local peer_uuid = bucket.destination >> +        local destination = M.replicasets[peer_uuid] >>           if not destination or not destination.master then >>               -- No replicaset master for a bucket. Wait until it >>               -- appears. > > This comment states that there is no critical and it's appropriate and we should just wait. Why "error" and not "warn"? Indeed, sounds fair. Changed to log.warn.