From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 8A8266EC40; Thu, 3 Jun 2021 16:22:54 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 8A8266EC40 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1622726574; bh=kUxguldQXTpqbyHmxShk9Dp/xxSgirDn1gzszBDKUjE=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=qK+wGJbM0lbRxJww4u77i5/DkjAl6g4mW84EUTIAsVnAwJnrWdg0jaQgR7OH9yhUG mixGK3K+nK5qq0oyv0cZ114VGZaOdZ6HIdNepj6iH3dDUhwH96/HwSdGX4i5XP9dJi T6lAoidgmMF5Pud6Nb53mIF31aN8aem5beiRZXhs= Received: from smtp59.i.mail.ru (smtp59.i.mail.ru [217.69.128.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 797806EC40 for ; Thu, 3 Jun 2021 16:22:53 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 797806EC40 Received: by smtp59.i.mail.ru with esmtpa (envelope-from ) id 1lonJE-000335-J2; Thu, 03 Jun 2021 16:22:52 +0300 To: Vladislav Shpilevoy , tarantool-patches@dev.tarantool.org, yaroslav.dynnikov@tarantool.org References: <38f8a40b-4fe7-f26a-ddc5-7f088445e4f2@tarantool.org> Message-ID: Date: Thu, 3 Jun 2021 16:22:52 +0300 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9D5B0DA836B685C54F4BC37E91F2690B85F43D7652182C513182A05F5380850405B7186FD88FCC3768F7095CFA4C644059388781BA1312FF0212298023DFB8D9E X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7257031E595304076EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063770995E888C5C26978638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8E9396262B455AF77311F2EE4ED596837117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCE96A3A8AAADC8934A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F4460429728776938767073520B1593CA6EC85F86DF04B652EEC242312D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE0AC5B80A05675ACD49AF716F719AB83ED8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE3FE4D9CDE3FF759CF040F9FF01DFDA4A8C4224003CC836476EA7A3FFF5B025636E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637427B078F297B269AEFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A24209795067102C07E8F7B195E1C97831E8BF5653C77FE5848FF110C78C8E6CED X-C1DE0DAB: 0D63561A33F958A54D53E6CB4BEDEB6A57BFF39E660219D3D0E63FDAF3138011D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75FBC5FED0552DA851410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D348B409C2D257583DFC8C97175B9752293F3EB61A21B5EFD2691B6E1B0094B41AA0909B4B24C9336361D7E09C32AA3244CA21C89677E354388D40B4B1788A9E0A497FE24653F78E668FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojNbQUdF9mq4Fa51iBJ18Edg== X-Mailru-Sender: 583F1D7ACE8F49BD07526C4546A62CBFED0BF97A1612EB6985215533D8C73C2B2D5436CFEB97BCB123E75C7104EB1B885DEE61814008E47C7013064206BFB89F93956FB04BA385BE9437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH vshard 1/1] recovery: relax recovery messages verbosity X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Oleg Babin via Tarantool-patches Reply-To: Oleg Babin Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for changes and answers. LGTM. Single nit below. On 03.06.2021 15:55, Vladislav Shpilevoy wrote: > Hi! Thanks for the review! > >>> diff --git a/vshard/storage/init.lua b/vshard/storage/init.lua >>> index 7045d91..8a019fa 100644 >>> --- a/vshard/storage/init.lua >>> +++ b/vshard/storage/init.lua >>> @@ -736,21 +736,25 @@ local function recovery_step_by_type(type) >>>       local is_empty = true >> To be honest I don't completely understand what "is_empty" means. > It means the recovery step is empty - didn't find anything to > recover. > > I use it so as not to log 'Starting ... buckets recovery step' on > each call of recovery_step_by_type() - would be too many useless > logs. Ok, thanks for your answers. Probably, it's better to rename "is_empty" to "step_is_empty". It's ok if you'll answer "no", since it's refactoring.