Tarantool development patches archive
 help / color / mirror / Atom feed
From: Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Kaplun <skaplun@tarantool.org>,
	Igor Munkin <imun@tarantool.org>,
	Maxim Kokryashkin <m.kokryashkin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v3 luajit 2/6] test: introduce module for C tests
Date: Wed, 7 Jun 2023 18:51:06 +0300	[thread overview]
Message-ID: <d52e95b4-ec7f-f21f-64a2-92cb04cbd1d5@tarantool.org> (raw)
In-Reply-To: <1fcbd8cc-44ab-484f-1cd5-715701282049@tarantool.org>


On 6/5/23 18:08, Sergey Bronnikov via Tarantool-patches wrote:
> Sergey,
>
> thanks for patches and fixes. See my comments below.
>
> On 6/5/23 13:41, Sergey Kaplun wrote: 
<snipped>
>> It's functionality inspired by CMocka API [1], but only TAP14 [2]
>> protocol is supported (Version of TAP set to 13 to be compatible with
>> old TAP13 harnesses).
>>
>> The group of unit tests is declared like the following:
>>
>> | void *t_state = NULL;
>> | const struct test_unit tgroup[] = {
>> |     test_unit_new(test_base),
>
> As I proposed in discussion verbally, I suggest to remove postfix 
> "_new" because
>
> we have opposite function with destructor ("test_unit_delete").
>
>
there is a typo. I mean "we have *no* opposite function with destructor"

  reply	other threads:[~2023-06-07 15:51 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-05 10:41 [Tarantool-patches] [PATCH v3 luajit 0/6] Reworking " Sergey Kaplun via Tarantool-patches
2023-06-05 10:41 ` [Tarantool-patches] [PATCH v3 luajit 1/6] test: fix setting of {DY}LD_LIBRARY_PATH variables Sergey Kaplun via Tarantool-patches
2023-06-05 14:21   ` Sergey Bronnikov via Tarantool-patches
2023-06-05 10:41 ` [Tarantool-patches] [PATCH v3 luajit 2/6] test: introduce module for C tests Sergey Kaplun via Tarantool-patches
2023-06-05 15:08   ` Sergey Bronnikov via Tarantool-patches
2023-06-07 15:51     ` Sergey Bronnikov via Tarantool-patches [this message]
2023-06-05 10:41 ` [Tarantool-patches] [PATCH v3 luajit 3/6] test: introduce utils.h helper " Sergey Kaplun via Tarantool-patches
2023-06-05 15:11   ` Sergey Bronnikov via Tarantool-patches
2023-06-05 10:41 ` [Tarantool-patches] [PATCH v3 luajit 4/6] test: rewrite misclib-getmetrics-capi test in C Sergey Kaplun via Tarantool-patches
2023-06-07 16:25   ` Sergey Bronnikov via Tarantool-patches
2023-06-05 10:41 ` [Tarantool-patches] [PATCH v3 luajit 5/6] test: rewrite misclib-sysprof-capi " Sergey Kaplun via Tarantool-patches
2023-06-07 16:18   ` Sergey Bronnikov via Tarantool-patches
2023-06-05 10:41 ` [Tarantool-patches] [PATCH v3 luajit 6/6] test: rewrite lj-49-bad-lightuserdata " Sergey Kaplun via Tarantool-patches
2023-06-07 16:14   ` Sergey Bronnikov via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d52e95b4-ec7f-f21f-64a2-92cb04cbd1d5@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=imun@tarantool.org \
    --cc=m.kokryashkin@tarantool.org \
    --cc=sergeyb@tarantool.org \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v3 luajit 2/6] test: introduce module for C tests' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox