From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 920614DD246; Wed, 7 Jun 2023 18:51:09 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 920614DD246 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1686153069; bh=KqdAEVPDLGJuYwBg0C1vN9BRT0ZJsEkBVJVG2wdaWyg=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=Q85XmZB6fEcE4p2xKpTHakfazbUTUAEm/8ZU+fli/PhZzWj5VFFjJKzNFYspEMhbo oe6Bgx+1BceOtVx8sSENcnbKRFCQsr/GD2cB/HL3D7kMwb3lw7pn7Rf0MEkQr2RS4v IWkb+240OeXT76wUZDfYB8o+nEV/eEy/MgpaHVp8= Received: from smtp35.i.mail.ru (smtp35.i.mail.ru [95.163.41.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 19F144868F8 for ; Wed, 7 Jun 2023 18:51:08 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 19F144868F8 Received: by smtp35.i.mail.ru with esmtpa (envelope-from ) id 1q6vRD-00AMh3-1B; Wed, 07 Jun 2023 18:51:07 +0300 Message-ID: Date: Wed, 7 Jun 2023 18:51:06 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Content-Language: en-US To: Sergey Kaplun , Igor Munkin , Maxim Kokryashkin Cc: tarantool-patches@dev.tarantool.org References: <97194cc5150bc632c5fd566c9f34033413af1518.1685613304.git.skaplun@tarantool.org> <1fcbd8cc-44ab-484f-1cd5-715701282049@tarantool.org> In-Reply-To: <1fcbd8cc-44ab-484f-1cd5-715701282049@tarantool.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD93D74B10BAB639DE360A4B584FEEB8AE5D4382E0625B63A6100894C459B0CD1B938B81887A4E050D3729D8170FF67B77260EB29BB429F46F8DECA3C7A6D0F0B69 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7C6068CE86C2B75F5EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637652CD06254D2F21C8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8E36A07F5AB524F477EE0A9A3BA8FD040117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAB5495298CADBD05A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735207B96B19DC40933212CC0D3CB04F14752D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE4B6963042765DA4B4782AAF36435267CD8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE3949686D59A6ADCEA040F9FF01DFDA4A8C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947C2FFDA4F57982C5F42E808ACE2090B5E1725E5C173C3A84C3C5EA940A35A165FF2DBA43225CD8A89F83C798A30B85E16B5E1C53F199C2BB95B5C8C57E37DE458BEDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A5F7B8EF96449EC809F6B2560C4D0BCF5BE882F8738B50D074F87CCE6106E1FC07E67D4AC08A07B9B0DB8A315C1FF4794DBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D340E23B77EA1807817574CD838A20FF1850EC507B3ED15B4034D5707AC25705E4D63FBFB0DCD13AB1D1D7E09C32AA3244CA5C1FF4440214FF88E8BE641A4C7FA76795D98D676DD64D0BAD658CF5C8AB4025DA084F8E80FEBD3FFA33E6B6B2F82C47A83BD0C44CE203720ABEDE4BBDD9CDD X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojC5OBK/dlsGORQnTOTSqIig== X-Mailru-Sender: C4F68CFF4024C8867DFDF7C7F2588458363CD0F32A925C99D8546A1B634569783C486436259F529C282EC151BADDC1D3523A6D01B4765B2DFB59E2DDD9FE06B14FA522850F29BC30B0DAF586E7D11B3E67EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v3 luajit 2/6] test: introduce module for C tests X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On 6/5/23 18:08, Sergey Bronnikov via Tarantool-patches wrote: > Sergey, > > thanks for patches and fixes. See my comments below. > > On 6/5/23 13:41, Sergey Kaplun wrote: >> It's functionality inspired by CMocka API [1], but only TAP14 [2] >> protocol is supported (Version of TAP set to 13 to be compatible with >> old TAP13 harnesses). >> >> The group of unit tests is declared like the following: >> >> | void *t_state = NULL; >> | const struct test_unit tgroup[] = { >> |     test_unit_new(test_base), > > As I proposed in discussion verbally, I suggest to remove postfix > "_new" because > > we have opposite function with destructor ("test_unit_delete"). > > there is a typo. I mean "we have *no* opposite function with destructor"