Tarantool development patches archive
 help / color / mirror / Atom feed
From: Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Kaplun <skaplun@tarantool.org>,
	Igor Munkin <imun@tarantool.org>,
	Maxim Kokryashkin <m.kokryashkin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v3 luajit 5/6] test: rewrite misclib-sysprof-capi test in C
Date: Wed, 7 Jun 2023 19:18:57 +0300	[thread overview]
Message-ID: <3013bac0-eb92-ec51-f75d-14ca05c5b599@tarantool.org> (raw)
In-Reply-To: <b56f4eb1017b8ad8ebc7191ed2a8ad1e9952af3f.1685613304.git.skaplun@tarantool.org>

Sergey,


thanks for the patch! LGTM


On 6/5/23 13:41, Sergey Kaplun wrote:
> This patch rewrites the aforementioned test with the usage libtest
> recently introduced. The approach is similar to the previous patch.
> `c_payload()` function to profile is now set up globally on script
> loading. The payload for enabled and disabled JIT is the same. As far as
> for sysprof testing is necessary to replace backtrace with libunwind
> first, the payload tests are marked with `todo()`.
>
> Nevertheless, glibc `assert()` still necessary to check the correctness
> of the profile writer, so it is still used there.
>
> Relates to tarantool/tarantool#781
> Part of tarantool/tarantool#7900
> ---
>   .../misclib-sysprof-capi-script.lua           |  35 ++
>   .../misclib-sysprof-capi.test.c               | 325 ++++++++++++++++++
>   test/tarantool-tests/CMakeLists.txt           |   1 -
>   .../misclib-sysprof-capi.test.lua             |  54 ---
>   .../misclib-sysprof-capi/CMakeLists.txt       |   1 -
>   .../misclib-sysprof-capi/testsysprof.c        | 260 --------------
>   6 files changed, 360 insertions(+), 316 deletions(-)
>   create mode 100644 test/tarantool-c-tests/misclib-sysprof-capi-script.lua
>   create mode 100644 test/tarantool-c-tests/misclib-sysprof-capi.test.c
>   delete mode 100644 test/tarantool-tests/misclib-sysprof-capi.test.lua
>   delete mode 100644 test/tarantool-tests/misclib-sysprof-capi/CMakeLists.txt
>   delete mode 100644 test/tarantool-tests/misclib-sysprof-capi/testsysprof.c
>
> diff --git a/test/tarantool-c-tests/misclib-sysprof-capi-script.lua b/test/tarantool-c-tests/misclib-sysprof-capi-script.lua
> new file mode 100644
> index 00000000..dd8387db
> --- /dev/null
> +++ b/test/tarantool-c-tests/misclib-sysprof-capi-script.lua
> @@ -0,0 +1,35 @@
> +local M = {}
> +
> +-- luacheck: no global
> +assert(c_payload, 'c_payload global function should be set via script loader')
> +
> +local function lua_payload(n)
> +  if n <= 1 then
> +    return n
> +  end
> +  return lua_payload(n - 1) + lua_payload(n - 2)
> +end
> +
> +local function payload()
> +  local n_iterations = 500000
> +
> +  local co = coroutine.create(function()
> +    for i = 1, n_iterations do
> +      if i % 2 == 0 then
> +        c_payload(10)
> +      else
> +        lua_payload(10)
> +      end
> +      coroutine.yield()
> +    end
> +  end)
> +
> +  for _ = 1, n_iterations do
> +    coroutine.resume(co)
> +  end
> +end
> +
> +M.profile_func_jiton = payload
> +M.profile_func_jitoff = payload
> +
> +return M
> diff --git a/test/tarantool-c-tests/misclib-sysprof-capi.test.c b/test/tarantool-c-tests/misclib-sysprof-capi.test.c
> new file mode 100644
> index 00000000..4a7a0d46
> --- /dev/null
> +++ b/test/tarantool-c-tests/misclib-sysprof-capi.test.c
> @@ -0,0 +1,325 @@
> +#include "lauxlib.h"
> +#include "lmisclib.h"
> +#include "lua.h"
> +#include "luajit.h"
> +
> +#include "test.h"
> +#include "utils.h"
> +
> +#include <errno.h>
> +#include <fcntl.h>
> +#include <stdlib.h>
> +#include <unistd.h>
> +
> +/* XXX: Still need normal assert inside writer functions. */
> +#undef NDEBUG
> +#include <assert.h>
> +
> +/* Need for skipcond for OS and ARCH. */
> +#include "lj_arch.h"
> +
> +#define UNUSED(x) ((void)(x))
> +
> +/* --- utils -------------------------------------------------- */
> +
> +#define SYSPROF_INTERVAL_DEFAULT 100
> +
> +/*
> + * Yep, 8Mb. Tuned in order not to bother the platform with too
> + * often flushes.
> + */
> +#define STREAM_BUFFER_SIZE (8 * 1024 * 1024)
> +
> +
> +/* --- C Payload ---------------------------------------------- */
> +
> +static double fib(double n)
> +{
> +	if (n <= 1)
> +		return n;
> +	return fib(n - 1) + fib(n - 2);
> +}
> +
> +static int c_payload(lua_State *L)
> +{
> +	fib(luaL_checknumber(L, 1));
> +	lua_pushboolean(L, 1);
> +	return 1;
> +}
> +/* --- sysprof C API tests ------------------------------------ */
> +
> +static int base(void *test_state)
> +{
> +	UNUSED(test_state);
> +	struct luam_Sysprof_Options opt = {};
> +	struct luam_Sysprof_Counters cnt = {};
> +
> +	(void)opt.interval;
> +	(void)opt.mode;
> +	(void)opt.ctx;
> +	(void)opt.buf;
> +	(void)opt.len;
> +
> +	luaM_sysprof_report(&cnt);
> +
> +	(void)cnt.samples;
> +	(void)cnt.vmst_interp;
> +	(void)cnt.vmst_lfunc;
> +	(void)cnt.vmst_ffunc;
> +	(void)cnt.vmst_cfunc;
> +	(void)cnt.vmst_gc;
> +	(void)cnt.vmst_exit;
> +	(void)cnt.vmst_record;
> +	(void)cnt.vmst_opt;
> +	(void)cnt.vmst_asm;
> +	(void)cnt.vmst_trace;
> +
> +	return TEST_EXIT_SUCCESS;
> +}
> +
> +static int validation(void *test_state)
> +{
> +	lua_State *L = test_state;
> +	struct luam_Sysprof_Options opt = {};
> +	int status = PROFILE_SUCCESS;
> +
> +	/* Unknown mode. */
> +	opt.mode = 0x40;
> +	status = luaM_sysprof_start(L, &opt);
> +	assert_true(status == PROFILE_ERRUSE);
> +
> +	/* Buffer not configured. */
> +	opt.mode = LUAM_SYSPROF_CALLGRAPH;
> +	opt.buf = NULL;
> +	status = luaM_sysprof_start(L, &opt);
> +	assert_true(status == PROFILE_ERRUSE);
> +
> +	/* Bad interval. */
> +	opt.mode = LUAM_SYSPROF_DEFAULT;
> +	opt.interval = 0;
> +	status = luaM_sysprof_start(L, &opt);
> +	assert_true(status == PROFILE_ERRUSE);
> +
> +	/* Check if profiling started. */
> +	opt.mode = LUAM_SYSPROF_DEFAULT;
> +	opt.interval = SYSPROF_INTERVAL_DEFAULT;
> +	status = luaM_sysprof_start(L, &opt);
> +	assert_true(status == PROFILE_SUCCESS);
> +
> +	/* Already running. */
> +	status = luaM_sysprof_start(L, &opt);
> +	assert_true(status == PROFILE_ERRRUN);
> +
> +	/* Profiler stopping. */
> +	status = luaM_sysprof_stop(L);
> +	assert_true(status == PROFILE_SUCCESS);
> +
> +	/* Stopping profiler which is not running. */
> +	status = luaM_sysprof_stop(L);
> +	assert_true(status == PROFILE_ERRRUN);
> +
> +	return TEST_EXIT_SUCCESS;
> +}
> +
> +/*
> + * FIXME: The following two tests are disabled because sometimes
> + * `backtrace` dynamically loads a platform-specific unwinder,
> + * which is not signal-safe.
> + */
> +
> +#if 0
> +/*
> + * Structure given as ctx to sysprof writer and on_stop callback.
> + */
> +struct sysprof_ctx {
> +	/* Output file descriptor for data. */
> +	int fd;
> +	/* Buffer for data. */
> +	uint8_t buf[STREAM_BUFFER_SIZE];
> +};
> +
> +/*
> + * Default buffer writer function.
> + * Just call fwrite to the corresponding FILE.
> + */
> +static size_t buffer_writer_default(const void **buf_addr, size_t len,
> +				    void *opt)
> +{
> +	struct sysprof_ctx *ctx = opt;
> +	int fd = ctx->fd;
> +	const void * const buf_start = *buf_addr;
> +	const void *data = *buf_addr;
> +	size_t write_total = 0;
> +
> +	assert(len <= STREAM_BUFFER_SIZE);
> +
> +	for (;;) {
> +		const size_t written = write(fd, data, len - write_total);
> +
> +		if (written == 0) {
> +			/* Re-tries write in case of EINTR. */
> +			if (errno != EINTR) {
> +				/*
> +				 * Will be freed as whole chunk
> +				 * later.
> +				 */
> +				*buf_addr = NULL;
> +				return write_total;
> +			}
> +			errno = 0;
> +			continue;
> +		}
> +
> +		write_total += written;
> +		assert(write_total <= len);
> +
> +		if (write_total == len)
> +			break;
> +
> +		data = (uint8_t *)data + (ptrdiff_t)written;
> +	}
> +
> +	*buf_addr = buf_start;
> +	return write_total;
> +}
> +
> +/*
> + * Default on stop callback. Just close the corresponding stream.
> + */
> +static int on_stop_cb_default(void *opt, uint8_t *buf)
> +{
> +	UNUSED(buf);
> +	struct sysprof_ctx *ctx = opt;
> +	int fd = ctx->fd;
> +	free(ctx);
> +	return close(fd);
> +}
> +
> +static int stream_init(struct luam_Sysprof_Options *opt)
> +{
> +	struct sysprof_ctx *ctx = calloc(1, sizeof(struct sysprof_ctx));
> +	if (NULL == ctx)
> +		return PROFILE_ERRIO;
> +
> +	ctx->fd = open("/dev/null", O_WRONLY | O_CREAT, 0644);
> +	if (-1 == ctx->fd) {
> +		free(ctx);
> +		return PROFILE_ERRIO;
> +	}
> +
> +	opt->ctx = ctx;
> +	opt->buf = ctx->buf;
> +	opt->len = STREAM_BUFFER_SIZE;
> +
> +	return PROFILE_SUCCESS;
> +}
> +
> +/* Get function to profile on top, call it. */
> +static int check_profile_func(lua_State *L)
> +{
> +	struct luam_Sysprof_Options opt = {};
> +	struct luam_Sysprof_Counters cnt = {};
> +	int status = PROFILE_ERRUSE;
> +	/*
> +	 * Since all the other modes functionality is the
> +	 * subset of CALLGRAPH mode, run this mode to test
> +	 * the profiler's behavior.
> +	 */
> +	opt.mode = LUAM_SYSPROF_CALLGRAPH;
> +	opt.interval = SYSPROF_INTERVAL_DEFAULT;
> +	stream_init(&opt);
> +
> +	/*
> +	 * XXX: Payload function on top will not be removed if any
> +	 * of those assertions fail. So, the next call to the
> +	 * `utils_get_aux_lfunc()` will fail. It's OK, since
> +	 * we are already in trouble, just keep it in mind.
> +	 */
> +	assert_true(luaM_sysprof_set_writer(buffer_writer_default)
> +		    == PROFILE_SUCCESS);
> +	assert_true(luaM_sysprof_set_on_stop(on_stop_cb_default)
> +		    == PROFILE_SUCCESS);
> +	assert_true(luaM_sysprof_set_backtracer(NULL) == PROFILE_SUCCESS);
> +
> +	status = luaM_sysprof_start(L, &opt);
> +	assert_true(status == PROFILE_SUCCESS);
> +
> +	/* Run payload. */
> +	if (lua_pcall(L, 0, 0, 0) != LUA_OK) {
> +		test_comment("error running payload: %s", lua_tostring(L, -1));
> +		bail_out("error running sysprof test payload");
> +	}
> +
> +	status = luaM_sysprof_stop(L);
> +	assert_true(status == PROFILE_SUCCESS);
> +
> +	status = luaM_sysprof_report(&cnt);
> +	assert_true(status == PROFILE_SUCCESS);
> +
> +	assert_true(cnt.samples > 1);
> +	assert_true(cnt.samples == cnt.vmst_asm +
> +			cnt.vmst_cfunc +
> +			cnt.vmst_exit +
> +			cnt.vmst_ffunc +
> +			cnt.vmst_gc +
> +			cnt.vmst_interp +
> +			cnt.vmst_lfunc +
> +			cnt.vmst_opt +
> +			cnt.vmst_record +
> +			cnt.vmst_trace);
> +
> +	return TEST_EXIT_SUCCESS;
> +}
> +#endif
> +
> +static int profile_func_jitoff(void *test_state)
> +{
> +	UNUSED(test_state);
> +	return todo("Need to replace backtrace with libunwind first");
> +#if 0
> +	lua_State *L = test_state;
> +	utils_get_aux_lfunc(L);
> +	(void)luaJIT_setmode(L, 0, LUAJIT_MODE_ENGINE | LUAJIT_MODE_OFF);
> +	(void)luaJIT_setmode(L, 0, LUAJIT_MODE_ENGINE | LUAJIT_MODE_FLUSH);
> +	check_profile_func(L);
> +	(void)luaJIT_setmode(L, 0, LUAJIT_MODE_ENGINE | LUAJIT_MODE_ON);
> +	return TEST_EXIT_SUCCESS;
> +#endif
> +}
> +
> +static int profile_func_jiton(void *test_state)
> +{
> +	UNUSED(test_state);
> +	return todo("Need to replace backtrace with libunwind first");
> +#if 0
> +	lua_State *L = test_state;
> +	utils_get_aux_lfunc(L);
> +	check_profile_func(L);
> +	return TEST_EXIT_SUCCESS;
> +#endif
> +}
> +
> +int main(void)
> +{
> +	if (LUAJIT_OS != LUAJIT_OS_LINUX)
> +		return skip_all("Sysprof is implemented for Linux only");
> +	if (LUAJIT_TARGET != LUAJIT_ARCH_X86
> +	    && LUAJIT_TARGET != LUAJIT_ARCH_X64)
> +		return skip_all("Sysprof is implemented for x86_64 only");
> +
> +	lua_State *L = utils_lua_init();
> +
> +	lua_pushcfunction(L, c_payload);
> +	lua_setfield(L, LUA_GLOBALSINDEX, "c_payload");
> +	utils_load_aux_script(L, "misclib-sysprof-capi-script.lua");
> +
> +	const struct test_unit tgroup[] = {
> +		test_unit_new(base),
> +		test_unit_new(validation),
> +		test_unit_new(profile_func_jitoff),
> +		test_unit_new(profile_func_jiton)
> +	};
> +	const int test_result = test_run_group(tgroup, L);
> +	utils_lua_close(L);
> +	return test_result;
> +}
> diff --git a/test/tarantool-tests/CMakeLists.txt b/test/tarantool-tests/CMakeLists.txt
> index b4ce39d3..b1c7207f 100644
> --- a/test/tarantool-tests/CMakeLists.txt
> +++ b/test/tarantool-tests/CMakeLists.txt
> @@ -66,7 +66,6 @@ add_subdirectory(lj-416-xor-before-jcc)
>   add_subdirectory(lj-601-fix-gc-finderrfunc)
>   add_subdirectory(lj-727-lightuserdata-itern)
>   add_subdirectory(lj-flush-on-trace)
> -add_subdirectory(misclib-sysprof-capi)
>   
>   # The part of the memory profiler toolchain is located in tools
>   # directory, jit, profiler, and bytecode toolchains are located
> diff --git a/test/tarantool-tests/misclib-sysprof-capi.test.lua b/test/tarantool-tests/misclib-sysprof-capi.test.lua
> deleted file mode 100644
> index 4395bce3..00000000
> --- a/test/tarantool-tests/misclib-sysprof-capi.test.lua
> +++ /dev/null
> @@ -1,54 +0,0 @@
> -local tap = require("tap")
> -local test = tap.test("clib-misc-sysprof"):skipcond({
> -  ["Sysprof is implemented for x86_64 only"] = jit.arch ~= "x86" and
> -                                               jit.arch ~= "x64",
> -  ["Sysprof is implemented for Linux only"] = jit.os ~= "Linux",
> -})
> -
> -test:plan(2)
> -
> -local testsysprof = require("testsysprof")
> -
> -jit.off()
> -
> -test:ok(testsysprof.base())
> -test:ok(testsysprof.validation())
> -
> --- FIXME: The following two tests are disabled because sometimes
> --- `backtrace` dynamically loads a platform-specific unwinder, which is
> --- not signal-safe.
> ---[[
> -local function lua_payload(n)
> -  if n <= 1 then
> -    return n
> -  end
> -  return lua_payload(n - 1) + lua_payload(n - 2)
> -end
> -
> -local function payload()
> -  local n_iterations = 500000
> -
> -  local co = coroutine.create(function ()
> -    for i = 1, n_iterations do
> -      if i % 2 == 0 then
> -        testsysprof.c_payload(10)
> -      else
> -        lua_payload(10)
> -      end
> -      coroutine.yield()
> -    end
> -  end)
> -
> -  for _ = 1, n_iterations do
> -    coroutine.resume(co)
> -  end
> -end
> -
> -test:ok(testsysprof.profile_func(payload))
> -
> -jit.on()
> -jit.flush()
> -
> -test:ok(testsysprof.profile_func(payload))
> ---]]
> -os.exit(test:check() and 0 or 1)
> diff --git a/test/tarantool-tests/misclib-sysprof-capi/CMakeLists.txt b/test/tarantool-tests/misclib-sysprof-capi/CMakeLists.txt
> deleted file mode 100644
> index d9fb1a1a..00000000
> --- a/test/tarantool-tests/misclib-sysprof-capi/CMakeLists.txt
> +++ /dev/null
> @@ -1 +0,0 @@
> -BuildTestCLib(testsysprof testsysprof.c)
> diff --git a/test/tarantool-tests/misclib-sysprof-capi/testsysprof.c b/test/tarantool-tests/misclib-sysprof-capi/testsysprof.c
> deleted file mode 100644
> index d7a3e355..00000000
> --- a/test/tarantool-tests/misclib-sysprof-capi/testsysprof.c
> +++ /dev/null
> @@ -1,260 +0,0 @@
> -#include <lua.h>
> -#include <luajit.h>
> -#include <lauxlib.h>
> -
> -#include <lmisclib.h>
> -
> -#include <fcntl.h>
> -#include <stdlib.h>
> -#include <unistd.h>
> -#include <errno.h>
> -
> -#undef NDEBUG
> -#include <assert.h>
> -
> -#define UNUSED(x) ((void)(x))
> -
> -/* --- utils -------------------------------------------------------------- */
> -
> -#define SYSPROF_INTERVAL_DEFAULT 100
> -
> -/*
> - ** Yep, 8Mb. Tuned in order not to bother the platform with too often flushes.
> - */
> -#define STREAM_BUFFER_SIZE (8 * 1024 * 1024)
> -
> -/* Structure given as ctx to sysprof writer and on_stop callback. */
> -struct sysprof_ctx {
> -	/* Output file descriptor for data. */
> -	int fd;
> -	/* Buffer for data. */
> -	uint8_t buf[STREAM_BUFFER_SIZE];
> -};
> -
> -/*
> - ** Default buffer writer function.
> - ** Just call fwrite to the corresponding FILE.
> - */
> -static size_t buffer_writer_default(const void **buf_addr, size_t len,
> -		void *opt)
> -{
> -	struct sysprof_ctx *ctx = opt;
> -	int fd = ctx->fd;
> -	const void * const buf_start = *buf_addr;
> -	const void *data = *buf_addr;
> -	size_t write_total = 0;
> -
> -	assert(len <= STREAM_BUFFER_SIZE);
> -
> -	for (;;) {
> -		const size_t written = write(fd, data, len - write_total);
> -
> -		if (written == 0) {
> -			/* Re-tries write in case of EINTR. */
> -			if (errno != EINTR) {
> -				/* Will be freed as whole chunk later. */
> -				*buf_addr = NULL;
> -				return write_total;
> -			}
> -			errno = 0;
> -			continue;
> -		}
> -
> -		write_total += written;
> -		assert(write_total <= len);
> -
> -		if (write_total == len)
> -			break;
> -
> -		data = (uint8_t *)data + (ptrdiff_t)written;
> -	}
> -
> -	*buf_addr = buf_start;
> -	return write_total;
> -}
> -
> -/* Default on stop callback. Just close the corresponding stream. */
> -static int on_stop_cb_default(void *opt, uint8_t *buf)
> -{
> -	UNUSED(buf);
> -	struct sysprof_ctx *ctx = opt;
> -	int fd = ctx->fd;
> -	free(ctx);
> -	return close(fd);
> -}
> -
> -static int stream_init(struct luam_Sysprof_Options *opt)
> -{
> -	struct sysprof_ctx *ctx = calloc(1, sizeof(struct sysprof_ctx));
> -	if (NULL == ctx)
> -		return PROFILE_ERRIO;
> -
> -	ctx->fd = open("/dev/null", O_WRONLY | O_CREAT, 0644);
> -	if (-1 == ctx->fd) {
> -		free(ctx);
> -		return PROFILE_ERRIO;
> -	}
> -
> -	opt->ctx = ctx;
> -	opt->buf = ctx->buf;
> -	opt->len = STREAM_BUFFER_SIZE;
> -
> -	return PROFILE_SUCCESS;
> -}
> -
> -/* --- Payload ------------------------------------------------------------ */
> -
> -static double fib(double n)
> -{
> -	if (n <= 1)
> -		return n;
> -	return fib(n - 1) + fib(n - 2);
> -}
> -
> -static int c_payload(lua_State *L)
> -{
> -	fib(luaL_checknumber(L, 1));
> -	lua_pushboolean(L, 1);
> -	return 1;
> -}
> -
> -/* --- sysprof C API tests ------------------------------------------------ */
> -
> -static int base(lua_State *L)
> -{
> -	struct luam_Sysprof_Options opt = {};
> -	struct luam_Sysprof_Counters cnt = {};
> -
> -	(void)opt.interval;
> -	(void)opt.mode;
> -	(void)opt.ctx;
> -	(void)opt.buf;
> -	(void)opt.len;
> -
> -	luaM_sysprof_report(&cnt);
> -
> -	(void)cnt.samples;
> -	(void)cnt.vmst_interp;
> -	(void)cnt.vmst_lfunc;
> -	(void)cnt.vmst_ffunc;
> -	(void)cnt.vmst_cfunc;
> -	(void)cnt.vmst_gc;
> -	(void)cnt.vmst_exit;
> -	(void)cnt.vmst_record;
> -	(void)cnt.vmst_opt;
> -	(void)cnt.vmst_asm;
> -	(void)cnt.vmst_trace;
> -
> -	lua_pushboolean(L, 1);
> -	return 1;
> -}
> -
> -static int validation(lua_State *L)
> -{
> -	struct luam_Sysprof_Options opt = {};
> -	int status = PROFILE_SUCCESS;
> -
> -	/* Unknown mode. */
> -	opt.mode = 0x40;
> -	status = luaM_sysprof_start(L, &opt);
> -	assert(PROFILE_ERRUSE == status);
> -
> -	/* Buffer not configured. */
> -	opt.mode = LUAM_SYSPROF_CALLGRAPH;
> -	opt.buf = NULL;
> -	status = luaM_sysprof_start(L, &opt);
> -	assert(PROFILE_ERRUSE == status);
> -
> -	/* Bad interval. */
> -	opt.mode = LUAM_SYSPROF_DEFAULT;
> -	opt.interval = 0;
> -	status = luaM_sysprof_start(L, &opt);
> -	assert(PROFILE_ERRUSE == status);
> -
> -	/* Check if profiling started. */
> -	opt.mode = LUAM_SYSPROF_DEFAULT;
> -	opt.interval = SYSPROF_INTERVAL_DEFAULT;
> -	status = luaM_sysprof_start(L, &opt);
> -	assert(PROFILE_SUCCESS == status);
> -
> -	/* Already running. */
> -	status = luaM_sysprof_start(L, &opt);
> -	assert(PROFILE_ERRRUN == status);
> -
> -	/* Profiler stopping. */
> -	status = luaM_sysprof_stop(L);
> -	assert(PROFILE_SUCCESS == status);
> -
> -	/* Stopping profiler which is not running. */
> -	status = luaM_sysprof_stop(L);
> -	assert(PROFILE_ERRRUN == status);
> -
> -	lua_pushboolean(L, 1);
> -	return 1;
> -}
> -
> -static int profile_func(lua_State *L)
> -{
> -	struct luam_Sysprof_Options opt = {};
> -	struct luam_Sysprof_Counters cnt = {};
> -	int status = PROFILE_ERRUSE;
> -
> -	int n = lua_gettop(L);
> -	if (n != 1 || !lua_isfunction(L, 1))
> -		luaL_error(L, "incorrect argument: 1 function is required");
> -
> -	/*
> -	 ** Since all the other modes functionality is the
> -	 ** subset of CALLGRAPH mode, run this mode to test
> -	 ** the profiler's behavior.
> -	 */
> -	opt.mode = LUAM_SYSPROF_CALLGRAPH;
> -	opt.interval = SYSPROF_INTERVAL_DEFAULT;
> -	stream_init(&opt);
> -
> -	assert(luaM_sysprof_set_writer(buffer_writer_default) == PROFILE_SUCCESS);
> -	assert(luaM_sysprof_set_on_stop(on_stop_cb_default) == PROFILE_SUCCESS);
> -	assert(luaM_sysprof_set_backtracer(NULL) == PROFILE_SUCCESS);
> -
> -	status = luaM_sysprof_start(L, &opt);
> -	assert(PROFILE_SUCCESS == status);
> -
> -	/* Run payload. */
> -	if (lua_pcall(L, 0, 0, 0) != LUA_OK)
> -		luaL_error(L, "error running payload: %s", lua_tostring(L, -1));
> -
> -	status = luaM_sysprof_stop(L);
> -	assert(PROFILE_SUCCESS == status);
> -
> -	status = luaM_sysprof_report(&cnt);
> -	assert(PROFILE_SUCCESS == status);
> -
> -	assert(cnt.samples > 1);
> -	assert(cnt.samples == cnt.vmst_asm +
> -			cnt.vmst_cfunc +
> -			cnt.vmst_exit +
> -			cnt.vmst_ffunc +
> -			cnt.vmst_gc +
> -			cnt.vmst_interp +
> -			cnt.vmst_lfunc +
> -			cnt.vmst_opt +
> -			cnt.vmst_record +
> -			cnt.vmst_trace);
> -
> -	lua_pushboolean(L, 1);
> -	return 1;
> -}
> -
> -static const struct luaL_Reg testsysprof[] = {
> -	{"base", base},
> -	{"c_payload", c_payload},
> -	{"profile_func", profile_func},
> -	{"validation", validation},
> -	{NULL, NULL}
> -};
> -
> -LUA_API int luaopen_testsysprof(lua_State *L)
> -{
> -	luaL_register(L, "testsysprof", testsysprof);
> -	return 1;
> -}

  reply	other threads:[~2023-06-07 16:18 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-05 10:41 [Tarantool-patches] [PATCH v3 luajit 0/6] Reworking C tests Sergey Kaplun via Tarantool-patches
2023-06-05 10:41 ` [Tarantool-patches] [PATCH v3 luajit 1/6] test: fix setting of {DY}LD_LIBRARY_PATH variables Sergey Kaplun via Tarantool-patches
2023-06-05 14:21   ` Sergey Bronnikov via Tarantool-patches
2023-06-05 10:41 ` [Tarantool-patches] [PATCH v3 luajit 2/6] test: introduce module for C tests Sergey Kaplun via Tarantool-patches
2023-06-05 15:08   ` Sergey Bronnikov via Tarantool-patches
2023-06-07 15:51     ` Sergey Bronnikov via Tarantool-patches
2023-06-05 10:41 ` [Tarantool-patches] [PATCH v3 luajit 3/6] test: introduce utils.h helper " Sergey Kaplun via Tarantool-patches
2023-06-05 15:11   ` Sergey Bronnikov via Tarantool-patches
2023-06-05 10:41 ` [Tarantool-patches] [PATCH v3 luajit 4/6] test: rewrite misclib-getmetrics-capi test in C Sergey Kaplun via Tarantool-patches
2023-06-07 16:25   ` Sergey Bronnikov via Tarantool-patches
2023-06-05 10:41 ` [Tarantool-patches] [PATCH v3 luajit 5/6] test: rewrite misclib-sysprof-capi " Sergey Kaplun via Tarantool-patches
2023-06-07 16:18   ` Sergey Bronnikov via Tarantool-patches [this message]
2023-06-05 10:41 ` [Tarantool-patches] [PATCH v3 luajit 6/6] test: rewrite lj-49-bad-lightuserdata " Sergey Kaplun via Tarantool-patches
2023-06-07 16:14   ` Sergey Bronnikov via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3013bac0-eb92-ec51-f75d-14ca05c5b599@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=imun@tarantool.org \
    --cc=m.kokryashkin@tarantool.org \
    --cc=sergeyb@tarantool.org \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v3 luajit 5/6] test: rewrite misclib-sysprof-capi test in C' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox