Re: [Tarantool-patches] [PATCH v6 2/3] test: add a test for wal_cleanup_delay option

[Vladislav Shpilevoy via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi! Thanks for the patch!

> diff --git a/test/replication/gh-5806-xlog-cleanup.result b/test/replication/gh-5806-xlog-cleanup.result
> new file mode 100644
> index 000000000..da09daf17
> --- /dev/null
> +++ b/test/replication/gh-5806-xlog-cleanup.result
> @@ -0,0 +1,558 @@
> +master_uuid = test_run:eval('master', 'return box.info.uuid')[1]
> + | ---
> + | ...
> +replica_uuid = test_run:eval('replica', 'return box.info.uuid')[1]
> + | ---
> + | ...
> +master_custer = test_run:eval('master', 'return box.space._cluster:select()')[1]

1. master_custer -> master_cluster.

> +
> +test_run:switch('master')
> + | ---
> + | - true
> + | ...
> +test_run:cmd('restart server master with args="3600"')
> + | 
> +assert(box.info.gc().is_paused == true)

2. Do you know that boolean expressions don't need to be compared
with the boolean constants explicitly? You could write

	assert(box.info.gc().is_paused).

The same in all the other similar places in this file. Especially
where you do '== false' which is super confusing.