From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id C08BA6EC5B; Tue, 30 Mar 2021 00:07:32 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C08BA6EC5B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617052052; bh=xA4Xq2AUz/IKUKf7Av4m/pyVccbOU8h6YdWX84bWOlc=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=uWkv5l4YWNbU1aQN/+yOGMjwQ0orYhtH7KR6Cjohmcg6DD7cbWNS/IQ5v6P8Fmq6Q ZGtt4uUBLhv+T2GEq4Kj1jSyVs/ulFNuW2G5YeT2nYdzC5CBummmasFAy/pqXqYXdm einsCtNf8CjhpnhqobCiLYeZvfsAxqDpxHEFKuCc= Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 1A6B56EC5B for ; Tue, 30 Mar 2021 00:07:32 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1A6B56EC5B Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1lQz6h-0002Ya-0B; Tue, 30 Mar 2021 00:07:31 +0300 To: Cyrill Gorcunov , tml References: <20210327111310.37504-1-gorcunov@gmail.com> <20210327111310.37504-3-gorcunov@gmail.com> Message-ID: Date: Mon, 29 Mar 2021 23:07:29 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210327111310.37504-3-gorcunov@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E32947A0146560F8BA709498CFB6209D8582A182A05F53808504094D6C056B985713F3B652CFC2E59401C713D943953D0D6E826C38004E5BD3D8E X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7705F446BE41E38A1EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637782358EF9635990EEA1F7E6F0F101C67CDEEF6D7F21E0D1D174C73DBBBFC76648736E98A3ECD134100E96469F5E705A1AE2AE1774DA6E3B7389733CBF5DBD5E913377AFFFEAFD269A417C69337E82CC2CC7F00164DA146DAFE8445B8C89999729449624AB7ADAF37F6B57BC7E64490611E7FA7ABCAF51C92176DF2183F8FC7C07E7E81EEA8A9722B8941B15DA834481F9449624AB7ADAF372E808ACE2090B5E14AD6D5ED66289B5259CC434672EE6371089D37D7C0E48F6C8AA50765F79006373BC478629CBEC79DEFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2AD77751E876CB595E8F7B195E1C978316C9A32F2A5062D9B7892AAF64C174D19 X-C1DE0DAB: 0D63561A33F958A5009C34C6731625A2BC71BA39BC4404669F368DB0FC021BB3D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D342B94C1DAF75C4D2259A84982D830108FF10405DE594176BB284EBFD755B30617D3F1D8CB20E44A2E1D7E09C32AA3244CEC5B04500C83748F8029DC4629F1B70B795D98D676DD64D0927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojljIiQOC84rQ/ZtX3k+aLWA== X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822F3D1E690728B51C342CC8F7433B02DC43841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v6 2/3] test: add a test for wal_cleanup_delay option X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! Thanks for the patch! > diff --git a/test/replication/gh-5806-xlog-cleanup.result b/test/replication/gh-5806-xlog-cleanup.result > new file mode 100644 > index 000000000..da09daf17 > --- /dev/null > +++ b/test/replication/gh-5806-xlog-cleanup.result > @@ -0,0 +1,558 @@ > +master_uuid = test_run:eval('master', 'return box.info.uuid')[1] > + | --- > + | ... > +replica_uuid = test_run:eval('replica', 'return box.info.uuid')[1] > + | --- > + | ... > +master_custer = test_run:eval('master', 'return box.space._cluster:select()')[1] 1. master_custer -> master_cluster. > + > +test_run:switch('master') > + | --- > + | - true > + | ... > +test_run:cmd('restart server master with args="3600"') > + | > +assert(box.info.gc().is_paused == true) 2. Do you know that boolean expressions don't need to be compared with the boolean constants explicitly? You could write assert(box.info.gc().is_paused). The same in all the other similar places in this file. Especially where you do '== false' which is super confusing.