Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v6 2/3] test: add a test for wal_cleanup_delay option
Date: Tue, 30 Mar 2021 21:59:03 +0200	[thread overview]
Message-ID: <99a52a18-3a81-8fb7-0ca8-af5195822631@tarantool.org> (raw)
In-Reply-To: <YGLRHBzxs1P2Zlsh@grain>

On 30.03.2021 09:19, Cyrill Gorcunov via Tarantool-patches wrote:
> On Tue, Mar 30, 2021 at 12:56:47AM +0200, Vladislav Shpilevoy wrote:
>>>
>>> Wait, I just don't understand. is_paused is a boolean type and
>>> I compare it with a boolean value. Could you simply point me
>>> the preferred way to compare if some particular value is false.
>>> I used assert() 'cause I found similar code, if there some more
>>> suiatble way to test the value, sure thing I can use whatever
>>> you prefer, just point me an example.
>>
>> Ok, I open the latest replication test we added (gh-5536), and
>> I see the line
>>
>> 	assert(box.space.test:count() == 10)
>>
>> It does not look like this:
>>
>> 	assert((box.space.test:count() == 10) == true)
>>
>> does it? Because it is pointless to have 'boolean' type in a
> 
> This is because the count() is a numeric value. What had been
> there if 'count()' would return a boolean?

I don't see how it is related to count() being numeric. I
am talking about 'count() == 10', not about the 'count()'
itself. That expression is boolean, and therefore is supposed
to be used with boolean operators.

  parent reply	other threads:[~2021-03-30 19:59 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-27 11:13 [Tarantool-patches] [PATCH v6 0/3] gc/xlog: delay xlog cleanup until relays are subscribed Cyrill Gorcunov via Tarantool-patches
2021-03-27 11:13 ` [Tarantool-patches] [PATCH v6 1/3] " Cyrill Gorcunov via Tarantool-patches
2021-03-27 11:13 ` [Tarantool-patches] [PATCH v6 2/3] test: add a test for wal_cleanup_delay option Cyrill Gorcunov via Tarantool-patches
2021-03-29 21:07   ` Vladislav Shpilevoy via Tarantool-patches
2021-03-29 21:46     ` Cyrill Gorcunov via Tarantool-patches
2021-03-29 21:54       ` Vladislav Shpilevoy via Tarantool-patches
2021-03-29 21:57         ` Cyrill Gorcunov via Tarantool-patches
2021-03-29 22:19           ` Vladislav Shpilevoy via Tarantool-patches
2021-03-29 22:40             ` Cyrill Gorcunov via Tarantool-patches
2021-03-29 22:56               ` Vladislav Shpilevoy via Tarantool-patches
2021-03-30  7:19                 ` Cyrill Gorcunov via Tarantool-patches
2021-03-30 11:55                   ` Cyrill Gorcunov via Tarantool-patches
2021-03-30 19:59                   ` Vladislav Shpilevoy via Tarantool-patches [this message]
2021-03-27 11:13 ` [Tarantool-patches] [PATCH v6 3/3] test: box-tap/gc -- add test for is_paused field Cyrill Gorcunov via Tarantool-patches
2021-03-30 19:57 ` [Tarantool-patches] [PATCH v6 0/3] gc/xlog: delay xlog cleanup until relays are subscribed Vladislav Shpilevoy via Tarantool-patches
2021-03-31  8:28 ` Kirill Yukhin via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=99a52a18-3a81-8fb7-0ca8-af5195822631@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=gorcunov@gmail.com \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v6 2/3] test: add a test for wal_cleanup_delay option' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox